[INFO] updating cached repository mossberg/relish [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mossberg/relish [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mossberg/relish" "work/ex/clippy-test-run/sources/stable/gh/mossberg/relish"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mossberg/relish'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mossberg/relish" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mossberg/relish"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mossberg/relish'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 67b0baa5dbd351ad43b08b8c81cc3bf97f5f5f49 [INFO] sha for GitHub repo mossberg/relish: 67b0baa5dbd351ad43b08b8c81cc3bf97f5f5f49 [INFO] validating manifest of mossberg/relish on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mossberg/relish on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mossberg/relish [INFO] finished frobbing mossberg/relish [INFO] frobbed toml for mossberg/relish written to work/ex/clippy-test-run/sources/stable/gh/mossberg/relish/Cargo.toml [INFO] started frobbing mossberg/relish [INFO] finished frobbing mossberg/relish [INFO] frobbed toml for mossberg/relish written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mossberg/relish/Cargo.toml [INFO] crate mossberg/relish has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mossberg/relish against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mossberg/relish:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ea37e9f4950a400b8948794a344a285d11deb874bc236d85838f7f033a41e14f [INFO] running `"docker" "start" "-a" "ea37e9f4950a400b8948794a344a285d11deb874bc236d85838f7f033a41e14f"` [INFO] [stderr] Checking relish v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Read`, `stdin` [INFO] [stderr] --> src/main.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{stdin, Read, BufReader,BufRead}; [INFO] [stderr] | ^^^^^ ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 55 | | if let Err(why) = cmd.stdout(Stdio::inherit()) [INFO] [stderr] 56 | | .stderr(Stdio::inherit()) [INFO] [stderr] 57 | | .output() { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if let Err(why) = cmd.stdout(Stdio::inherit()) [INFO] [stderr] 55 | .stderr(Stdio::inherit()) [INFO] [stderr] 56 | .output() { [INFO] [stderr] 57 | if let Some(errno) = why.raw_os_error() { [INFO] [stderr] 58 | match errno { [INFO] [stderr] 59 | 2 => printerr!(format!("{}: {}", cmdline.cmd, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | env::home_dir().unwrap_or(PathBuf::from(".")) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Read`, `stdin` [INFO] [stderr] --> src/main.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{stdin, Read, BufReader,BufRead}; [INFO] [stderr] | ^^^^^ ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 55 | | if let Err(why) = cmd.stdout(Stdio::inherit()) [INFO] [stderr] 56 | | .stderr(Stdio::inherit()) [INFO] [stderr] 57 | | .output() { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if let Err(why) = cmd.stdout(Stdio::inherit()) [INFO] [stderr] 55 | .stderr(Stdio::inherit()) [INFO] [stderr] 56 | .output() { [INFO] [stderr] 57 | if let Some(errno) = why.raw_os_error() { [INFO] [stderr] 58 | match errno { [INFO] [stderr] 59 | 2 => printerr!(format!("{}: {}", cmdline.cmd, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | env::home_dir().unwrap_or(PathBuf::from(".")) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | let dir = if cmdline.args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cmdline.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:86:33 [INFO] [stderr] | [INFO] [stderr] 86 | env::home_dir().unwrap_or(PathBuf::from(".")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:92:47 [INFO] [stderr] | [INFO] [stderr] 92 | .unwrap_or(".".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| ".".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:101:42 [INFO] [stderr] | [INFO] [stderr] 101 | .unwrap_or(PathBuf::from(".".to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| PathBuf::from(".".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:122:37 [INFO] [stderr] | [INFO] [stderr] 122 | let username = env::var("USER").unwrap_or("???".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "???".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:154:16 [INFO] [stderr] | [INFO] [stderr] 154 | if cmdline.bg == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `cmdline.bg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:166:20 [INFO] [stderr] | [INFO] [stderr] 166 | if cmdline.bg == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `cmdline.bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | let dir = if cmdline.args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cmdline.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:86:33 [INFO] [stderr] | [INFO] [stderr] 86 | env::home_dir().unwrap_or(PathBuf::from(".")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:92:47 [INFO] [stderr] | [INFO] [stderr] 92 | .unwrap_or(".".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| ".".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:101:42 [INFO] [stderr] | [INFO] [stderr] 101 | .unwrap_or(PathBuf::from(".".to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| PathBuf::from(".".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:122:37 [INFO] [stderr] | [INFO] [stderr] 122 | let username = env::var("USER").unwrap_or("???".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "???".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:154:16 [INFO] [stderr] | [INFO] [stderr] 154 | if cmdline.bg == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `cmdline.bg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:166:20 [INFO] [stderr] | [INFO] [stderr] 166 | if cmdline.bg == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `cmdline.bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.86s [INFO] running `"docker" "inspect" "ea37e9f4950a400b8948794a344a285d11deb874bc236d85838f7f033a41e14f"` [INFO] running `"docker" "rm" "-f" "ea37e9f4950a400b8948794a344a285d11deb874bc236d85838f7f033a41e14f"` [INFO] [stdout] ea37e9f4950a400b8948794a344a285d11deb874bc236d85838f7f033a41e14f