[INFO] updating cached repository moshohayeb/tictac [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/moshohayeb/tictac [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/moshohayeb/tictac" "work/ex/clippy-test-run/sources/stable/gh/moshohayeb/tictac"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/moshohayeb/tictac'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/moshohayeb/tictac" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moshohayeb/tictac"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moshohayeb/tictac'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4f2d497b95322c2e6b5672eaf2f05e2d7405a054 [INFO] sha for GitHub repo moshohayeb/tictac: 4f2d497b95322c2e6b5672eaf2f05e2d7405a054 [INFO] validating manifest of moshohayeb/tictac on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of moshohayeb/tictac on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing moshohayeb/tictac [INFO] finished frobbing moshohayeb/tictac [INFO] frobbed toml for moshohayeb/tictac written to work/ex/clippy-test-run/sources/stable/gh/moshohayeb/tictac/Cargo.toml [INFO] started frobbing moshohayeb/tictac [INFO] finished frobbing moshohayeb/tictac [INFO] frobbed toml for moshohayeb/tictac written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moshohayeb/tictac/Cargo.toml [INFO] crate moshohayeb/tictac has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting moshohayeb/tictac against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moshohayeb/tictac:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad2f0b05e3360c301b32ebe27c5269568dfb46f098e8ac1ed93679b24776aabc [INFO] running `"docker" "start" "-a" "ad2f0b05e3360c301b32ebe27c5269568dfb46f098e8ac1ed93679b24776aabc"` [INFO] [stderr] Checking tictac v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stderr] --> src/lib.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> Self { [INFO] [stderr] 55 | | Game { [INFO] [stderr] 56 | | board: Default::default(), [INFO] [stderr] 57 | | turn: Piece::X, [INFO] [stderr] 58 | | winner: None, [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | impl Default for Game { [INFO] [stderr] 54 | fn default() -> Self { [INFO] [stderr] 55 | Self::new() [INFO] [stderr] 56 | } [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `board`. [INFO] [stderr] --> src/lib.rs:139:18 [INFO] [stderr] | [INFO] [stderr] 139 | for i in 0..=2 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 139 | for in board.iter().take(2 + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | if let Some(_) = self.board[row][col] { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 159 | | return Err(GameError::NotEmpty); [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________- help: try this: `if self.board[row][col].is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stderr] --> src/lib.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> Self { [INFO] [stderr] 55 | | Game { [INFO] [stderr] 56 | | board: Default::default(), [INFO] [stderr] 57 | | turn: Piece::X, [INFO] [stderr] 58 | | winner: None, [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | impl Default for Game { [INFO] [stderr] 54 | fn default() -> Self { [INFO] [stderr] 55 | Self::new() [INFO] [stderr] 56 | } [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `board`. [INFO] [stderr] --> src/lib.rs:139:18 [INFO] [stderr] | [INFO] [stderr] 139 | for i in 0..=2 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 139 | for in board.iter().take(2 + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | if let Some(_) = self.board[row][col] { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 159 | | return Err(GameError::NotEmpty); [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________- help: try this: `if self.board[row][col].is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "ad2f0b05e3360c301b32ebe27c5269568dfb46f098e8ac1ed93679b24776aabc"` [INFO] running `"docker" "rm" "-f" "ad2f0b05e3360c301b32ebe27c5269568dfb46f098e8ac1ed93679b24776aabc"` [INFO] [stdout] ad2f0b05e3360c301b32ebe27c5269568dfb46f098e8ac1ed93679b24776aabc