[INFO] updating cached repository moreheadm/nut-shell [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/moreheadm/nut-shell [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/moreheadm/nut-shell" "work/ex/clippy-test-run/sources/stable/gh/moreheadm/nut-shell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/moreheadm/nut-shell'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/moreheadm/nut-shell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moreheadm/nut-shell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moreheadm/nut-shell'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 82ec10f8f0793fe5614330f11329650abeae5a9d [INFO] sha for GitHub repo moreheadm/nut-shell: 82ec10f8f0793fe5614330f11329650abeae5a9d [INFO] validating manifest of moreheadm/nut-shell on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of moreheadm/nut-shell on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing moreheadm/nut-shell [INFO] finished frobbing moreheadm/nut-shell [INFO] frobbed toml for moreheadm/nut-shell written to work/ex/clippy-test-run/sources/stable/gh/moreheadm/nut-shell/Cargo.toml [INFO] started frobbing moreheadm/nut-shell [INFO] finished frobbing moreheadm/nut-shell [INFO] frobbed toml for moreheadm/nut-shell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moreheadm/nut-shell/Cargo.toml [INFO] crate moreheadm/nut-shell has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting moreheadm/nut-shell against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moreheadm/nut-shell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e30ce3f1bccd797c35ec12434f79f7ac22908014442a100eace68d604e30dce [INFO] running `"docker" "start" "-a" "6e30ce3f1bccd797c35ec12434f79f7ac22908014442a100eace68d604e30dce"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking liner v0.4.4 [INFO] [stderr] Checking nut-shell v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary path disambiguator [INFO] [stderr] --> src/execute.rs:116:39 [INFO] [stderr] | [INFO] [stderr] 116 | .collect::>(); [INFO] [stderr] | ^^ try removing `::` [INFO] [stderr] [INFO] [stderr] warning: unnecessary path disambiguator [INFO] [stderr] --> src/execute.rs:116:39 [INFO] [stderr] | [INFO] [stderr] 116 | .collect::>(); [INFO] [stderr] | ^^ try removing `::` [INFO] [stderr] [INFO] [stderr] warning: unused import: `ParseOp` [INFO] [stderr] --> src/main.rs:10:32 [INFO] [stderr] | [INFO] [stderr] 10 | use parser::{ParseRes, Parsed, ParseOp}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ParseOp` [INFO] [stderr] --> src/main.rs:10:32 [INFO] [stderr] | [INFO] [stderr] 10 | use parser::{ParseRes, Parsed, ParseOp}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufRead` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::BufRead; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `command` [INFO] [stderr] --> src/execute.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn run_builtin(command: &Vec) { [INFO] [stderr] | ^^^^^^^ help: consider using `_command` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `curr_expr` [INFO] [stderr] --> src/parser.rs:368:42 [INFO] [stderr] | [INFO] [stderr] 368 | fn parse_bracketed_param(text: &str, mut curr_expr: String) -> (ParseRes, &str) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_curr_expr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stdin` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let stdin = io::stdin(); [INFO] [stderr] | ^^^^^ help: consider using `_stdin` instead [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufRead` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::BufRead; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:368:38 [INFO] [stderr] | [INFO] [stderr] 368 | fn parse_bracketed_param(text: &str, mut curr_expr: String) -> (ParseRes, &str) { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `command` [INFO] [stderr] --> src/execute.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn run_builtin(command: &Vec) { [INFO] [stderr] | ^^^^^^^ help: consider using `_command` instead [INFO] [stderr] warning: function is never used: `run_builtin` [INFO] [stderr] --> src/execute.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn run_builtin(command: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `And` [INFO] [stderr] --> src/parser.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | And, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Or` [INFO] [stderr] --> src/parser.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Or, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Seq` [INFO] [stderr] --> src/parser.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Seq, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Expr` [INFO] [stderr] --> src/parser.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Expr(Box, Box, ParseOp), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Param` [INFO] [stderr] --> src/parser.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | Param(String), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Arith` [INFO] [stderr] --> src/parser.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | Arith(String) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/execute.rs:9:34 [INFO] [stderr] | [INFO] [stderr] 9 | fn vec_to_c_str_ptr(command: &Vec) -> (Vec, Vec<*const c_char>) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `curr_expr` [INFO] [stderr] --> src/parser.rs:368:42 [INFO] [stderr] | [INFO] [stderr] 368 | fn parse_bracketed_param(text: &str, mut curr_expr: String) -> (ParseRes, &str) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_curr_expr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stdin` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let stdin = io::stdin(); [INFO] [stderr] | ^^^^^ help: consider using `_stdin` instead [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/execute.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | for ref word in command { [INFO] [stderr] | ^^^^^^^^ ------- help: try: `let word = &command;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/execute.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn builtin_cd(command: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/execute.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | if chdir(CString::new(dir.as_str()).unwrap().as_ptr()) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/execute.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | if chdir(CString::new(dir.as_str()).unwrap().as_ptr()) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/execute.rs:40:33 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn run_builtin(command: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/execute.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn run_file(command: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/execute.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn run_command(command: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:186:20 [INFO] [stderr] | [INFO] [stderr] 186 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:205:28 [INFO] [stderr] | [INFO] [stderr] 205 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:218:20 [INFO] [stderr] | [INFO] [stderr] 218 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:223:20 [INFO] [stderr] | [INFO] [stderr] 223 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:229:24 [INFO] [stderr] | [INFO] [stderr] 229 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:291:20 [INFO] [stderr] | [INFO] [stderr] 291 | if curr_expr.len() > 0 { dq_tokens.push(DQToken::Str(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:295:20 [INFO] [stderr] | [INFO] [stderr] 295 | if curr_expr.len() > 0 { dq_tokens.push(DQToken::Str(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / loop { [INFO] [stderr] 20 | | let line = match context.read_line("$ ", &mut |_| {}) { [INFO] [stderr] 21 | | Ok(line) => line, [INFO] [stderr] 22 | | Err(_) => break, [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(line) = context.read_line("$ ", &mut |_| {}) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:368:38 [INFO] [stderr] | [INFO] [stderr] 368 | fn parse_bracketed_param(text: &str, mut curr_expr: String) -> (ParseRes, &str) { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run_builtin` [INFO] [stderr] --> src/execute.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn run_builtin(command: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `And` [INFO] [stderr] --> src/parser.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | And, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Or` [INFO] [stderr] --> src/parser.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Or, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Seq` [INFO] [stderr] --> src/parser.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Seq, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Expr` [INFO] [stderr] --> src/parser.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Expr(Box, Box, ParseOp), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Param` [INFO] [stderr] --> src/parser.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | Param(String), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Arith` [INFO] [stderr] --> src/parser.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | Arith(String) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/execute.rs:9:34 [INFO] [stderr] | [INFO] [stderr] 9 | fn vec_to_c_str_ptr(command: &Vec) -> (Vec, Vec<*const c_char>) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: Could not compile `nut-shell`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/execute.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | for ref word in command { [INFO] [stderr] | ^^^^^^^^ ------- help: try: `let word = &command;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/execute.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn builtin_cd(command: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/execute.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | if chdir(CString::new(dir.as_str()).unwrap().as_ptr()) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/execute.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | if chdir(CString::new(dir.as_str()).unwrap().as_ptr()) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/execute.rs:40:33 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn run_builtin(command: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/execute.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn run_file(command: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/execute.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn run_command(command: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:186:20 [INFO] [stderr] | [INFO] [stderr] 186 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:205:28 [INFO] [stderr] | [INFO] [stderr] 205 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:218:20 [INFO] [stderr] | [INFO] [stderr] 218 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:223:20 [INFO] [stderr] | [INFO] [stderr] 223 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:229:24 [INFO] [stderr] | [INFO] [stderr] 229 | if curr_expr.len() > 0 { tokens.push(Unquoted(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:291:20 [INFO] [stderr] | [INFO] [stderr] 291 | if curr_expr.len() > 0 { dq_tokens.push(DQToken::Str(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:295:20 [INFO] [stderr] | [INFO] [stderr] 295 | if curr_expr.len() > 0 { dq_tokens.push(DQToken::Str(curr_expr)); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!curr_expr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / loop { [INFO] [stderr] 20 | | let line = match context.read_line("$ ", &mut |_| {}) { [INFO] [stderr] 21 | | Ok(line) => line, [INFO] [stderr] 22 | | Err(_) => break, [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(line) = context.read_line("$ ", &mut |_| {}) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `nut-shell`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6e30ce3f1bccd797c35ec12434f79f7ac22908014442a100eace68d604e30dce"` [INFO] running `"docker" "rm" "-f" "6e30ce3f1bccd797c35ec12434f79f7ac22908014442a100eace68d604e30dce"` [INFO] [stdout] 6e30ce3f1bccd797c35ec12434f79f7ac22908014442a100eace68d604e30dce