[INFO] updating cached repository mookid/rust-adventofcode2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mookid/rust-adventofcode2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mookid/rust-adventofcode2017" "work/ex/clippy-test-run/sources/stable/gh/mookid/rust-adventofcode2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mookid/rust-adventofcode2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mookid/rust-adventofcode2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mookid/rust-adventofcode2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mookid/rust-adventofcode2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6b8300aacb3f428811d0d7aec97f699039a07fe3 [INFO] sha for GitHub repo mookid/rust-adventofcode2017: 6b8300aacb3f428811d0d7aec97f699039a07fe3 [INFO] validating manifest of mookid/rust-adventofcode2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mookid/rust-adventofcode2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mookid/rust-adventofcode2017 [INFO] finished frobbing mookid/rust-adventofcode2017 [INFO] frobbed toml for mookid/rust-adventofcode2017 written to work/ex/clippy-test-run/sources/stable/gh/mookid/rust-adventofcode2017/Cargo.toml [INFO] started frobbing mookid/rust-adventofcode2017 [INFO] finished frobbing mookid/rust-adventofcode2017 [INFO] frobbed toml for mookid/rust-adventofcode2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mookid/rust-adventofcode2017/Cargo.toml [INFO] crate mookid/rust-adventofcode2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mookid/rust-adventofcode2017 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mookid/rust-adventofcode2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c2aeef74cd47eb029c067d5df06a9fc004550b9ffecca0eaf50a4b31551fc7c [INFO] running `"docker" "start" "-a" "4c2aeef74cd47eb029c067d5df06a9fc004550b9ffecca0eaf50a4b31551fc7c"` [INFO] [stderr] Checking advent-of-code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/day12-digital-plumber.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | all[i] != -1 && continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/day12-digital-plumber.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | all[i] != -1 && continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if all[i] != -1 { continue; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::short_circuit_statement)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/day12-digital-plumber.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | all[i] != -1 && continue; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/day12-digital-plumber.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | all[node] != -1 && continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/day12-digital-plumber.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | all[node] != -1 && continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if all[node] != -1 { continue; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/day12-digital-plumber.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | all[node] != -1 && continue; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day12-digital-plumber.rs:48:41 [INFO] [stderr] | [INFO] [stderr] 48 | fn component_size(connected_components: &Vec, n: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day12-digital-plumber.rs:52:43 [INFO] [stderr] | [INFO] [stderr] 52 | fn count_components(connected_components: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 52 | fn count_components(connected_components: &[i32]) -> usize { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `connected_components.clone()` to [INFO] [stderr] | [INFO] [stderr] 53 | let mut cc = connected_components.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day1-inverse-captcha.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | sum += (current - ('0' as u8)) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(current - ('0' as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/day1-inverse-captcha.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | sum += (current - ('0' as u8)) as i32 [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/day12-digital-plumber.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | all[i] != -1 && continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/day12-digital-plumber.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | all[i] != -1 && continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if all[i] != -1 { continue; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::short_circuit_statement)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/day12-digital-plumber.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | all[i] != -1 && continue; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/day12-digital-plumber.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | all[node] != -1 && continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/day12-digital-plumber.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | all[node] != -1 && continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if all[node] != -1 { continue; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/day12-digital-plumber.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | all[node] != -1 && continue; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day12-digital-plumber.rs:48:41 [INFO] [stderr] | [INFO] [stderr] 48 | fn component_size(connected_components: &Vec, n: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day12-digital-plumber.rs:52:43 [INFO] [stderr] | [INFO] [stderr] 52 | fn count_components(connected_components: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 52 | fn count_components(connected_components: &[i32]) -> usize { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `connected_components.clone()` to [INFO] [stderr] | [INFO] [stderr] 53 | let mut cc = connected_components.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2-corruption-checksum.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | fn solve_line2(numbers: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `numbers` [INFO] [stderr] --> src/day2-corruption-checksum.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for j in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for (j, ) in numbers.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/day2-corruption-checksum.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | while let Some(x) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for x in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/day20-particles.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match c { [INFO] [stderr] 62 | | &b'-' => [INFO] [stderr] 63 | | neg = true, [INFO] [stderr] 64 | | &c@b'0'...b'9' => [INFO] [stderr] ... | [INFO] [stderr] 67 | | (), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | match *c { [INFO] [stderr] 62 | b'-' => [INFO] [stderr] 63 | neg = true, [INFO] [stderr] 64 | c@b'0'...b'9' => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/day20-particles.rs:65:38 [INFO] [stderr] | [INFO] [stderr] 65 | res = res * 10 + c as i64 - b'0' as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/day20-particles.rs:65:49 [INFO] [stderr] | [INFO] [stderr] 65 | res = res * 10 + c as i64 - b'0' as i64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/day3-spiral-memory.rs:20:55 [INFO] [stderr] | [INFO] [stderr] 20 | CornerKind::DL, CornerKind::DR].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/day3-spiral-memory.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / for i in 2.. { [INFO] [stderr] 65 | | let cur = manhattan_from_linear(i); [INFO] [stderr] 66 | | let (x,y) = cur; [INFO] [stderr] 67 | | let res = [(x-1, y-1), (x-1, y+0), (x-1, y+1), [INFO] [stderr] ... | [INFO] [stderr] 74 | | tbl.insert(cur, res); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day22-virus.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | println!("{}", nb_infections(map, 10000000, true)); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/day3-spiral-memory.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `y` [INFO] [stderr] --> src/day3-spiral-memory.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | let res = [(x-1, y-1), (x-1, y+0), (x-1, y+1), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/day3-spiral-memory.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | (x+0, y-1), (x+0, y+1), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/day3-spiral-memory.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | (x+0, y-1), (x+0, y+1), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `y` [INFO] [stderr] --> src/day3-spiral-memory.rs:69:38 [INFO] [stderr] | [INFO] [stderr] 69 | (x+1, y-1), (x+1, y+0), (x+1, y+1)] [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/day3-spiral-memory.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | n < res && return res; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/day3-spiral-memory.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | n < res && return res; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if n < res { return res; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::short_circuit_statement)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/day3-spiral-memory.rs:73:20 [INFO] [stderr] | [INFO] [stderr] 73 | n < res && return res; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/day7-recursive-circus.rs:78:30 [INFO] [stderr] | [INFO] [stderr] 78 | T {name: name2, nb: _, value: value2,}) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `T { name: name2, value: value2, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent-of-code`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/day14-disk-defragmentation.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | / if to_2d(y).is_some() { [INFO] [stderr] 70 | | if !visited[y] && grid[y] == b'1' { [INFO] [stderr] 71 | | todo.extend_from_slice(&neighbours(y)); [INFO] [stderr] 72 | | visited[y] = true; [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 69 | if to_2d(y).is_some() && !visited[y] && grid[y] == b'1' { [INFO] [stderr] 70 | todo.extend_from_slice(&neighbours(y)); [INFO] [stderr] 71 | visited[y] = true; [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day8-registers.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | const CMP_TABLE : [(&'static str, Cmp); 6] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day8-registers.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | const OP_TABLE : [(&'static str, Op); 2] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day7-recursive-circus.rs:19:58 [INFO] [stderr] | [INFO] [stderr] 19 | let mut iter = line.split(is_delimiter).filter(|str| 0 < str.len()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day7-recursive-circus.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | fn find_root<'a>(items : &'a Vec) -> Option<&'a str> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day7-recursive-circus.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | fn find_by_name<'a>(items : &'a Vec, x: &str) -> Option<&'a Item<'a>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day7-recursive-circus.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | items : &'a Vec, name: &'a str) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day7-recursive-circus.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | fn find_adjusted_weight(items : &Vec, root: &str) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/day22-virus.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | / match ch { [INFO] [stderr] 69 | | &b'.' => (), [INFO] [stderr] 70 | | &b'#' => v.push((i as i32, j as i32)), [INFO] [stderr] 71 | | &c => panic!("unexpected character: {}", c), [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 68 | match *ch { [INFO] [stderr] 69 | b'.' => (), [INFO] [stderr] 70 | b'#' => v.push((i as i32, j as i32)), [INFO] [stderr] 71 | c => panic!("unexpected character: {}", c), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/day9-stream-processing.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match self { [INFO] [stderr] 16 | | &Group::Nil => None, [INFO] [stderr] 17 | | &Group::Cons(ref item, ref grp) => Some((item, grp)), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *self { [INFO] [stderr] 16 | Group::Nil => None, [INFO] [stderr] 17 | Group::Cons(ref item, ref grp) => Some((item, grp)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day8-registers.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | fn largest_register_value(input: &Vec, safe: bool) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/day9-stream-processing.rs:50:35 [INFO] [stderr] | [INFO] [stderr] 50 | let mut iter = str.as_bytes().into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map` [INFO] [stderr] --> src/day9-stream-processing.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / ast.iter() [INFO] [stderr] 116 | | .filter_map(|item| match item { [INFO] [stderr] 117 | | &Item::Group(ref group) => Some(count_garbage(group)), [INFO] [stderr] 118 | | &Item::Garbage(count) => Some(count), [INFO] [stderr] 119 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/day9-stream-processing.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | .filter_map(|item| match item { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 117 | | &Item::Group(ref group) => Some(count_garbage(group)), [INFO] [stderr] 118 | | &Item::Garbage(count) => Some(count), [INFO] [stderr] 119 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | .filter_map(|item| match *item { [INFO] [stderr] 117 | Item::Group(ref group) => Some(count_garbage(group)), [INFO] [stderr] 118 | Item::Garbage(count) => Some(count), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/day9-stream-processing.rs:125:28 [INFO] [stderr] | [INFO] [stderr] 125 | .filter_map(|item| match item { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 126 | | &Item::Group(ref group) => Some(level + 1 + score_aux(&group, level + 1)), [INFO] [stderr] 127 | | &Item::Garbage(_) => None, [INFO] [stderr] 128 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 125 | .filter_map(|item| match *item { [INFO] [stderr] 126 | Item::Group(ref group) => Some(level + 1 + score_aux(&group, level + 1)), [INFO] [stderr] 127 | Item::Garbage(_) => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day21-fractal.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | for (i, row) in str.split("/").enumerate() { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day18-duet.rs:72:26 [INFO] [stderr] | [INFO] [stderr] 72 | parse_line_aux(line).ok_or(format!("parse_line: {}", line.clone()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("parse_line: {}", line.clone()).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/day18-duet.rs:72:58 [INFO] [stderr] | [INFO] [stderr] 72 | parse_line_aux(line).ok_or(format!("parse_line: {}", line.clone()).into()) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 72 | parse_line_aux(line).ok_or(format!("parse_line: {}", &(*line).clone()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 72 | parse_line_aux(line).ok_or(format!("parse_line: {}", &str::clone(line)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day18-duet.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | fn solve1(instrs: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Instr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day18-duet.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | fn solve2(instrs: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Instr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day18-duet.rs:168:69 [INFO] [stderr] | [INFO] [stderr] 168 | fn update(env: &mut Env2, process: Process, instr: i64, instrs: &Vec, break_: bool) -> (Option, bool) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Instr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent-of-code`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/day14-disk-defragmentation.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | .unwrap_or(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/day14-disk-defragmentation.rs:95:44 [INFO] [stderr] | [INFO] [stderr] 95 | let x = hex_to_bin(&lib::knot_hash("flqrgnkx-0".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"flqrgnkx-0"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "4c2aeef74cd47eb029c067d5df06a9fc004550b9ffecca0eaf50a4b31551fc7c"` [INFO] running `"docker" "rm" "-f" "4c2aeef74cd47eb029c067d5df06a9fc004550b9ffecca0eaf50a4b31551fc7c"` [INFO] [stdout] 4c2aeef74cd47eb029c067d5df06a9fc004550b9ffecca0eaf50a4b31551fc7c