[INFO] updating cached repository mollyporph/rustiptool [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mollyporph/rustiptool [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mollyporph/rustiptool" "work/ex/clippy-test-run/sources/stable/gh/mollyporph/rustiptool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mollyporph/rustiptool'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mollyporph/rustiptool" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mollyporph/rustiptool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mollyporph/rustiptool'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b9ecf01ce0729a75ecbe5890064e6e8f425729e1 [INFO] sha for GitHub repo mollyporph/rustiptool: b9ecf01ce0729a75ecbe5890064e6e8f425729e1 [INFO] validating manifest of mollyporph/rustiptool on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mollyporph/rustiptool on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mollyporph/rustiptool [INFO] finished frobbing mollyporph/rustiptool [INFO] frobbed toml for mollyporph/rustiptool written to work/ex/clippy-test-run/sources/stable/gh/mollyporph/rustiptool/Cargo.toml [INFO] started frobbing mollyporph/rustiptool [INFO] finished frobbing mollyporph/rustiptool [INFO] frobbed toml for mollyporph/rustiptool written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mollyporph/rustiptool/Cargo.toml [INFO] crate mollyporph/rustiptool has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mollyporph/rustiptool against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mollyporph/rustiptool:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 835a347c0b73d78a71edc3c6c4dd5aa70381a0711e94a556adc84e824db7f7bf [INFO] running `"docker" "start" "-a" "835a347c0b73d78a71edc3c6c4dd5aa70381a0711e94a556adc84e824db7f7bf"` [INFO] [stderr] Checking iptools v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:84 [INFO] [stderr] | [INFO] [stderr] 18 | fn swap_endian(num: u32) -> u32{((num & 0xff) << 24 | (num & 0xff00) << 8 | (num & 0xff0000) >> 8 | (num & 0xff000000) >> 24)} [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:109 [INFO] [stderr] | [INFO] [stderr] 18 | fn swap_endian(num: u32) -> u32{((num & 0xff) << 24 | (num & 0xff00) << 8 | (num & 0xff0000) >> 8 | (num & 0xff000000) >> 24)} [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:22:51 [INFO] [stderr] | [INFO] [stderr] 22 | .map(|(i, s)| s.parse::().unwrap() << i * 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `s.parse::().unwrap() << (i * 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:84 [INFO] [stderr] | [INFO] [stderr] 18 | fn swap_endian(num: u32) -> u32{((num & 0xff) << 24 | (num & 0xff00) << 8 | (num & 0xff0000) >> 8 | (num & 0xff000000) >> 24)} [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:109 [INFO] [stderr] | [INFO] [stderr] 18 | fn swap_endian(num: u32) -> u32{((num & 0xff) << 24 | (num & 0xff00) << 8 | (num & 0xff0000) >> 8 | (num & 0xff000000) >> 24)} [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:22:51 [INFO] [stderr] | [INFO] [stderr] 22 | .map(|(i, s)| s.parse::().unwrap() << i * 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `s.parse::().unwrap() << (i * 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `"docker" "inspect" "835a347c0b73d78a71edc3c6c4dd5aa70381a0711e94a556adc84e824db7f7bf"` [INFO] running `"docker" "rm" "-f" "835a347c0b73d78a71edc3c6c4dd5aa70381a0711e94a556adc84e824db7f7bf"` [INFO] [stdout] 835a347c0b73d78a71edc3c6c4dd5aa70381a0711e94a556adc84e824db7f7bf