[INFO] updating cached repository mohrcore/wladcy_polski [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mohrcore/wladcy_polski [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mohrcore/wladcy_polski" "work/ex/clippy-test-run/sources/stable/gh/mohrcore/wladcy_polski"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mohrcore/wladcy_polski'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mohrcore/wladcy_polski" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mohrcore/wladcy_polski"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mohrcore/wladcy_polski'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3dfc584c50b950a80bb9652478fd382c7e19cabd [INFO] sha for GitHub repo mohrcore/wladcy_polski: 3dfc584c50b950a80bb9652478fd382c7e19cabd [INFO] validating manifest of mohrcore/wladcy_polski on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mohrcore/wladcy_polski on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mohrcore/wladcy_polski [INFO] finished frobbing mohrcore/wladcy_polski [INFO] frobbed toml for mohrcore/wladcy_polski written to work/ex/clippy-test-run/sources/stable/gh/mohrcore/wladcy_polski/Cargo.toml [INFO] started frobbing mohrcore/wladcy_polski [INFO] finished frobbing mohrcore/wladcy_polski [INFO] frobbed toml for mohrcore/wladcy_polski written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mohrcore/wladcy_polski/Cargo.toml [INFO] crate mohrcore/wladcy_polski has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mohrcore/wladcy_polski against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mohrcore/wladcy_polski:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51d0233698c2ef00f3eeb8bcd703663c5904e486272c3c5f1aa5c240c60b47bf [INFO] running `"docker" "start" "-a" "51d0233698c2ef00f3eeb8bcd703663c5904e486272c3c5f1aa5c240c60b47bf"` [INFO] [stderr] Checking wladcy_polski v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:75:11 [INFO] [stderr] | [INFO] [stderr] 75 | if(line == wladcy[id + 1]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return Ok((i1, i2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i1, i2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:75:11 [INFO] [stderr] | [INFO] [stderr] 75 | if(line == wladcy[id + 1]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return Ok((i1, i2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((i1, i2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:88:45 [INFO] [stderr] | [INFO] [stderr] 88 | fn get_range(stdin: &mut std::io::Stdin, v: &Vec<&str>) -> Result<(usize, usize), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:88:45 [INFO] [stderr] | [INFO] [stderr] 88 | fn get_range(stdin: &mut std::io::Stdin, v: &Vec<&str>) -> Result<(usize, usize), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `"docker" "inspect" "51d0233698c2ef00f3eeb8bcd703663c5904e486272c3c5f1aa5c240c60b47bf"` [INFO] running `"docker" "rm" "-f" "51d0233698c2ef00f3eeb8bcd703663c5904e486272c3c5f1aa5c240c60b47bf"` [INFO] [stdout] 51d0233698c2ef00f3eeb8bcd703663c5904e486272c3c5f1aa5c240c60b47bf