[INFO] updating cached repository mmstick/permutate [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mmstick/permutate [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mmstick/permutate" "work/ex/clippy-test-run/sources/stable/gh/mmstick/permutate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mmstick/permutate'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mmstick/permutate" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmstick/permutate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmstick/permutate'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c1f3bb3e60a22f14102a05198266325563d4501d [INFO] sha for GitHub repo mmstick/permutate: c1f3bb3e60a22f14102a05198266325563d4501d [INFO] validating manifest of mmstick/permutate on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mmstick/permutate on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mmstick/permutate [INFO] finished frobbing mmstick/permutate [INFO] frobbed toml for mmstick/permutate written to work/ex/clippy-test-run/sources/stable/gh/mmstick/permutate/Cargo.toml [INFO] started frobbing mmstick/permutate [INFO] finished frobbing mmstick/permutate [INFO] frobbed toml for mmstick/permutate written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmstick/permutate/Cargo.toml [INFO] crate mmstick/permutate has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mmstick/permutate against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmstick/permutate:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d668af7e8b85175afc75d02bb149cc39dd20e6b9e7bba7b4b7fe763ce86c76ae [INFO] running `"docker" "start" "-a" "d668af7e8b85175afc75d02bb149cc39dd20e6b9e7bba7b4b7fe763ce86c76ae"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/bin/arguments.rs [INFO] [stderr] * /opt/crater/workdir/src/bin/man.rs [INFO] [stderr] * /opt/crater/workdir/src/bin/buffer.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking permutate v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | lists: lists, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lists` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | nlists: nlists, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `nlists` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | single_list: single_list [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `single_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | max_iters: max_iters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | lists: lists, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lists` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | nlists: nlists, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `nlists` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | single_list: single_list [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `single_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | max_iters: max_iters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | lists: lists, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lists` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | nlists: nlists, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `nlists` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | single_list: single_list [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `single_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | max_iters: max_iters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | lists: lists, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lists` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | nlists: nlists, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `nlists` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | single_list: single_list [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `single_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | max_iters: max_iters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_iters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 215 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 216 | | return false [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 214 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 215 | return false [INFO] [stderr] 216 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 252 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 253 | | return None [INFO] [stderr] 254 | | } [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 251 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 252 | return None [INFO] [stderr] 253 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 287 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 288 | | return None [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 286 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 287 | return None [INFO] [stderr] 288 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 405 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 406 | | return false [INFO] [stderr] 407 | | } [INFO] [stderr] 408 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 404 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 405 | return false [INFO] [stderr] 406 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 442 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 443 | | return None [INFO] [stderr] 444 | | } [INFO] [stderr] 445 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 441 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 442 | return None [INFO] [stderr] 443 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:476:9 [INFO] [stderr] | [INFO] [stderr] 476 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 477 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 478 | | return None [INFO] [stderr] 479 | | } [INFO] [stderr] 480 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 476 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 477 | return None [INFO] [stderr] 478 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 215 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 216 | | return false [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 214 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 215 | return false [INFO] [stderr] 216 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 252 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 253 | | return None [INFO] [stderr] 254 | | } [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 251 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 252 | return None [INFO] [stderr] 253 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 287 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 288 | | return None [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 286 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 287 | return None [INFO] [stderr] 288 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 405 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 406 | | return false [INFO] [stderr] 407 | | } [INFO] [stderr] 408 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 404 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 405 | return false [INFO] [stderr] 406 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 442 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 443 | | return None [INFO] [stderr] 444 | | } [INFO] [stderr] 445 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 441 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 442 | return None [INFO] [stderr] 443 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:476:9 [INFO] [stderr] | [INFO] [stderr] 476 | / if self.indexes.max_iters != 0 { [INFO] [stderr] 477 | | if self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 478 | | return None [INFO] [stderr] 479 | | } [INFO] [stderr] 480 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 476 | if self.indexes.max_iters != 0 && self.indexes.curr_iter == self.indexes.max_iters { [INFO] [stderr] 477 | return None [INFO] [stderr] 478 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/arguments.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | return Err(InputError::NotEnoughInputs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(InputError::NotEnoughInputs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/arguments.rs:56:32 [INFO] [stderr] | [INFO] [stderr] 56 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 57 | | if current_list.is_empty() { [INFO] [stderr] 58 | | return Err(InputError::NoInputsProvided); [INFO] [stderr] 59 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 56 | } else if current_list.is_empty() { [INFO] [stderr] 57 | return Err(InputError::NoInputsProvided); [INFO] [stderr] 58 | } else { [INFO] [stderr] 59 | list_collection.push(current_list.clone()); [INFO] [stderr] 60 | current_list.clear(); [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/arguments.rs:68:32 [INFO] [stderr] | [INFO] [stderr] 68 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 69 | | if current_list.is_empty() { [INFO] [stderr] 70 | | return Err(InputError::NoInputsProvided); [INFO] [stderr] 71 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | } else if current_list.is_empty() { [INFO] [stderr] 69 | return Err(InputError::NoInputsProvided); [INFO] [stderr] 70 | } else { [INFO] [stderr] 71 | list_collection.push(current_list.clone()); [INFO] [stderr] 72 | current_list.clear(); [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/man.rs:1:21 [INFO] [stderr] | [INFO] [stderr] 1 | pub const MANPAGE: &'static str = r#"NAME [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/permutate.rs:42:20 [INFO] [stderr] | [INFO] [stderr] 42 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 43 | | if no_delimiters { [INFO] [stderr] 44 | | permutate_without_delims(&mut stdout, &mut permutator); [INFO] [stderr] 45 | | } else { [INFO] [stderr] 46 | | permutate(&mut stdout, &mut permutator); [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | } else if no_delimiters { [INFO] [stderr] 43 | permutate_without_delims(&mut stdout, &mut permutator); [INFO] [stderr] 44 | } else { [INFO] [stderr] 45 | permutate(&mut stdout, &mut permutator); [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/arguments.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | return Err(InputError::NotEnoughInputs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(InputError::NotEnoughInputs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/arguments.rs:56:32 [INFO] [stderr] | [INFO] [stderr] 56 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 57 | | if current_list.is_empty() { [INFO] [stderr] 58 | | return Err(InputError::NoInputsProvided); [INFO] [stderr] 59 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 56 | } else if current_list.is_empty() { [INFO] [stderr] 57 | return Err(InputError::NoInputsProvided); [INFO] [stderr] 58 | } else { [INFO] [stderr] 59 | list_collection.push(current_list.clone()); [INFO] [stderr] 60 | current_list.clear(); [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/arguments.rs:68:32 [INFO] [stderr] | [INFO] [stderr] 68 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 69 | | if current_list.is_empty() { [INFO] [stderr] 70 | | return Err(InputError::NoInputsProvided); [INFO] [stderr] 71 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | } else if current_list.is_empty() { [INFO] [stderr] 69 | return Err(InputError::NoInputsProvided); [INFO] [stderr] 70 | } else { [INFO] [stderr] 71 | list_collection.push(current_list.clone()); [INFO] [stderr] 72 | current_list.clear(); [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/man.rs:1:21 [INFO] [stderr] | [INFO] [stderr] 1 | pub const MANPAGE: &'static str = r#"NAME [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/permutate.rs:42:20 [INFO] [stderr] | [INFO] [stderr] 42 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 43 | | if no_delimiters { [INFO] [stderr] 44 | | permutate_without_delims(&mut stdout, &mut permutator); [INFO] [stderr] 45 | | } else { [INFO] [stderr] 46 | | permutate(&mut stdout, &mut permutator); [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | } else if no_delimiters { [INFO] [stderr] 43 | permutate_without_delims(&mut stdout, &mut permutator); [INFO] [stderr] 44 | } else { [INFO] [stderr] 45 | permutate(&mut stdout, &mut permutator); [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/arguments.rs:154:8 [INFO] [stderr] | [INFO] [stderr] 154 | if list_collection.len() == 0 || (list_collection.len() == 1 && list_collection[0].len() == 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list_collection.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/arguments.rs:154:8 [INFO] [stderr] | [INFO] [stderr] 154 | if list_collection.len() == 0 || (list_collection.len() == 1 && list_collection[0].len() == 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list_collection.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.82s [INFO] running `"docker" "inspect" "d668af7e8b85175afc75d02bb149cc39dd20e6b9e7bba7b4b7fe763ce86c76ae"` [INFO] running `"docker" "rm" "-f" "d668af7e8b85175afc75d02bb149cc39dd20e6b9e7bba7b4b7fe763ce86c76ae"` [INFO] [stdout] d668af7e8b85175afc75d02bb149cc39dd20e6b9e7bba7b4b7fe763ce86c76ae