[INFO] updating cached repository mkpankov/window-read-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mkpankov/window-read-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mkpankov/window-read-test" "work/ex/clippy-test-run/sources/stable/gh/mkpankov/window-read-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mkpankov/window-read-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mkpankov/window-read-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkpankov/window-read-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkpankov/window-read-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0bc250e66f2eba77d2f35ee1e0dd8acf18cff2d1 [INFO] sha for GitHub repo mkpankov/window-read-test: 0bc250e66f2eba77d2f35ee1e0dd8acf18cff2d1 [INFO] validating manifest of mkpankov/window-read-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mkpankov/window-read-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mkpankov/window-read-test [INFO] finished frobbing mkpankov/window-read-test [INFO] frobbed toml for mkpankov/window-read-test written to work/ex/clippy-test-run/sources/stable/gh/mkpankov/window-read-test/Cargo.toml [INFO] started frobbing mkpankov/window-read-test [INFO] finished frobbing mkpankov/window-read-test [INFO] frobbed toml for mkpankov/window-read-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkpankov/window-read-test/Cargo.toml [INFO] crate mkpankov/window-read-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mkpankov/window-read-test against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkpankov/window-read-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4e84f35937740e7450d0451904aff42257c2efc674631d52192f9af1ebfbcaa [INFO] running `"docker" "start" "-a" "e4e84f35937740e7450d0451904aff42257c2efc674631d52192f9af1ebfbcaa"` [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking crossbeam-epoch v0.4.1 [INFO] [stderr] Checking bytes v0.4.7 [INFO] [stderr] Checking tokio-timer v0.2.3 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking tokio-io-timeout v0.3.1 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking tokio-process v0.1.6 [INFO] [stderr] Checking window-read-test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:71:39 [INFO] [stderr] | [INFO] [stderr] 71 | window.extend(buf[0..x].into_iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `buf[0..x].into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:71:49 [INFO] [stderr] | [INFO] [stderr] 71 | window.extend(buf[0..x].into_iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | if let Some(_) = window.iter().find(|c| **c == *mark.lock().unwrap()) { [INFO] [stderr] | _________________________- ^^^^^^^ [INFO] [stderr] 74 | | Ok(Async::Ready(Some(1))) [INFO] [stderr] 75 | | } else { [INFO] [stderr] 76 | | Ok(Async::NotReady) [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________________________- help: try this: `if window.iter().find(|c| **c == *mark.lock().unwrap()).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:71:39 [INFO] [stderr] | [INFO] [stderr] 71 | window.extend(buf[0..x].into_iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `buf[0..x].into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:71:49 [INFO] [stderr] | [INFO] [stderr] 71 | window.extend(buf[0..x].into_iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | if let Some(_) = window.iter().find(|c| **c == *mark.lock().unwrap()) { [INFO] [stderr] | _________________________- ^^^^^^^ [INFO] [stderr] 74 | | Ok(Async::Ready(Some(1))) [INFO] [stderr] 75 | | } else { [INFO] [stderr] 76 | | Ok(Async::NotReady) [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________________________- help: try this: `if window.iter().find(|c| **c == *mark.lock().unwrap()).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.19s [INFO] running `"docker" "inspect" "e4e84f35937740e7450d0451904aff42257c2efc674631d52192f9af1ebfbcaa"` [INFO] running `"docker" "rm" "-f" "e4e84f35937740e7450d0451904aff42257c2efc674631d52192f9af1ebfbcaa"` [INFO] [stdout] e4e84f35937740e7450d0451904aff42257c2efc674631d52192f9af1ebfbcaa