[INFO] updating cached repository mkilgore/rshell
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mkilgore/rshell
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mkilgore/rshell" "work/ex/clippy-test-run/sources/stable/gh/mkilgore/rshell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mkilgore/rshell'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mkilgore/rshell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkilgore/rshell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkilgore/rshell'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 4553cf1c2ecfc193a1fcbdf1044f5e9a6e54d131
[INFO] sha for GitHub repo mkilgore/rshell: 4553cf1c2ecfc193a1fcbdf1044f5e9a6e54d131
[INFO] validating manifest of mkilgore/rshell on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mkilgore/rshell on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mkilgore/rshell
[INFO] finished frobbing mkilgore/rshell
[INFO] frobbed toml for mkilgore/rshell written to work/ex/clippy-test-run/sources/stable/gh/mkilgore/rshell/Cargo.toml
[INFO] started frobbing mkilgore/rshell
[INFO] finished frobbing mkilgore/rshell
[INFO] frobbed toml for mkilgore/rshell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkilgore/rshell/Cargo.toml
[INFO] crate mkilgore/rshell has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mkilgore/rshell against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkilgore/rshell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7032e676ed9616dafd971c5cc6476076f66647d26503225ce41f377c9bdd63b2
[INFO] running `"docker" "start" "-a" "7032e676ed9616dafd971c5cc6476076f66647d26503225ce41f377c9bdd63b2"`
[INFO] [stderr]     Checking rshell v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return single;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `single`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/job.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/job.rs:111:93
[INFO] [stderr]     |
[INFO] [stderr] 111 |                                                             libc::O_WRONLY | libc::O_CREAT, 0777) };
[INFO] [stderr]     |                                                                                             ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::zero_prefixed_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 111 |                                                             libc::O_WRONLY | libc::O_CREAT, 777) };
[INFO] [stderr]     |                                                                                             ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 111 |                                                             libc::O_WRONLY | libc::O_CREAT, 0o777) };
[INFO] [stderr]     |                                                                                             ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/job.rs:114:110
[INFO] [stderr]     |
[INFO] [stderr] 114 |                                                             libc::O_WRONLY | libc::O_CREAT | libc::O_APPEND, 0777) };
[INFO] [stderr]     |                                                                                                              ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 114 |                                                             libc::O_WRONLY | libc::O_CREAT | libc::O_APPEND, 777) };
[INFO] [stderr]     |                                                                                                              ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 114 |                                                             libc::O_WRONLY | libc::O_CREAT | libc::O_APPEND, 0o777) };
[INFO] [stderr]     |                                                                                                              ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/job.rs:175:9
[INFO] [stderr]     |
[INFO] [stderr] 175 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/builtin.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return ret;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `ret`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/job_list.rs:38:44
[INFO] [stderr]    |
[INFO] [stderr] 38 |         self.list.push(Arc::new(Mutex::new((job))));
[INFO] [stderr]    |                                            ^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/job_list.rs:38:44
[INFO] [stderr]    |
[INFO] [stderr] 38 |         self.list.push(Arc::new(Mutex::new((job))));
[INFO] [stderr]    |                                            ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/job_list.rs:128:40
[INFO] [stderr]     |
[INFO] [stderr] 128 |                                   } else {
[INFO] [stderr]     |  ________________________________________^
[INFO] [stderr] 129 | |                                     if w_exited {
[INFO] [stderr] 130 | |                                         println!("[{}] Finished: {}", index + 1, libc::WEXITSTATUS(wstatus));
[INFO] [stderr] 131 | |                                     } else {
[INFO] [stderr] 132 | |                                         println!("[{}] Killed by signal {}", index + 1, libc::WTERMSIG(wstatus));
[INFO] [stderr] 133 | |                                     }
[INFO] [stderr] 134 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 128 |                                 } else if w_exited {
[INFO] [stderr] 129 |     println!("[{}] Finished: {}", index + 1, libc::WEXITSTATUS(wstatus));
[INFO] [stderr] 130 | } else {
[INFO] [stderr] 131 |     println!("[{}] Killed by signal {}", index + 1, libc::WTERMSIG(wstatus));
[INFO] [stderr] 132 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return single;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `single`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/job.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/job.rs:111:93
[INFO] [stderr]     |
[INFO] [stderr] 111 |                                                             libc::O_WRONLY | libc::O_CREAT, 0777) };
[INFO] [stderr]     |                                                                                             ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::zero_prefixed_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 111 |                                                             libc::O_WRONLY | libc::O_CREAT, 777) };
[INFO] [stderr]     |                                                                                             ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 111 |                                                             libc::O_WRONLY | libc::O_CREAT, 0o777) };
[INFO] [stderr]     |                                                                                             ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/job.rs:114:110
[INFO] [stderr]     |
[INFO] [stderr] 114 |                                                             libc::O_WRONLY | libc::O_CREAT | libc::O_APPEND, 0777) };
[INFO] [stderr]     |                                                                                                              ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 114 |                                                             libc::O_WRONLY | libc::O_CREAT | libc::O_APPEND, 777) };
[INFO] [stderr]     |                                                                                                              ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 114 |                                                             libc::O_WRONLY | libc::O_CREAT | libc::O_APPEND, 0o777) };
[INFO] [stderr]     |                                                                                                              ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/job.rs:175:9
[INFO] [stderr]     |
[INFO] [stderr] 175 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/builtin.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return ret;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `ret`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/job_list.rs:38:44
[INFO] [stderr]    |
[INFO] [stderr] 38 |         self.list.push(Arc::new(Mutex::new((job))));
[INFO] [stderr]    |                                            ^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/job_list.rs:38:44
[INFO] [stderr]    |
[INFO] [stderr] 38 |         self.list.push(Arc::new(Mutex::new((job))));
[INFO] [stderr]    |                                            ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/job_list.rs:128:40
[INFO] [stderr]     |
[INFO] [stderr] 128 |                                   } else {
[INFO] [stderr]     |  ________________________________________^
[INFO] [stderr] 129 | |                                     if w_exited {
[INFO] [stderr] 130 | |                                         println!("[{}] Finished: {}", index + 1, libc::WEXITSTATUS(wstatus));
[INFO] [stderr] 131 | |                                     } else {
[INFO] [stderr] 132 | |                                         println!("[{}] Killed by signal {}", index + 1, libc::WTERMSIG(wstatus));
[INFO] [stderr] 133 | |                                     }
[INFO] [stderr] 134 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 128 |                                 } else if w_exited {
[INFO] [stderr] 129 |     println!("[{}] Finished: {}", index + 1, libc::WEXITSTATUS(wstatus));
[INFO] [stderr] 130 | } else {
[INFO] [stderr] 131 |     println!("[{}] Killed by signal {}", index + 1, libc::WTERMSIG(wstatus));
[INFO] [stderr] 132 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/job.rs:80:22
[INFO] [stderr]    |
[INFO] [stderr] 80 |     pub fn parse_job(mut lex: &mut InputLexer) -> Option<Job> {
[INFO] [stderr]    |                      ----^^^
[INFO] [stderr]    |                      |
[INFO] [stderr]    |                      help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/job.rs:80:22
[INFO] [stderr]    |
[INFO] [stderr] 80 |     pub fn parse_job(mut lex: &mut InputLexer) -> Option<Job> {
[INFO] [stderr]    |                      ----^^^
[INFO] [stderr]    |                      |
[INFO] [stderr]    |                      help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `job::Job`
[INFO] [stderr]   --> src/job.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 | /     pub fn new() -> Job {
[INFO] [stderr] 25 | |         Job {
[INFO] [stderr] 26 | |             pgrp: -1,
[INFO] [stderr] 27 | |             name: "".to_string(),
[INFO] [stderr] ...  |
[INFO] [stderr] 31 | |         }
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 | impl Default for job::Job {
[INFO] [stderr] 24 |     fn default() -> Self {
[INFO] [stderr] 25 |         Self::new()
[INFO] [stderr] 26 |     }
[INFO] [stderr] 27 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: you are getting the inner pointer of a temporary `CString`
[INFO] [stderr]    --> src/job.rs:110:71
[INFO] [stderr]     |
[INFO] [stderr] 110 |                                 cur_prog.stdout = unsafe { libc::open(CString::new(s).unwrap().as_ptr(),
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default
[INFO] [stderr]     = note: that pointer will be invalid outside this expression
[INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime
[INFO] [stderr]    --> src/job.rs:110:71
[INFO] [stderr]     |
[INFO] [stderr] 110 |                                 cur_prog.stdout = unsafe { libc::open(CString::new(s).unwrap().as_ptr(),
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr
[INFO] [stderr] 
[INFO] [stderr] error: you are getting the inner pointer of a temporary `CString`
[INFO] [stderr]    --> src/job.rs:113:71
[INFO] [stderr]     |
[INFO] [stderr] 113 |                                 cur_prog.stdout = unsafe { libc::open(CString::new(s).unwrap().as_ptr(),
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: that pointer will be invalid outside this expression
[INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime
[INFO] [stderr]    --> src/job.rs:113:71
[INFO] [stderr]     |
[INFO] [stderr] 113 |                                 cur_prog.stdout = unsafe { libc::open(CString::new(s).unwrap().as_ptr(),
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr
[INFO] [stderr] 
[INFO] [stderr] error: you are getting the inner pointer of a temporary `CString`
[INFO] [stderr]    --> src/job.rs:116:70
[INFO] [stderr]     |
[INFO] [stderr] 116 |                                 cur_prog.stdin = unsafe { libc::open(CString::new(s).unwrap().as_ptr(), libc::O_RDONLY) };
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: that pointer will be invalid outside this expression
[INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime
[INFO] [stderr]    --> src/job.rs:116:70
[INFO] [stderr]     |
[INFO] [stderr] 116 |                                 cur_prog.stdin = unsafe { libc::open(CString::new(s).unwrap().as_ptr(), libc::O_RDONLY) };
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/job.rs:166:30
[INFO] [stderr]     |
[INFO] [stderr] 166 |     pub fn is_simple_bulitin(&mut self) -> bool {
[INFO] [stderr]     |                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `job::Job`
[INFO] [stderr]   --> src/job.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 | /     pub fn new() -> Job {
[INFO] [stderr] 25 | |         Job {
[INFO] [stderr] 26 | |             pgrp: -1,
[INFO] [stderr] 27 | |             name: "".to_string(),
[INFO] [stderr] ...  |
[INFO] [stderr] 31 | |         }
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 | impl Default for job::Job {
[INFO] [stderr] 24 |     fn default() -> Self {
[INFO] [stderr] 25 |         Self::new()
[INFO] [stderr] 26 |     }
[INFO] [stderr] 27 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &job_list.list.enumerate()` or similar iterators
[INFO] [stderr]   --> src/builtin.rs:61:16
[INFO] [stderr]    |
[INFO] [stderr] 61 |     for job in &job_list.list {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/builtin.rs:82:5
[INFO] [stderr]    |
[INFO] [stderr] 82 | /     let job_id;
[INFO] [stderr] 83 | |
[INFO] [stderr] 84 | |     if prog.args.len() < 1 {
[INFO] [stderr] 85 | |         job_id = 1;
[INFO] [stderr] 86 | |     } else {
[INFO] [stderr] 87 | |         job_id = prog.args[0].parse::<usize>().unwrap();
[INFO] [stderr] 88 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let job_id = if prog.args.len() < 1 { 1 } else { prog.args[0].parse::<usize>().unwrap() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/builtin.rs:84:8
[INFO] [stderr]    |
[INFO] [stderr] 84 |     if prog.args.len() < 1 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prog.args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/builtin.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 | /     let job_id;
[INFO] [stderr] 107 | |
[INFO] [stderr] 108 | |     if prog.args.len() < 1 {
[INFO] [stderr] 109 | |         job_id = 1;
[INFO] [stderr] 110 | |     } else {
[INFO] [stderr] 111 | |         job_id = prog.args[0].parse::<usize>().unwrap();
[INFO] [stderr] 112 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let job_id = if prog.args.len() < 1 { 1 } else { prog.args[0].parse::<usize>().unwrap() };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/builtin.rs:108:8
[INFO] [stderr]     |
[INFO] [stderr] 108 |     if prog.args.len() < 1 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prog.args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: you are getting the inner pointer of a temporary `CString`
[INFO] [stderr]    --> src/job.rs:110:71
[INFO] [stderr]     |
[INFO] [stderr] 110 |                                 cur_prog.stdout = unsafe { libc::open(CString::new(s).unwrap().as_ptr(),
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default
[INFO] [stderr]     = note: that pointer will be invalid outside this expression
[INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime
[INFO] [stderr]    --> src/job.rs:110:71
[INFO] [stderr]     |
[INFO] [stderr] 110 |                                 cur_prog.stdout = unsafe { libc::open(CString::new(s).unwrap().as_ptr(),
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr
[INFO] [stderr] 
[INFO] [stderr] error: you are getting the inner pointer of a temporary `CString`
[INFO] [stderr]    --> src/job.rs:113:71
[INFO] [stderr]     |
[INFO] [stderr] 113 |                                 cur_prog.stdout = unsafe { libc::open(CString::new(s).unwrap().as_ptr(),
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: that pointer will be invalid outside this expression
[INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime
[INFO] [stderr]    --> src/job.rs:113:71
[INFO] [stderr]     |
[INFO] [stderr] 113 |                                 cur_prog.stdout = unsafe { libc::open(CString::new(s).unwrap().as_ptr(),
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr
[INFO] [stderr] 
[INFO] [stderr] error: you are getting the inner pointer of a temporary `CString`
[INFO] [stderr]    --> src/job.rs:116:70
[INFO] [stderr]     |
[INFO] [stderr] 116 |                                 cur_prog.stdin = unsafe { libc::open(CString::new(s).unwrap().as_ptr(), libc::O_RDONLY) };
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: that pointer will be invalid outside this expression
[INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime
[INFO] [stderr]    --> src/job.rs:116:70
[INFO] [stderr]     |
[INFO] [stderr] 116 |                                 cur_prog.stdin = unsafe { libc::open(CString::new(s).unwrap().as_ptr(), libc::O_RDONLY) };
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/builtin.rs:132:8
[INFO] [stderr]     |
[INFO] [stderr] 132 |     if prog.args.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prog.args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/builtin.rs:136:50
[INFO] [stderr]     |
[INFO] [stderr] 136 |     let vec_dirs: Vec<&str> = prog.args[0].split("/").collect();
[INFO] [stderr]     |                                                  ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/job.rs:166:30
[INFO] [stderr]     |
[INFO] [stderr] 166 |     pub fn is_simple_bulitin(&mut self) -> bool {
[INFO] [stderr]     |                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/builtin.rs:147:12
[INFO] [stderr]     |
[INFO] [stderr] 147 |         if dir.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dir.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/builtin.rs:160:16
[INFO] [stderr]     |
[INFO] [stderr] 160 |             if new_cwd.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `new_cwd.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/builtin.rs:188:8
[INFO] [stderr]     |
[INFO] [stderr] 188 |     if prog.args.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prog.args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `prog::Prog`
[INFO] [stderr]   --> src/prog.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new() -> Prog {
[INFO] [stderr] 28 | |         Prog {
[INFO] [stderr] 29 | |             file: "".to_string(),
[INFO] [stderr] 30 | |             args: Vec::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |         }
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &job_list.list.enumerate()` or similar iterators
[INFO] [stderr]   --> src/builtin.rs:61:16
[INFO] [stderr]    |
[INFO] [stderr] 61 |     for job in &job_list.list {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/prog.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 | /         match self.builtin {
[INFO] [stderr] 62 | |             Some(builtin) => {
[INFO] [stderr] 63 | |                 let ret = (builtin.callback) (self);
[INFO] [stderr] 64 | |                 process::exit(ret as i32);
[INFO] [stderr] 65 | |             },
[INFO] [stderr] 66 | |             _ => { }
[INFO] [stderr] 67 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 61 |         if let Some(builtin) = self.builtin {
[INFO] [stderr] 62 |     let ret = (builtin.callback) (self);
[INFO] [stderr] 63 |     process::exit(ret as i32);
[INFO] [stderr] 64 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()`
[INFO] [stderr]   --> src/prog.rs:83:25
[INFO] [stderr]    |
[INFO] [stderr] 83 |         c_char_vec.push(0 as *const libc::c_char);
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::zero_ptr)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr
[INFO] [stderr] 
[INFO] [stderr] error: you are getting the inner pointer of a temporary `CString`
[INFO] [stderr]   --> src/prog.rs:89:22
[INFO] [stderr]    |
[INFO] [stderr] 89 |         libc::execvp(CString::new(self.file.clone()).unwrap().as_ptr() as *const libc::c_char, c_char_vec.as_ptr() as *const *const libc::c_char);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: that pointer will be invalid outside this expression
[INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime
[INFO] [stderr]   --> src/prog.rs:89:22
[INFO] [stderr]    |
[INFO] [stderr] 89 |         libc::execvp(CString::new(self.file.clone()).unwrap().as_ptr() as *const libc::c_char, c_char_vec.as_ptr() as *const *const libc::c_char);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/builtin.rs:82:5
[INFO] [stderr]    |
[INFO] [stderr] 82 | /     let job_id;
[INFO] [stderr] 83 | |
[INFO] [stderr] 84 | |     if prog.args.len() < 1 {
[INFO] [stderr] 85 | |         job_id = 1;
[INFO] [stderr] 86 | |     } else {
[INFO] [stderr] 87 | |         job_id = prog.args[0].parse::<usize>().unwrap();
[INFO] [stderr] 88 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let job_id = if prog.args.len() < 1 { 1 } else { prog.args[0].parse::<usize>().unwrap() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/builtin.rs:84:8
[INFO] [stderr]    |
[INFO] [stderr] 84 |     if prog.args.len() < 1 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prog.args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/prog.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 | /         match self.builtin {
[INFO] [stderr] 120 | |             Some(builtin) => {
[INFO] [stderr] 121 | |                 ret = (builtin.callback) (self);
[INFO] [stderr] 122 | |             },
[INFO] [stderr] 123 | |             _ => { }
[INFO] [stderr] 124 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 119 |         if let Some(builtin) = self.builtin {
[INFO] [stderr] 120 |     ret = (builtin.callback) (self);
[INFO] [stderr] 121 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `job_list::JobList`
[INFO] [stderr]   --> src/job_list.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> JobList {
[INFO] [stderr] 17 | |         JobList {
[INFO] [stderr] 18 | |             list: Vec::new(),
[INFO] [stderr] 19 | |             forground_job: None,
[INFO] [stderr] 20 | |         }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/job_list.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 | /         match self.forground_job {
[INFO] [stderr] 25 | |             Some(ref job_ref) => {
[INFO] [stderr] 26 | |                 let mut job = job_ref.lock().unwrap();
[INFO] [stderr] 27 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |             }
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 24 |         if let Some(ref job_ref) = self.forground_job {
[INFO] [stderr] 25 |     let mut job = job_ref.lock().unwrap();
[INFO] [stderr] 26 | 
[INFO] [stderr] 27 |     unsafe { libc::tcsetpgrp(libc::STDIN_FILENO, (*job).pgrp); }
[INFO] [stderr] 28 |     job.cont();
[INFO] [stderr] 29 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/builtin.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 | /     let job_id;
[INFO] [stderr] 107 | |
[INFO] [stderr] 108 | |     if prog.args.len() < 1 {
[INFO] [stderr] 109 | |         job_id = 1;
[INFO] [stderr] 110 | |     } else {
[INFO] [stderr] 111 | |         job_id = prog.args[0].parse::<usize>().unwrap();
[INFO] [stderr] 112 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let job_id = if prog.args.len() < 1 { 1 } else { prog.args[0].parse::<usize>().unwrap() };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/builtin.rs:108:8
[INFO] [stderr]     |
[INFO] [stderr] 108 |     if prog.args.len() < 1 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prog.args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/job_list.rs:60:21
[INFO] [stderr]    |
[INFO] [stderr] 60 |     pub fn is_empty(&mut self) -> bool {
[INFO] [stderr]    |                     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/builtin.rs:132:8
[INFO] [stderr]     |
[INFO] [stderr] 132 |     if prog.args.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prog.args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/builtin.rs:136:50
[INFO] [stderr]     |
[INFO] [stderr] 136 |     let vec_dirs: Vec<&str> = prog.args[0].split("/").collect();
[INFO] [stderr]     |                                                  ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/builtin.rs:147:12
[INFO] [stderr]     |
[INFO] [stderr] 147 |         if dir.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dir.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/builtin.rs:160:16
[INFO] [stderr]     |
[INFO] [stderr] 160 |             if new_cwd.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `new_cwd.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/builtin.rs:188:8
[INFO] [stderr]     |
[INFO] [stderr] 188 |     if prog.args.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prog.args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `prog::Prog`
[INFO] [stderr]   --> src/prog.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new() -> Prog {
[INFO] [stderr] 28 | |         Prog {
[INFO] [stderr] 29 | |             file: "".to_string(),
[INFO] [stderr] 30 | |             args: Vec::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |         }
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/prog.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 | /         match self.builtin {
[INFO] [stderr] 62 | |             Some(builtin) => {
[INFO] [stderr] 63 | |                 let ret = (builtin.callback) (self);
[INFO] [stderr] 64 | |                 process::exit(ret as i32);
[INFO] [stderr] 65 | |             },
[INFO] [stderr] 66 | |             _ => { }
[INFO] [stderr] 67 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 61 |         if let Some(builtin) = self.builtin {
[INFO] [stderr] 62 |     let ret = (builtin.callback) (self);
[INFO] [stderr] 63 |     process::exit(ret as i32);
[INFO] [stderr] 64 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()`
[INFO] [stderr]   --> src/prog.rs:83:25
[INFO] [stderr]    |
[INFO] [stderr] 83 |         c_char_vec.push(0 as *const libc::c_char);
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::zero_ptr)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr
[INFO] [stderr] 
[INFO] [stderr] error: you are getting the inner pointer of a temporary `CString`
[INFO] [stderr]   --> src/prog.rs:89:22
[INFO] [stderr]    |
[INFO] [stderr] 89 |         libc::execvp(CString::new(self.file.clone()).unwrap().as_ptr() as *const libc::c_char, c_char_vec.as_ptr() as *const *const libc::c_char);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: that pointer will be invalid outside this expression
[INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime
[INFO] [stderr]   --> src/prog.rs:89:22
[INFO] [stderr]    |
[INFO] [stderr] 89 |         libc::execvp(CString::new(self.file.clone()).unwrap().as_ptr() as *const libc::c_char, c_char_vec.as_ptr() as *const *const libc::c_char);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/prog.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 | /         match self.builtin {
[INFO] [stderr] 120 | |             Some(builtin) => {
[INFO] [stderr] 121 | |                 ret = (builtin.callback) (self);
[INFO] [stderr] 122 | |             },
[INFO] [stderr] 123 | |             _ => { }
[INFO] [stderr] 124 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 119 |         if let Some(builtin) = self.builtin {
[INFO] [stderr] 120 |     ret = (builtin.callback) (self);
[INFO] [stderr] 121 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `job_list::JobList`
[INFO] [stderr]   --> src/job_list.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> JobList {
[INFO] [stderr] 17 | |         JobList {
[INFO] [stderr] 18 | |             list: Vec::new(),
[INFO] [stderr] 19 | |             forground_job: None,
[INFO] [stderr] 20 | |         }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/job_list.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 | /         match self.forground_job {
[INFO] [stderr] 25 | |             Some(ref job_ref) => {
[INFO] [stderr] 26 | |                 let mut job = job_ref.lock().unwrap();
[INFO] [stderr] 27 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |             }
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 24 |         if let Some(ref job_ref) = self.forground_job {
[INFO] [stderr] 25 |     let mut job = job_ref.lock().unwrap();
[INFO] [stderr] 26 | 
[INFO] [stderr] 27 |     unsafe { libc::tcsetpgrp(libc::STDIN_FILENO, (*job).pgrp); }
[INFO] [stderr] 28 |     job.cont();
[INFO] [stderr] 29 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/job_list.rs:60:21
[INFO] [stderr]    |
[INFO] [stderr] 60 |     pub fn is_empty(&mut self) -> bool {
[INFO] [stderr]    |                     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]   --> src/main.rs:34:11
[INFO] [stderr]    |
[INFO] [stderr] 34 |     match env.filter(|x| x.0 == "HOME").next() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]    = note: replace `filter(|x| x.0 == "HOME").next()` with `find(|x| x.0 == "HOME")`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]   --> src/main.rs:34:11
[INFO] [stderr]    |
[INFO] [stderr] 34 |     match env.filter(|x| x.0 == "HOME").next() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]    = note: replace `filter(|x| x.0 == "HOME").next()` with `find(|x| x.0 == "HOME")`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rshell`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: Could not compile `rshell`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "7032e676ed9616dafd971c5cc6476076f66647d26503225ce41f377c9bdd63b2"`
[INFO] running `"docker" "rm" "-f" "7032e676ed9616dafd971c5cc6476076f66647d26503225ce41f377c9bdd63b2"`
[INFO] [stdout] 7032e676ed9616dafd971c5cc6476076f66647d26503225ce41f377c9bdd63b2