[INFO] updating cached repository mkilgore/chatrs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mkilgore/chatrs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mkilgore/chatrs" "work/ex/clippy-test-run/sources/stable/gh/mkilgore/chatrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mkilgore/chatrs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mkilgore/chatrs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkilgore/chatrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkilgore/chatrs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a0df92ea1f0f8b96d6f2e3c0082aa6d2337c0d88 [INFO] sha for GitHub repo mkilgore/chatrs: a0df92ea1f0f8b96d6f2e3c0082aa6d2337c0d88 [INFO] validating manifest of mkilgore/chatrs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mkilgore/chatrs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mkilgore/chatrs [INFO] finished frobbing mkilgore/chatrs [INFO] frobbed toml for mkilgore/chatrs written to work/ex/clippy-test-run/sources/stable/gh/mkilgore/chatrs/Cargo.toml [INFO] started frobbing mkilgore/chatrs [INFO] finished frobbing mkilgore/chatrs [INFO] frobbed toml for mkilgore/chatrs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkilgore/chatrs/Cargo.toml [INFO] crate mkilgore/chatrs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mkilgore/chatrs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkilgore/chatrs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ebd1b04c01d42babe5345ac72518c99e356ce781e27007175022c857d350f3e [INFO] running `"docker" "start" "-a" "5ebd1b04c01d42babe5345ac72518c99e356ce781e27007175022c857d350f3e"` [INFO] [stderr] Checking colored v1.4.1 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking chatrs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: The function/method `termios::tcsetattr` doesn't need a mutable reference [INFO] [stderr] --> src/terminal.rs:22:71 [INFO] [stderr] | [INFO] [stderr] 22 | try!(termios::tcsetattr(libc::STDIN_FILENO, termios::TCSANOW, &mut nterm)); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `termios::tcsetattr` doesn't need a mutable reference [INFO] [stderr] --> src/terminal.rs:74:66 [INFO] [stderr] | [INFO] [stderr] 74 | termios::tcsetattr(libc::STDIN_FILENO, termios::TCSANOW, &mut self.old_termios).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/msg.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if msg.text.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/msg.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | stream.write(msg.text.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `str::from_utf8` doesn't need a mutable reference [INFO] [stderr] --> src/msg.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | msg.text = str::from_utf8(&mut v).unwrap().to_string(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | if inp.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!inp.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: The function/method `termios::tcsetattr` doesn't need a mutable reference [INFO] [stderr] --> src/terminal.rs:22:71 [INFO] [stderr] | [INFO] [stderr] 22 | try!(termios::tcsetattr(libc::STDIN_FILENO, termios::TCSANOW, &mut nterm)); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: Could not compile `chatrs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: The function/method `termios::tcsetattr` doesn't need a mutable reference [INFO] [stderr] --> src/terminal.rs:74:66 [INFO] [stderr] | [INFO] [stderr] 74 | termios::tcsetattr(libc::STDIN_FILENO, termios::TCSANOW, &mut self.old_termios).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/msg.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if msg.text.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/msg.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | stream.write(msg.text.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `str::from_utf8` doesn't need a mutable reference [INFO] [stderr] --> src/msg.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | msg.text = str::from_utf8(&mut v).unwrap().to_string(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | if inp.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!inp.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chatrs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5ebd1b04c01d42babe5345ac72518c99e356ce781e27007175022c857d350f3e"` [INFO] running `"docker" "rm" "-f" "5ebd1b04c01d42babe5345ac72518c99e356ce781e27007175022c857d350f3e"` [INFO] [stdout] 5ebd1b04c01d42babe5345ac72518c99e356ce781e27007175022c857d350f3e