[INFO] updating cached repository miyamofigo/lzw [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/miyamofigo/lzw [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/miyamofigo/lzw" "work/ex/clippy-test-run/sources/stable/gh/miyamofigo/lzw"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/miyamofigo/lzw'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/miyamofigo/lzw" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/miyamofigo/lzw"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/miyamofigo/lzw'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 642a2cff98782747c679ee100d7b4b4146ebe2f3 [INFO] sha for GitHub repo miyamofigo/lzw: 642a2cff98782747c679ee100d7b4b4146ebe2f3 [INFO] validating manifest of miyamofigo/lzw on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of miyamofigo/lzw on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing miyamofigo/lzw [INFO] finished frobbing miyamofigo/lzw [INFO] frobbed toml for miyamofigo/lzw written to work/ex/clippy-test-run/sources/stable/gh/miyamofigo/lzw/Cargo.toml [INFO] started frobbing miyamofigo/lzw [INFO] finished frobbing miyamofigo/lzw [INFO] frobbed toml for miyamofigo/lzw written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/miyamofigo/lzw/Cargo.toml [INFO] crate miyamofigo/lzw has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting miyamofigo/lzw against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/miyamofigo/lzw:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c4c3432f97f6ed03e386eb82b7e9103a756ccd642f5026e296c280917b2d3d61 [INFO] running `"docker" "start" "-a" "c4c3432f97f6ed03e386eb82b7e9103a756ccd642f5026e296c280917b2d3d61"` [INFO] [stderr] Checking lzw v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | let mut comp = compress("hello world"); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | let mut comp2 = compress("hello worldhello world"); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / if map.contains_key(&wc) { w = wc;} [INFO] [stderr] 24 | | [INFO] [stderr] 25 | | else { [INFO] [stderr] 26 | | [INFO] [stderr] ... | [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: consider using: `map.entry(wc)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | let mut result = map.get(&top) [INFO] [stderr] | ______________________^ [INFO] [stderr] 68 | | .unwrap() [INFO] [stderr] | |_________________________________^ help: try this: `&map[&top]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | entry = map.get(&j).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&j]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | let mut comp = compress("hello world"); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | let mut comp2 = compress("hello worldhello world"); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / if map.contains_key(&wc) { w = wc;} [INFO] [stderr] 24 | | [INFO] [stderr] 25 | | else { [INFO] [stderr] 26 | | [INFO] [stderr] ... | [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: consider using: `map.entry(wc)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | let mut result = map.get(&top) [INFO] [stderr] | ______________________^ [INFO] [stderr] 68 | | .unwrap() [INFO] [stderr] | |_________________________________^ help: try this: `&map[&top]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | entry = map.get(&j).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&j]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `"docker" "inspect" "c4c3432f97f6ed03e386eb82b7e9103a756ccd642f5026e296c280917b2d3d61"` [INFO] running `"docker" "rm" "-f" "c4c3432f97f6ed03e386eb82b7e9103a756ccd642f5026e296c280917b2d3d61"` [INFO] [stdout] c4c3432f97f6ed03e386eb82b7e9103a756ccd642f5026e296c280917b2d3d61