[INFO] updating cached repository mishajw/taneja
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mishajw/taneja
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mishajw/taneja" "work/ex/clippy-test-run/sources/stable/gh/mishajw/taneja"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mishajw/taneja'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mishajw/taneja" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mishajw/taneja"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mishajw/taneja'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5835e400a85b9576b4887f7d40187e2e53718161
[INFO] sha for GitHub repo mishajw/taneja: 5835e400a85b9576b4887f7d40187e2e53718161
[INFO] validating manifest of mishajw/taneja on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mishajw/taneja on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mishajw/taneja
[INFO] finished frobbing mishajw/taneja
[INFO] frobbed toml for mishajw/taneja written to work/ex/clippy-test-run/sources/stable/gh/mishajw/taneja/Cargo.toml
[INFO] started frobbing mishajw/taneja
[INFO] finished frobbing mishajw/taneja
[INFO] frobbed toml for mishajw/taneja written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mishajw/taneja/Cargo.toml
[INFO] crate mishajw/taneja has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mishajw/taneja against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mishajw/taneja:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 085949e108a8031869da76b2b54960f6d89a278c58e278cb6f38568858144a88
[INFO] running `"docker" "start" "-a" "085949e108a8031869da76b2b54960f6d89a278c58e278cb6f38568858144a88"`
[INFO] [stderr]     Checking atty v0.2.2
[INFO] [stderr]     Checking clap v2.24.0
[INFO] [stderr]     Checking taneja v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/possible_expressions.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return combinations
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `combinations`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:68:28
[INFO] [stderr]    |
[INFO] [stderr] 68 |                 if found % 100000 == 0 {
[INFO] [stderr]    |                            ^^^^^^ help: consider: `100_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/possible_expressions.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return combinations
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `combinations`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:68:28
[INFO] [stderr]    |
[INFO] [stderr] 68 |                 if found % 100000 == 0 {
[INFO] [stderr]    |                            ^^^^^^ help: consider: `100_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/expression.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 | /         match self {
[INFO] [stderr] 20 | |             &Expression::Value(ref a) =>
[INFO] [stderr] 21 | |                 Some(a.clone()),
[INFO] [stderr] 22 | |             &Expression::Add(ref a, ref b) =>
[INFO] [stderr] ...  |
[INFO] [stderr] 51 | |                 },
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 19 |         match *self {
[INFO] [stderr] 20 |             Expression::Value(ref a) =>
[INFO] [stderr] 21 |                 Some(a.clone()),
[INFO] [stderr] 22 |             Expression::Add(ref a, ref b) =>
[INFO] [stderr] 23 |                 match (a.evaluate(), b.evaluate()) {
[INFO] [stderr] 24 |                     (Some(a), Some(b)) => a.add(&b),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/expression.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match self {
[INFO] [stderr] 59 | |             &Expression::Value(ref a) => write!(f, "{}", a),
[INFO] [stderr] 60 | |             &Expression::Add(ref a, ref b) => write!(f, "({} + {})", a, b),
[INFO] [stderr] 61 | |             &Expression::Subtract(ref a, ref b) => write!(f, "({} - {})", a, b),
[INFO] [stderr] ...  |
[INFO] [stderr] 65 | |             &Expression::Concat(ref a, ref b) => write!(f, "({} | {})", a, b),
[INFO] [stderr] 66 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |         match *self {
[INFO] [stderr] 59 |             Expression::Value(ref a) => write!(f, "{}", a),
[INFO] [stderr] 60 |             Expression::Add(ref a, ref b) => write!(f, "({} + {})", a, b),
[INFO] [stderr] 61 |             Expression::Subtract(ref a, ref b) => write!(f, "({} - {})", a, b),
[INFO] [stderr] 62 |             Expression::Multiply(ref a, ref b) => write!(f, "({} * {})", a, b),
[INFO] [stderr] 63 |             Expression::Divide(ref a, ref b) => write!(f, "({} / {})", a, b),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/number.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         Some(self * 10i32.pow((*other as f64).log(10f64).ceil() as u32) + other)
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^ help: try: `f64::from(*other)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/possible_expressions.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 | /     match (a, b) {
[INFO] [stderr] 34 | |         (&Expression::Value(_), &Expression::Value(_)) =>
[INFO] [stderr] 35 | |             combinations.push(Expression::Concat(Box::new(a.clone()), Box::new(b.clone()))),
[INFO] [stderr] 36 | |         _ => {}
[INFO] [stderr] 37 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let (&Expression::Value(_), &Expression::Value(_)) = (a, b) { combinations.push(Expression::Concat(Box::new(a.clone()), Box::new(b.clone()))) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:102:5
[INFO] [stderr]     |
[INFO] [stderr] 102 |     (1..length + 1)
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: use: `(1..=length)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 | /         match previous_opt {
[INFO] [stderr] 129 | |             Some(previous) => {
[INFO] [stderr] 130 | |                 let difference = evaluation - previous;
[INFO] [stderr] 131 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 152 | |             None => {}
[INFO] [stderr] 153 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 128 |         if let Some(previous) = previous_opt {
[INFO] [stderr] 129 |     let difference = evaluation - previous;
[INFO] [stderr] 130 | 
[INFO] [stderr] 131 |     if difference == 1 {
[INFO] [stderr] 132 |         if let Some(streak_beginning) = streak_beginning_opt {
[INFO] [stderr] 133 |             let streak_length = evaluation - streak_beginning;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:158:5
[INFO] [stderr]     |
[INFO] [stderr] 158 | /     match (longest_streak_start, longest_streak_end) {
[INFO] [stderr] 159 | |         (Some(start), Some(end)) =>
[INFO] [stderr] 160 | |             println!("Longest streak from {} to {} with length of {}", start, end + 1, longest_streak),
[INFO] [stderr] 161 | |         _ => {}
[INFO] [stderr] 162 | |     }
[INFO] [stderr]     | |_____^ help: try this: `if let (Some(start), Some(end)) = (longest_streak_start, longest_streak_end) { println!("Longest streak from {} to {} with length of {}", start, end + 1, longest_streak) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/expression.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 | /         match self {
[INFO] [stderr] 20 | |             &Expression::Value(ref a) =>
[INFO] [stderr] 21 | |                 Some(a.clone()),
[INFO] [stderr] 22 | |             &Expression::Add(ref a, ref b) =>
[INFO] [stderr] ...  |
[INFO] [stderr] 51 | |                 },
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 19 |         match *self {
[INFO] [stderr] 20 |             Expression::Value(ref a) =>
[INFO] [stderr] 21 |                 Some(a.clone()),
[INFO] [stderr] 22 |             Expression::Add(ref a, ref b) =>
[INFO] [stderr] 23 |                 match (a.evaluate(), b.evaluate()) {
[INFO] [stderr] 24 |                     (Some(a), Some(b)) => a.add(&b),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/expression.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match self {
[INFO] [stderr] 59 | |             &Expression::Value(ref a) => write!(f, "{}", a),
[INFO] [stderr] 60 | |             &Expression::Add(ref a, ref b) => write!(f, "({} + {})", a, b),
[INFO] [stderr] 61 | |             &Expression::Subtract(ref a, ref b) => write!(f, "({} - {})", a, b),
[INFO] [stderr] ...  |
[INFO] [stderr] 65 | |             &Expression::Concat(ref a, ref b) => write!(f, "({} | {})", a, b),
[INFO] [stderr] 66 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |         match *self {
[INFO] [stderr] 59 |             Expression::Value(ref a) => write!(f, "{}", a),
[INFO] [stderr] 60 |             Expression::Add(ref a, ref b) => write!(f, "({} + {})", a, b),
[INFO] [stderr] 61 |             Expression::Subtract(ref a, ref b) => write!(f, "({} - {})", a, b),
[INFO] [stderr] 62 |             Expression::Multiply(ref a, ref b) => write!(f, "({} * {})", a, b),
[INFO] [stderr] 63 |             Expression::Divide(ref a, ref b) => write!(f, "({} / {})", a, b),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/number.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         Some(self * 10i32.pow((*other as f64).log(10f64).ceil() as u32) + other)
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^ help: try: `f64::from(*other)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/possible_expressions.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 | /     match (a, b) {
[INFO] [stderr] 34 | |         (&Expression::Value(_), &Expression::Value(_)) =>
[INFO] [stderr] 35 | |             combinations.push(Expression::Concat(Box::new(a.clone()), Box::new(b.clone()))),
[INFO] [stderr] 36 | |         _ => {}
[INFO] [stderr] 37 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let (&Expression::Value(_), &Expression::Value(_)) = (a, b) { combinations.push(Expression::Concat(Box::new(a.clone()), Box::new(b.clone()))) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:102:5
[INFO] [stderr]     |
[INFO] [stderr] 102 |     (1..length + 1)
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: use: `(1..=length)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 | /         match previous_opt {
[INFO] [stderr] 129 | |             Some(previous) => {
[INFO] [stderr] 130 | |                 let difference = evaluation - previous;
[INFO] [stderr] 131 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 152 | |             None => {}
[INFO] [stderr] 153 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 128 |         if let Some(previous) = previous_opt {
[INFO] [stderr] 129 |     let difference = evaluation - previous;
[INFO] [stderr] 130 | 
[INFO] [stderr] 131 |     if difference == 1 {
[INFO] [stderr] 132 |         if let Some(streak_beginning) = streak_beginning_opt {
[INFO] [stderr] 133 |             let streak_length = evaluation - streak_beginning;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:158:5
[INFO] [stderr]     |
[INFO] [stderr] 158 | /     match (longest_streak_start, longest_streak_end) {
[INFO] [stderr] 159 | |         (Some(start), Some(end)) =>
[INFO] [stderr] 160 | |             println!("Longest streak from {} to {} with length of {}", start, end + 1, longest_streak),
[INFO] [stderr] 161 | |         _ => {}
[INFO] [stderr] 162 | |     }
[INFO] [stderr]     | |_____^ help: try this: `if let (Some(start), Some(end)) = (longest_streak_start, longest_streak_end) { println!("Longest streak from {} to {} with length of {}", start, end + 1, longest_streak) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.52s
[INFO] running `"docker" "inspect" "085949e108a8031869da76b2b54960f6d89a278c58e278cb6f38568858144a88"`
[INFO] running `"docker" "rm" "-f" "085949e108a8031869da76b2b54960f6d89a278c58e278cb6f38568858144a88"`
[INFO] [stdout] 085949e108a8031869da76b2b54960f6d89a278c58e278cb6f38568858144a88