[INFO] updating cached repository millere/bf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/millere/bf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/millere/bf" "work/ex/clippy-test-run/sources/stable/gh/millere/bf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/millere/bf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/millere/bf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/millere/bf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/millere/bf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cde8a51673f5b16771bd577a615cf474205dc20d [INFO] sha for GitHub repo millere/bf: cde8a51673f5b16771bd577a615cf474205dc20d [INFO] validating manifest of millere/bf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of millere/bf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing millere/bf [INFO] finished frobbing millere/bf [INFO] frobbed toml for millere/bf written to work/ex/clippy-test-run/sources/stable/gh/millere/bf/Cargo.toml [INFO] started frobbing millere/bf [INFO] finished frobbing millere/bf [INFO] frobbed toml for millere/bf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/millere/bf/Cargo.toml [INFO] crate millere/bf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting millere/bf against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/millere/bf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28e66a58bbc157e43ebbf7bf4920a4a8648cb45804f73ca20a567a88e1995ea9 [INFO] running `"docker" "start" "-a" "28e66a58bbc157e43ebbf7bf4920a4a8648cb45804f73ca20a567a88e1995ea9"` [INFO] [stderr] Checking bf v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | b'.' => {output.write(&mut buffer[mptr .. mptr+1]);}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | b'.' => {output.write(&mut buffer[mptr .. mptr+1]);}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:14:47 [INFO] [stderr] | [INFO] [stderr] 14 | b'.' => {output.write(&mut buffer[mptr .. mptr+1]);}, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `mptr..=mptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:16:46 [INFO] [stderr] | [INFO] [stderr] 16 | match input.read(&mut buffer[mptr .. mptr+1]) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `mptr..=mptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | b'.' => {output.write(&mut buffer[mptr .. mptr+1]);}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | b'.' => {output.write(&mut buffer[mptr .. mptr+1]);}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:14:47 [INFO] [stderr] | [INFO] [stderr] 14 | b'.' => {output.write(&mut buffer[mptr .. mptr+1]);}, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `mptr..=mptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:16:46 [INFO] [stderr] | [INFO] [stderr] 16 | match input.read(&mut buffer[mptr .. mptr+1]) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `mptr..=mptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.56s [INFO] running `"docker" "inspect" "28e66a58bbc157e43ebbf7bf4920a4a8648cb45804f73ca20a567a88e1995ea9"` [INFO] running `"docker" "rm" "-f" "28e66a58bbc157e43ebbf7bf4920a4a8648cb45804f73ca20a567a88e1995ea9"` [INFO] [stdout] 28e66a58bbc157e43ebbf7bf4920a4a8648cb45804f73ca20a567a88e1995ea9