[INFO] updating cached repository mickelsonm/rustmonster [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mickelsonm/rustmonster [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mickelsonm/rustmonster" "work/ex/clippy-test-run/sources/stable/gh/mickelsonm/rustmonster"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mickelsonm/rustmonster'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mickelsonm/rustmonster" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mickelsonm/rustmonster"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mickelsonm/rustmonster'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 37870b8a369c76e7dbf6d0b6c9c325f953fa35a9 [INFO] sha for GitHub repo mickelsonm/rustmonster: 37870b8a369c76e7dbf6d0b6c9c325f953fa35a9 [INFO] validating manifest of mickelsonm/rustmonster on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mickelsonm/rustmonster on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mickelsonm/rustmonster [INFO] finished frobbing mickelsonm/rustmonster [INFO] frobbed toml for mickelsonm/rustmonster written to work/ex/clippy-test-run/sources/stable/gh/mickelsonm/rustmonster/Cargo.toml [INFO] started frobbing mickelsonm/rustmonster [INFO] finished frobbing mickelsonm/rustmonster [INFO] frobbed toml for mickelsonm/rustmonster written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mickelsonm/rustmonster/Cargo.toml [INFO] crate mickelsonm/rustmonster has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mickelsonm/rustmonster against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mickelsonm/rustmonster:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc5f47ae511d5b624c42af3b76a6d02c4d21f1f7fd13f6575a0497b729c4e6cf [INFO] running `"docker" "start" "-a" "fc5f47ae511d5b624c42af3b76a6d02c4d21f1f7fd13f6575a0497b729c4e6cf"` [INFO] [stderr] Checking rustmonster v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | _ => println!(""), [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | let pt = Point{x: x, y: x*2}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | _ => println!(""), [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | let pt = Point{x: x, y: x*2}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | let is_rusty = if name == "rusty"{ [INFO] [stderr] | ____________________^ [INFO] [stderr] 51 | | true [INFO] [stderr] 52 | | } else{ [INFO] [stderr] 53 | | false [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_____^ help: you can reduce it to: `name == "rusty"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | let is_rusty = if name == "rusty"{ [INFO] [stderr] | ____________________^ [INFO] [stderr] 51 | | true [INFO] [stderr] 52 | | } else{ [INFO] [stderr] 53 | | false [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_____^ help: you can reduce it to: `name == "rusty"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "fc5f47ae511d5b624c42af3b76a6d02c4d21f1f7fd13f6575a0497b729c4e6cf"` [INFO] running `"docker" "rm" "-f" "fc5f47ae511d5b624c42af3b76a6d02c4d21f1f7fd13f6575a0497b729c4e6cf"` [INFO] [stdout] fc5f47ae511d5b624c42af3b76a6d02c4d21f1f7fd13f6575a0497b729c4e6cf