[INFO] updating cached repository michelboaventura/sav.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/michelboaventura/sav.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/michelboaventura/sav.rs" "work/ex/clippy-test-run/sources/stable/gh/michelboaventura/sav.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/michelboaventura/sav.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/michelboaventura/sav.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michelboaventura/sav.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michelboaventura/sav.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 59c54a4f69b7c39adfe2054bab507aa4cba1aacb [INFO] sha for GitHub repo michelboaventura/sav.rs: 59c54a4f69b7c39adfe2054bab507aa4cba1aacb [INFO] validating manifest of michelboaventura/sav.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of michelboaventura/sav.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing michelboaventura/sav.rs [INFO] finished frobbing michelboaventura/sav.rs [INFO] frobbed toml for michelboaventura/sav.rs written to work/ex/clippy-test-run/sources/stable/gh/michelboaventura/sav.rs/Cargo.toml [INFO] started frobbing michelboaventura/sav.rs [INFO] finished frobbing michelboaventura/sav.rs [INFO] frobbed toml for michelboaventura/sav.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michelboaventura/sav.rs/Cargo.toml [INFO] crate michelboaventura/sav.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting michelboaventura/sav.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michelboaventura/sav.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ebe4b816662d429d1dc99e5026b188321a0dcfaba4df04faa8a5454872b85b5 [INFO] running `"docker" "start" "-a" "2ebe4b816662d429d1dc99e5026b188321a0dcfaba4df04faa8a5454872b85b5"` [INFO] [stderr] Checking nom v3.0.0 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Checking sav v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/records/header.rs:56:31 [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(header.ncases, 54436318); [INFO] [stderr] | ^^^^^^^^ help: consider: `54_436_318` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/records/variable.rs:64:32 [INFO] [stderr] | [INFO] [stderr] 64 | assert_eq!(variable.print, 328960); [INFO] [stderr] | ^^^^^^ help: consider: `328_960` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/records/variable.rs:65:32 [INFO] [stderr] | [INFO] [stderr] 65 | assert_eq!(variable.write, 328960); [INFO] [stderr] | ^^^^^^ help: consider: `328_960` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/records/header.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(header.bias, 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/records/header.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(header.bias, 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/records/header.rs:58:43 [INFO] [stderr] | [INFO] [stderr] 58 | assert_eq!(header.creation, buf_to_tm("21 Jun 1618:13:51".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"21 Jun 1618:13:51"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sav`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2ebe4b816662d429d1dc99e5026b188321a0dcfaba4df04faa8a5454872b85b5"` [INFO] running `"docker" "rm" "-f" "2ebe4b816662d429d1dc99e5026b188321a0dcfaba4df04faa8a5454872b85b5"` [INFO] [stdout] 2ebe4b816662d429d1dc99e5026b188321a0dcfaba4df04faa8a5454872b85b5