[INFO] updating cached repository michaelsproul/ewok [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/michaelsproul/ewok [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/michaelsproul/ewok" "work/ex/clippy-test-run/sources/stable/gh/michaelsproul/ewok"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/michaelsproul/ewok'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/michaelsproul/ewok" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelsproul/ewok"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelsproul/ewok'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b45a8ae52762063e298be99ad4b36fd6ee7cbfc0 [INFO] sha for GitHub repo michaelsproul/ewok: b45a8ae52762063e298be99ad4b36fd6ee7cbfc0 [INFO] validating manifest of michaelsproul/ewok on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of michaelsproul/ewok on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing michaelsproul/ewok [INFO] finished frobbing michaelsproul/ewok [INFO] frobbed toml for michaelsproul/ewok written to work/ex/clippy-test-run/sources/stable/gh/michaelsproul/ewok/Cargo.toml [INFO] started frobbing michaelsproul/ewok [INFO] finished frobbing michaelsproul/ewok [INFO] frobbed toml for michaelsproul/ewok written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelsproul/ewok/Cargo.toml [INFO] crate michaelsproul/ewok has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting michaelsproul/ewok against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelsproul/ewok:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c2cae2a5f6f406813e0042d039974d745b5a0b337ce90d5a773a97c2a71d6cc9 [INFO] running `"docker" "start" "-a" "c2cae2a5f6f406813e0042d039974d745b5a0b337ce90d5a773a97c2a71d6cc9"` [INFO] [stderr] Checking unwrap v1.1.0 [INFO] [stderr] Checking maplit v0.1.4 [INFO] [stderr] Checking thread-id v3.1.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking itertools v0.6.0 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking ewok v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blocks.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | bit_count: bit_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bit_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blocks.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | bit_count: bit_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bit_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:296:53 [INFO] [stderr] | [INFO] [stderr] 296 | members: btreeset!{ Name(0), short_name(0b10000000) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/name.rs:315:37 [INFO] [stderr] | [INFO] [stderr] 315 | let p001 = Prefix::short(3, 0b00100000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/name.rs:316:36 [INFO] [stderr] | [INFO] [stderr] 316 | let p01 = Prefix::short(2, 0b01000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/name.rs:317:36 [INFO] [stderr] | [INFO] [stderr] 317 | let p10 = Prefix::short(2, 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/name.rs:318:35 [INFO] [stderr] | [INFO] [stderr] 318 | let p1 = Prefix::short(1, 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/block.rs:12:27 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn into_block<'a>(&self, blocks: &'a Blocks) -> &'a Block { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `blocks::Blocks` [INFO] [stderr] --> src/blocks.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Blocks { [INFO] [stderr] 26 | | Blocks(HashMap::new()) [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/blocks.rs:211:16 [INFO] [stderr] | [INFO] [stderr] 211 | block: &BlockId, [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `BlockId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/blocks.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | map.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/blocks.rs:240:16 [INFO] [stderr] | [INFO] [stderr] 240 | block: &BlockId, [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `BlockId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blocks.rs:287:14 [INFO] [stderr] | [INFO] [stderr] 287 | Name((name as u64) << (64 - 8)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/block.rs:12:27 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn into_block<'a>(&self, blocks: &'a Blocks) -> &'a Block { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/name.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn common_prefix(&self, other: Self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/name.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn cmp_distance(&self, lhs: Self, rhs: Self) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/name.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn bit(&self, i: usize) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `blocks::Blocks` [INFO] [stderr] --> src/blocks.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Blocks { [INFO] [stderr] 26 | | Blocks(HashMap::new()) [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/name.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | let long_name = (name as u64) << (64 - 8); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/network.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | let num_delivered = (1..messages.len() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=messages.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/blocks.rs:211:16 [INFO] [stderr] | [INFO] [stderr] 211 | block: &BlockId, [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `BlockId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/blocks.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | map.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeSet [INFO] [stderr] --> src/node.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | .block_contents(blocks.into_iter().cloned()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/blocks.rs:240:16 [INFO] [stderr] | [INFO] [stderr] 240 | block: &BlockId, [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `BlockId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | vote.to.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `vote.to` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:158:74 [INFO] [stderr] | [INFO] [stderr] 158 | potentially_current.extend(new_votes.iter().map(|&(ref vote, _)| vote.to.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `vote.to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/node.rs:184:34 [INFO] [stderr] | [INFO] [stderr] 184 | fn is_candidate(&self, name: &Name, step: u64) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:532:27 [INFO] [stderr] | [INFO] [stderr] 532 | from: from.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/node.rs:695:46 [INFO] [stderr] | [INFO] [stderr] 695 | pub fn is_disconnected_from(&self, name: &Name) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/node.rs:724:25 [INFO] [stderr] | [INFO] [stderr] 724 | !bundle.into_iter().any(|&(ref vote, ref voters)| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/name.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn common_prefix(&self, other: Self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/name.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn cmp_distance(&self, lhs: Self, rhs: Self) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/name.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn bit(&self, i: usize) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/name.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | let long_name = (name as u64) << (64 - 8); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/network.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | let num_delivered = (1..messages.len() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=messages.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeSet [INFO] [stderr] --> src/node.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | .block_contents(blocks.into_iter().cloned()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | vote.to.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `vote.to` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:158:74 [INFO] [stderr] | [INFO] [stderr] 158 | potentially_current.extend(new_votes.iter().map(|&(ref vote, _)| vote.to.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `vote.to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/node.rs:184:34 [INFO] [stderr] | [INFO] [stderr] 184 | fn is_candidate(&self, name: &Name, step: u64) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeSet [INFO] [stderr] --> src/merge.rs:136:10 [INFO] [stderr] | [INFO] [stderr] 136 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:532:27 [INFO] [stderr] | [INFO] [stderr] 532 | from: from.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/node.rs:695:46 [INFO] [stderr] | [INFO] [stderr] 695 | pub fn is_disconnected_from(&self, name: &Name) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/node.rs:724:25 [INFO] [stderr] | [INFO] [stderr] 724 | !bundle.into_iter().any(|&(ref vote, ref voters)| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeSet [INFO] [stderr] --> src/merge.rs:136:10 [INFO] [stderr] | [INFO] [stderr] 136 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/graph.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/graph.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let _ = write!(writer, "digraph {{\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/graph.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | let _ = write!(writer, [INFO] [stderr] | _________________^ [INFO] [stderr] 63 | | "{} [label = {}; shape=box];\n", [INFO] [stderr] 64 | | b, [INFO] [stderr] 65 | | block.get_label()); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/graph.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | let _ = write!(writer, "{}->{}\n", vote.from, vote.to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/graph.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let _ = write!(writer, "}}\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/graph_msgs.rs:1:43 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/graph_msgs.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | write!(writer, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/graph.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/graph.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let _ = write!(writer, "digraph {{\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/graph.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | let _ = write!(writer, [INFO] [stderr] | _________________^ [INFO] [stderr] 63 | | "{} [label = {}; shape=box];\n", [INFO] [stderr] 64 | | b, [INFO] [stderr] 65 | | block.get_label()); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/graph.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | let _ = write!(writer, "{}->{}\n", vote.from, vote.to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/graph.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let _ = write!(writer, "}}\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/graph_msgs.rs:1:43 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/graph_msgs.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | write!(writer, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/graph.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/graph.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/graph_msgs.rs:1:43 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/graph_msgs.rs:1:43 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | Prefix::short(1, 0b10000000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | Prefix::short(2, 0b00000000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | Prefix::short(2, 0b01000000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | Prefix::short(2, 0b10000000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | Prefix::short(2, 0b11000000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | Prefix::short(3, 0b01000000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | Prefix::short(3, 0b10000000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | Prefix::short(3, 0b11000000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | Prefix::short(3, 0b11100000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | Prefix::short(4, 0b01100000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | Prefix::short(4, 0b01110000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | Prefix::short(4, 0b10100000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/manual_setup.rs:75:22 [INFO] [stderr] | [INFO] [stderr] 75 | Prefix::short(4, 0b10110000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.99s [INFO] running `"docker" "inspect" "c2cae2a5f6f406813e0042d039974d745b5a0b337ce90d5a773a97c2a71d6cc9"` [INFO] running `"docker" "rm" "-f" "c2cae2a5f6f406813e0042d039974d745b5a0b337ce90d5a773a97c2a71d6cc9"` [INFO] [stdout] c2cae2a5f6f406813e0042d039974d745b5a0b337ce90d5a773a97c2a71d6cc9