[INFO] updating cached repository mi-yu/emooji [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mi-yu/emooji [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mi-yu/emooji" "work/ex/clippy-test-run/sources/stable/gh/mi-yu/emooji"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mi-yu/emooji'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mi-yu/emooji" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mi-yu/emooji"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mi-yu/emooji'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d31a2972cc45d15e8d7b301d479bb7c601d31598 [INFO] sha for GitHub repo mi-yu/emooji: d31a2972cc45d15e8d7b301d479bb7c601d31598 [INFO] validating manifest of mi-yu/emooji on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mi-yu/emooji on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mi-yu/emooji [INFO] finished frobbing mi-yu/emooji [INFO] frobbed toml for mi-yu/emooji written to work/ex/clippy-test-run/sources/stable/gh/mi-yu/emooji/Cargo.toml [INFO] started frobbing mi-yu/emooji [INFO] finished frobbing mi-yu/emooji [INFO] frobbed toml for mi-yu/emooji written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mi-yu/emooji/Cargo.toml [INFO] crate mi-yu/emooji has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mi-yu/emooji against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mi-yu/emooji:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 471691ec62d69c846d44b5972e20712d88c42b5f8432fa9d4f1c8b4209c50a42 [INFO] running `"docker" "start" "-a" "471691ec62d69c846d44b5972e20712d88c42b5f8432fa9d4f1c8b4209c50a42"` [INFO] [stderr] Checking emooji v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/mod.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/mod.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/mod.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/mod.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer/mod.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer/mod.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | return i; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/mod.rs:686:9 [INFO] [stderr] | [INFO] [stderr] 686 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer/mod.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer/mod.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | return i; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/mod.rs:686:9 [INFO] [stderr] | [INFO] [stderr] 686 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compiler/tokenizer/mod.rs:98:44 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn copy_arg_types(&mut self, args: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[VarType]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compiler/mod.rs:57:39 [INFO] [stderr] | [INFO] [stderr] 57 | fn annotate_func(&mut self, args: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[VarType]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/mod.rs:219:25 [INFO] [stderr] | [INFO] [stderr] 219 | / match vars.get(&id) { [INFO] [stderr] 220 | | Some(_) => panic!("Argument cannot share name with global variable: {}", [INFO] [stderr] 221 | | self.debug_str()), [INFO] [stderr] 222 | | None => {}, [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 219 | if let Some(_) = vars.get(&id) { panic!("Argument cannot share name with global variable: {}", [INFO] [stderr] 220 | self.debug_str()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compiler/tokenizer/mod.rs:98:44 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn copy_arg_types(&mut self, args: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[VarType]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/compiler/mod.rs:320:28 [INFO] [stderr] | [INFO] [stderr] 320 | panic!("Condition must evaluate to boolean: {}") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/compiler/mod.rs:333:36 [INFO] [stderr] | [INFO] [stderr] 333 | panic!("Condition must evaluate to boolean: {}") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/compiler/mod.rs:347:28 [INFO] [stderr] | [INFO] [stderr] 347 | panic!("Condition must evaluate to boolean: {}") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compiler/mod.rs:57:39 [INFO] [stderr] | [INFO] [stderr] 57 | fn annotate_func(&mut self, args: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[VarType]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/mod.rs:219:25 [INFO] [stderr] | [INFO] [stderr] 219 | / match vars.get(&id) { [INFO] [stderr] 220 | | Some(_) => panic!("Argument cannot share name with global variable: {}", [INFO] [stderr] 221 | | self.debug_str()), [INFO] [stderr] 222 | | None => {}, [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 219 | if let Some(_) = vars.get(&id) { panic!("Argument cannot share name with global variable: {}", [INFO] [stderr] 220 | self.debug_str()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/compiler/mod.rs:320:28 [INFO] [stderr] | [INFO] [stderr] 320 | panic!("Condition must evaluate to boolean: {}") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/compiler/mod.rs:333:36 [INFO] [stderr] | [INFO] [stderr] 333 | panic!("Condition must evaluate to boolean: {}") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/compiler/mod.rs:347:28 [INFO] [stderr] | [INFO] [stderr] 347 | panic!("Condition must evaluate to boolean: {}") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / match file.read_to_string(&mut program_contents) { [INFO] [stderr] 30 | | Err(why) => panic!("Couldn't read .moo file \'{}\': {}", [INFO] [stderr] 31 | | path_str, why.description()), [INFO] [stderr] 32 | | Ok(_) => {}, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | if let Err(why) = file.read_to_string(&mut program_contents) { panic!("Couldn't read .moo file \'{}\': {}", [INFO] [stderr] 30 | path_str, why.description()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / match file.read_to_string(&mut program_contents) { [INFO] [stderr] 30 | | Err(why) => panic!("Couldn't read .moo file \'{}\': {}", [INFO] [stderr] 31 | | path_str, why.description()), [INFO] [stderr] 32 | | Ok(_) => {}, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | if let Err(why) = file.read_to_string(&mut program_contents) { panic!("Couldn't read .moo file \'{}\': {}", [INFO] [stderr] 30 | path_str, why.description()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.03s [INFO] running `"docker" "inspect" "471691ec62d69c846d44b5972e20712d88c42b5f8432fa9d4f1c8b4209c50a42"` [INFO] running `"docker" "rm" "-f" "471691ec62d69c846d44b5972e20712d88c42b5f8432fa9d4f1c8b4209c50a42"` [INFO] [stdout] 471691ec62d69c846d44b5972e20712d88c42b5f8432fa9d4f1c8b4209c50a42