[INFO] updating cached repository mhn1991/quickSort [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mhn1991/quickSort [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mhn1991/quickSort" "work/ex/clippy-test-run/sources/stable/gh/mhn1991/quickSort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mhn1991/quickSort'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mhn1991/quickSort" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mhn1991/quickSort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mhn1991/quickSort'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6be97c12c127b0dca7f5785772974051fc8ca877 [INFO] sha for GitHub repo mhn1991/quickSort: 6be97c12c127b0dca7f5785772974051fc8ca877 [INFO] validating manifest of mhn1991/quickSort on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mhn1991/quickSort on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mhn1991/quickSort [INFO] finished frobbing mhn1991/quickSort [INFO] frobbed toml for mhn1991/quickSort written to work/ex/clippy-test-run/sources/stable/gh/mhn1991/quickSort/Cargo.toml [INFO] started frobbing mhn1991/quickSort [INFO] finished frobbing mhn1991/quickSort [INFO] frobbed toml for mhn1991/quickSort written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mhn1991/quickSort/Cargo.toml [INFO] crate mhn1991/quickSort has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mhn1991/quickSort against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mhn1991/quickSort:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 90f8972b66b9da2a69c955fac647a102e669961124578e50cd7a689a5c6cacba [INFO] running `"docker" "start" "-a" "90f8972b66b9da2a69c955fac647a102e669961124578e50cd7a689a5c6cacba"` [INFO] [stderr] Checking quick_sort v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sortpointer.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | list:list, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sortpointer.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | list:list, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sortpointer.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return i; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sortpointer.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return i; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/sortpointer.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn clone(&self)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] 44 | self.clone() [INFO] [stderr] | ------------ recursive call site [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unconditional_recursion)] on by default [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clone` [INFO] [stderr] --> src/sortpointer.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn clone(&self)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sortpointer.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | let pivot = &self.list.get(high as usize).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.list[high as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/sortpointer.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | if self.list.get(j).unwrap() <= &pivot{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `pivot` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sortpointer.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | if self.list.get(j).unwrap() <= &pivot{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.list[j]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/sortpointer.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn clone(&self)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] 44 | self.clone() [INFO] [stderr] | ------------ recursive call site [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unconditional_recursion)] on by default [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clone` [INFO] [stderr] --> src/sortpointer.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn clone(&self)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sortpointer.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | let pivot = &self.list.get(high as usize).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.list[high as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/sortpointer.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | if self.list.get(j).unwrap() <= &pivot{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `pivot` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sortpointer.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | if self.list.get(j).unwrap() <= &pivot{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.list[j]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "90f8972b66b9da2a69c955fac647a102e669961124578e50cd7a689a5c6cacba"` [INFO] running `"docker" "rm" "-f" "90f8972b66b9da2a69c955fac647a102e669961124578e50cd7a689a5c6cacba"` [INFO] [stdout] 90f8972b66b9da2a69c955fac647a102e669961124578e50cd7a689a5c6cacba