[INFO] updating cached repository mhn1991/dpll [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mhn1991/dpll [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mhn1991/dpll" "work/ex/clippy-test-run/sources/stable/gh/mhn1991/dpll"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mhn1991/dpll'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mhn1991/dpll" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mhn1991/dpll"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mhn1991/dpll'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 90d057d58e92863dbdf0cecda8a5982e068b993d [INFO] sha for GitHub repo mhn1991/dpll: 90d057d58e92863dbdf0cecda8a5982e068b993d [INFO] validating manifest of mhn1991/dpll on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mhn1991/dpll on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mhn1991/dpll [INFO] finished frobbing mhn1991/dpll [INFO] frobbed toml for mhn1991/dpll written to work/ex/clippy-test-run/sources/stable/gh/mhn1991/dpll/Cargo.toml [INFO] started frobbing mhn1991/dpll [INFO] finished frobbing mhn1991/dpll [INFO] frobbed toml for mhn1991/dpll written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mhn1991/dpll/Cargo.toml [INFO] crate mhn1991/dpll has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mhn1991/dpll against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mhn1991/dpll:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a8cc2303a8411e28f2f1df734cf959e81095126035d6d297c391ccf918ce0ee [INFO] running `"docker" "start" "-a" "9a8cc2303a8411e28f2f1df734cf959e81095126035d6d297c391ccf918ce0ee"` [INFO] [stderr] Checking dpll v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formula/clause/literal.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | id:id, [INFO] [stderr] | ^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formula/clause/literal.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | id:id, [INFO] [stderr] | ^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formula/clause/literal.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | return literal; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formula/clause/mod.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | return clause; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `clause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formula/mod.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | return formula; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dimacs.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | return formula; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dimacs.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return clause; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `clause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | true => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:29:11 [INFO] [stderr] | [INFO] [stderr] 29 | return solver(simplify(formula,Literal::negate(literal))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `solver(simplify(formula,Literal::negate(literal)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return formula; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formula/clause/literal.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | return literal; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formula/clause/mod.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | return clause; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `clause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formula/mod.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | return formula; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dimacs.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | return formula; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dimacs.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return clause; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `clause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | true => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:29:11 [INFO] [stderr] | [INFO] [stderr] 29 | return solver(simplify(formula,Literal::negate(literal))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `solver(simplify(formula,Literal::negate(literal)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return formula; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `int` [INFO] [stderr] --> src/dimacs.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(int) =>{ [INFO] [stderr] | ^^^ help: consider using `_int` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `int` [INFO] [stderr] --> src/dimacs.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(int) =>{ [INFO] [stderr] | ^^^ help: consider using `_int` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/formula/clause/literal.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | literal.id = literal.id * -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `literal.id *= -1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/formula/clause/literal.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | literal.id = literal.id * -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/formula/clause/literal.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | literal.id = literal.id * -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `literal.id *= -1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/formula/clause/literal.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | literal.id = literal.id * -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/solver.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / let mut flag = false; [INFO] [stderr] 8 | | if formula.list.is_empty() { [INFO] [stderr] 9 | | flag = true; [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let flag = if formula.list.is_empty() { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/solver.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match flag { [INFO] [stderr] 23 | | true => return true, [INFO] [stderr] 24 | | false =>{ [INFO] [stderr] 25 | | let literal = formula.list.get(0).unwrap().list[0]; [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 22 | if flag { return true } else { [INFO] [stderr] 23 | let literal = formula.list.get(0).unwrap().list[0]; [INFO] [stderr] 24 | if solver(simplify(formula.clone(),literal)){ [INFO] [stderr] 25 | return true; [INFO] [stderr] 26 | }else { [INFO] [stderr] 27 | return solver(simplify(formula,Literal::negate(literal))); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/solver.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | let literal = formula.list.get(0).unwrap().list[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&formula.list[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match answer { [INFO] [stderr] 10 | | true => println!("SAT"), [INFO] [stderr] 11 | | false=> println!("UNSAT") [INFO] [stderr] 12 | | } [INFO] [stderr] | |______^ help: consider using an if/else expression: `if answer { println!("SAT") } else { println!("UNSAT") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/solver.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / let mut flag = false; [INFO] [stderr] 8 | | if formula.list.is_empty() { [INFO] [stderr] 9 | | flag = true; [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let flag = if formula.list.is_empty() { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/solver.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match flag { [INFO] [stderr] 23 | | true => return true, [INFO] [stderr] 24 | | false =>{ [INFO] [stderr] 25 | | let literal = formula.list.get(0).unwrap().list[0]; [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 22 | if flag { return true } else { [INFO] [stderr] 23 | let literal = formula.list.get(0).unwrap().list[0]; [INFO] [stderr] 24 | if solver(simplify(formula.clone(),literal)){ [INFO] [stderr] 25 | return true; [INFO] [stderr] 26 | }else { [INFO] [stderr] 27 | return solver(simplify(formula,Literal::negate(literal))); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/solver.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | let literal = formula.list.get(0).unwrap().list[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&formula.list[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match answer { [INFO] [stderr] 10 | | true => println!("SAT"), [INFO] [stderr] 11 | | false=> println!("UNSAT") [INFO] [stderr] 12 | | } [INFO] [stderr] | |______^ help: consider using an if/else expression: `if answer { println!("SAT") } else { println!("UNSAT") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "9a8cc2303a8411e28f2f1df734cf959e81095126035d6d297c391ccf918ce0ee"` [INFO] running `"docker" "rm" "-f" "9a8cc2303a8411e28f2f1df734cf959e81095126035d6d297c391ccf918ce0ee"` [INFO] [stdout] 9a8cc2303a8411e28f2f1df734cf959e81095126035d6d297c391ccf918ce0ee