[INFO] updating cached repository mfs/hc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mfs/hc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mfs/hc" "work/ex/clippy-test-run/sources/stable/gh/mfs/hc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mfs/hc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mfs/hc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/hc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/hc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 06912bf577971cd9b35f5b347ef5622077ab048f [INFO] sha for GitHub repo mfs/hc: 06912bf577971cd9b35f5b347ef5622077ab048f [INFO] validating manifest of mfs/hc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mfs/hc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mfs/hc [INFO] finished frobbing mfs/hc [INFO] frobbed toml for mfs/hc written to work/ex/clippy-test-run/sources/stable/gh/mfs/hc/Cargo.toml [INFO] started frobbing mfs/hc [INFO] finished frobbing mfs/hc [INFO] frobbed toml for mfs/hc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/hc/Cargo.toml [INFO] crate mfs/hc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mfs/hc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/hc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d4f37ce6a623bea921397709dbcea8cb08a152c0e35f30ce9ef485fa7310732e [INFO] running `"docker" "start" "-a" "d4f37ce6a623bea921397709dbcea8cb08a152c0e35f30ce9ef485fa7310732e"` [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking clap v2.29.0 [INFO] [stderr] Checking hc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:173:12 [INFO] [stderr] | [INFO] [stderr] 173 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 174 | | if istty() { [INFO] [stderr] 175 | | interactive(); [INFO] [stderr] 176 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 173 | } else if istty() { [INFO] [stderr] 174 | interactive(); [INFO] [stderr] 175 | } else { [INFO] [stderr] 176 | let mut s = String::new(); [INFO] [stderr] 177 | match std::io::stdin().read_to_string(&mut s) { [INFO] [stderr] 178 | Ok(_) => calculate(&s), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:173:12 [INFO] [stderr] | [INFO] [stderr] 173 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 174 | | if istty() { [INFO] [stderr] 175 | | interactive(); [INFO] [stderr] 176 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 173 | } else if istty() { [INFO] [stderr] 174 | interactive(); [INFO] [stderr] 175 | } else { [INFO] [stderr] 176 | let mut s = String::new(); [INFO] [stderr] 177 | match std::io::stdin().read_to_string(&mut s) { [INFO] [stderr] 178 | Ok(_) => calculate(&s), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.26s [INFO] running `"docker" "inspect" "d4f37ce6a623bea921397709dbcea8cb08a152c0e35f30ce9ef485fa7310732e"` [INFO] running `"docker" "rm" "-f" "d4f37ce6a623bea921397709dbcea8cb08a152c0e35f30ce9ef485fa7310732e"` [INFO] [stdout] d4f37ce6a623bea921397709dbcea8cb08a152c0e35f30ce9ef485fa7310732e