[INFO] updating cached repository melbourne2991/rusty-lisp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/melbourne2991/rusty-lisp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/melbourne2991/rusty-lisp" "work/ex/clippy-test-run/sources/stable/gh/melbourne2991/rusty-lisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/melbourne2991/rusty-lisp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/melbourne2991/rusty-lisp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/melbourne2991/rusty-lisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/melbourne2991/rusty-lisp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b7a103349103746bbe05cf57cff9ca13ba32801c [INFO] sha for GitHub repo melbourne2991/rusty-lisp: b7a103349103746bbe05cf57cff9ca13ba32801c [INFO] validating manifest of melbourne2991/rusty-lisp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of melbourne2991/rusty-lisp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing melbourne2991/rusty-lisp [INFO] finished frobbing melbourne2991/rusty-lisp [INFO] frobbed toml for melbourne2991/rusty-lisp written to work/ex/clippy-test-run/sources/stable/gh/melbourne2991/rusty-lisp/Cargo.toml [INFO] started frobbing melbourne2991/rusty-lisp [INFO] finished frobbing melbourne2991/rusty-lisp [INFO] frobbed toml for melbourne2991/rusty-lisp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/melbourne2991/rusty-lisp/Cargo.toml [INFO] crate melbourne2991/rusty-lisp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting melbourne2991/rusty-lisp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/melbourne2991/rusty-lisp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0280c8514be672dd6cde98eaae8d02eaef17854cfe913b9655b0cfef3ff12104 [INFO] running `"docker" "start" "-a" "0280c8514be672dd6cde98eaae8d02eaef17854cfe913b9655b0cfef3ff12104"` [INFO] [stderr] Checking rusticle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parse_tree.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | PTree { nodes: nodes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | token_type: token_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:236:11 [INFO] [stderr] | [INFO] [stderr] 236 | start_line: start_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:237:11 [INFO] [stderr] | [INFO] [stderr] 237 | start_col: start_col, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/compiler/parser.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | print!("Error: {}\n", UnexpectedTokenError::new(token.token_type)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parse_tree.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | PTree { nodes: nodes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | token_type: token_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:236:11 [INFO] [stderr] | [INFO] [stderr] 236 | start_line: start_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:237:11 [INFO] [stderr] | [INFO] [stderr] 237 | start_col: start_col, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/compiler/parser.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | print!("Error: {}\n", UnexpectedTokenError::new(token.token_type)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/lexer.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | lexer [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/lexer.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | let lexer = Lexer { [INFO] [stderr] | _________________^ [INFO] [stderr] 71 | | chars: it, [INFO] [stderr] 72 | | current: None, [INFO] [stderr] 73 | | line: 1, [INFO] [stderr] 74 | | col: 1, [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | parser [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | let parser = Parser { [INFO] [stderr] | __________________^ [INFO] [stderr] 29 | | tree, [INFO] [stderr] 30 | | state: vec![root_ref], [INFO] [stderr] 31 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/lexer.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | lexer [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/lexer.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | let lexer = Lexer { [INFO] [stderr] | _________________^ [INFO] [stderr] 71 | | chars: it, [INFO] [stderr] 72 | | current: None, [INFO] [stderr] 73 | | line: 1, [INFO] [stderr] 74 | | col: 1, [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | parser [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | let parser = Parser { [INFO] [stderr] | __________________^ [INFO] [stderr] 29 | | tree, [INFO] [stderr] 30 | | state: vec![root_ref], [INFO] [stderr] 31 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ast` [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let ast = compiler::parse(filenames); [INFO] [stderr] | ^^^ help: consider using `_ast` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `as_non_terminal` [INFO] [stderr] --> src/compiler/parse_tree.rs:41:3 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn as_non_terminal(&self) -> PTParentNode<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: unused variable: `ast` [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let ast = compiler::parse(filenames); [INFO] [stderr] | ^^^ help: consider using `_ast` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_terminal` [INFO] [stderr] --> src/compiler/parse_tree.rs:115:3 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn get_terminal(&self, node_ref: usize) -> &Token { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Declaration` [INFO] [stderr] --> src/compiler/source_ast.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | Declaration, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `DeclarationBody` [INFO] [stderr] --> src/compiler/source_ast.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub enum DeclarationBody { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DeclarationNode` [INFO] [stderr] --> src/compiler/source_ast.rs:65:1 [INFO] [stderr] | [INFO] [stderr] 65 | pub struct DeclarationNode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Number` [INFO] [stderr] --> src/compiler/lexer.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | Number(String), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/compiler/parse_tree.rs:77:8 [INFO] [stderr] | [INFO] [stderr] 77 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/compiler/parse_tree.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | / pub fn get_parent_node<'a>(&'a self, node_ref: usize) -> PTParentNode<'a> { [INFO] [stderr] 109 | | PTParentNode { [INFO] [stderr] 110 | | internal: self.get_non_terminal(node_ref), [INFO] [stderr] 111 | | tree: self, [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/compiler/source_ast.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | / fn map_expression<'a>(non_terminal: PTParentNode<'a>) -> ExpressionNode { [INFO] [stderr] 151 | | let children: Box> = Box::new(non_terminal.children_iter().collect()); [INFO] [stderr] 152 | | [INFO] [stderr] 153 | | let first = children.get(1).expect("Unexpected error"); [INFO] [stderr] ... | [INFO] [stderr] 163 | | } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/compiler/source_ast.rs:157:30 [INFO] [stderr] | [INFO] [stderr] 157 | let arg_nodes = arg_tokens.into_iter().map(|node| map_arg(node)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/compiler/lexer.rs:106:11 [INFO] [stderr] | [INFO] [stderr] 106 | alpha_char_count = alpha_char_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alpha_char_count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/compiler/lexer.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | self.line = self.line + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.line += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/compiler/lexer.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | self.col = self.col + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.col += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: method is never used: `as_non_terminal` [INFO] [stderr] --> src/compiler/parse_tree.rs:41:3 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn as_non_terminal(&self) -> PTParentNode<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_terminal` [INFO] [stderr] --> src/compiler/parse_tree.rs:115:3 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn get_terminal(&self, node_ref: usize) -> &Token { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Declaration` [INFO] [stderr] --> src/compiler/source_ast.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | Declaration, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `DeclarationBody` [INFO] [stderr] --> src/compiler/source_ast.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub enum DeclarationBody { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DeclarationNode` [INFO] [stderr] --> src/compiler/source_ast.rs:65:1 [INFO] [stderr] | [INFO] [stderr] 65 | pub struct DeclarationNode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Number` [INFO] [stderr] --> src/compiler/lexer.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | Number(String), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/compiler/parse_tree.rs:77:8 [INFO] [stderr] | [INFO] [stderr] 77 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/compiler/parse_tree.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | / pub fn get_parent_node<'a>(&'a self, node_ref: usize) -> PTParentNode<'a> { [INFO] [stderr] 109 | | PTParentNode { [INFO] [stderr] 110 | | internal: self.get_non_terminal(node_ref), [INFO] [stderr] 111 | | tree: self, [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/compiler/source_ast.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | / fn map_expression<'a>(non_terminal: PTParentNode<'a>) -> ExpressionNode { [INFO] [stderr] 151 | | let children: Box> = Box::new(non_terminal.children_iter().collect()); [INFO] [stderr] 152 | | [INFO] [stderr] 153 | | let first = children.get(1).expect("Unexpected error"); [INFO] [stderr] ... | [INFO] [stderr] 163 | | } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/compiler/source_ast.rs:157:30 [INFO] [stderr] | [INFO] [stderr] 157 | let arg_nodes = arg_tokens.into_iter().map(|node| map_arg(node)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/compiler/lexer.rs:106:11 [INFO] [stderr] | [INFO] [stderr] 106 | alpha_char_count = alpha_char_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alpha_char_count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/compiler/lexer.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | self.line = self.line + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.line += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/compiler/lexer.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | self.col = self.col + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.col += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.09s [INFO] running `"docker" "inspect" "0280c8514be672dd6cde98eaae8d02eaef17854cfe913b9655b0cfef3ff12104"` [INFO] running `"docker" "rm" "-f" "0280c8514be672dd6cde98eaae8d02eaef17854cfe913b9655b0cfef3ff12104"` [INFO] [stdout] 0280c8514be672dd6cde98eaae8d02eaef17854cfe913b9655b0cfef3ff12104