[INFO] updating cached repository mehalom/2048 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mehalom/2048 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mehalom/2048" "work/ex/clippy-test-run/sources/stable/gh/mehalom/2048"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mehalom/2048'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mehalom/2048" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mehalom/2048"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mehalom/2048'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e801f029679d1d7ab90992a06c089fc02dd396c1 [INFO] sha for GitHub repo mehalom/2048: e801f029679d1d7ab90992a06c089fc02dd396c1 [INFO] validating manifest of mehalom/2048 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mehalom/2048 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mehalom/2048 [INFO] finished frobbing mehalom/2048 [INFO] frobbed toml for mehalom/2048 written to work/ex/clippy-test-run/sources/stable/gh/mehalom/2048/Cargo.toml [INFO] started frobbing mehalom/2048 [INFO] finished frobbing mehalom/2048 [INFO] frobbed toml for mehalom/2048 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mehalom/2048/Cargo.toml [INFO] crate mehalom/2048 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mehalom/2048 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mehalom/2048:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 04f883d9fd023e28f1afc9172919e3865d4645749cedbe673477aaa5c8a1fdf0 [INFO] running `"docker" "start" "-a" "04f883d9fd023e28f1afc9172919e3865d4645749cedbe673477aaa5c8a1fdf0"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking 2048 v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/game.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:50 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:53 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:56 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:59 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:62 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:65 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/game.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/game.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/game.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:50 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:53 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:56 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:59 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:62 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game.rs:174:65 [INFO] [stderr] | [INFO] [stderr] 174 | write!(buf, "{} {} {} {} {} {}", 0, 0, 0, 0, 0, 0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/game.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/game.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | return change; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `change` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | return change; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `change` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | return change; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `change` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:296:9 [INFO] [stderr] | [INFO] [stderr] 296 | return change; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `change` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | return (score, change); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(score, change)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | return answer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `answer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | return change; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `change` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | return change; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `change` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | return change; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `change` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:296:9 [INFO] [stderr] | [INFO] [stderr] 296 | return change; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `change` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | return (score, change); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(score, change)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | return answer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `answer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/game.rs:164:54 [INFO] [stderr] | [INFO] [stderr] 164 | let values: Vec<&str> = string.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | change = change | ans.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `change |= ans.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `temp` [INFO] [stderr] --> src/game.rs:250:22 [INFO] [stderr] | [INFO] [stderr] 250 | for j in 0..self.board.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 250 | for (j, ) in temp.iter().enumerate().take(self.board.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | change = change | ans.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `change |= ans.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | change = change | ans.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `change |= ans.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | change = change | ans.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `change |= ans.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `temp`. [INFO] [stderr] --> src/game.rs:292:22 [INFO] [stderr] | [INFO] [stderr] 292 | for i in 0..temp.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 292 | for in &temp { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/game.rs:302:15 [INFO] [stderr] | [INFO] [stderr] 302 | while flag == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `flag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:316:26 [INFO] [stderr] | [INFO] [stderr] 316 | score += row[i] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(row[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/game.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | / for c in stdin.keys() { [INFO] [stderr] 345 | | answer = match c.unwrap() { [INFO] [stderr] 346 | | Key::Char('q') | Key::Ctrl('c') => Status::Exit, [INFO] [stderr] 347 | | Key::Left | Key::Char('a') => if self.left() { [INFO] [stderr] ... | [INFO] [stderr] 379 | | break; [INFO] [stderr] 380 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/game.rs:164:54 [INFO] [stderr] | [INFO] [stderr] 164 | let values: Vec<&str> = string.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] error: Could not compile `2048`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | change = change | ans.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `change |= ans.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `temp` [INFO] [stderr] --> src/game.rs:250:22 [INFO] [stderr] | [INFO] [stderr] 250 | for j in 0..self.board.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 250 | for (j, ) in temp.iter().enumerate().take(self.board.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | change = change | ans.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `change |= ans.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | change = change | ans.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `change |= ans.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | change = change | ans.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `change |= ans.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `temp`. [INFO] [stderr] --> src/game.rs:292:22 [INFO] [stderr] | [INFO] [stderr] 292 | for i in 0..temp.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 292 | for in &temp { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/game.rs:302:15 [INFO] [stderr] | [INFO] [stderr] 302 | while flag == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `flag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:316:26 [INFO] [stderr] | [INFO] [stderr] 316 | score += row[i] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(row[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/game.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | / for c in stdin.keys() { [INFO] [stderr] 345 | | answer = match c.unwrap() { [INFO] [stderr] 346 | | Key::Char('q') | Key::Ctrl('c') => Status::Exit, [INFO] [stderr] 347 | | Key::Left | Key::Char('a') => if self.left() { [INFO] [stderr] ... | [INFO] [stderr] 379 | | break; [INFO] [stderr] 380 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `2048`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "04f883d9fd023e28f1afc9172919e3865d4645749cedbe673477aaa5c8a1fdf0"` [INFO] running `"docker" "rm" "-f" "04f883d9fd023e28f1afc9172919e3865d4645749cedbe673477aaa5c8a1fdf0"` [INFO] [stdout] 04f883d9fd023e28f1afc9172919e3865d4645749cedbe673477aaa5c8a1fdf0