[INFO] updating cached repository mcon/craftinginterpreters-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mcon/craftinginterpreters-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mcon/craftinginterpreters-rust" "work/ex/clippy-test-run/sources/stable/gh/mcon/craftinginterpreters-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mcon/craftinginterpreters-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mcon/craftinginterpreters-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcon/craftinginterpreters-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcon/craftinginterpreters-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b5ea6895c1842875f8a7b51379fff6ea47b84c73 [INFO] sha for GitHub repo mcon/craftinginterpreters-rust: b5ea6895c1842875f8a7b51379fff6ea47b84c73 [INFO] validating manifest of mcon/craftinginterpreters-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mcon/craftinginterpreters-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mcon/craftinginterpreters-rust [INFO] finished frobbing mcon/craftinginterpreters-rust [INFO] frobbed toml for mcon/craftinginterpreters-rust written to work/ex/clippy-test-run/sources/stable/gh/mcon/craftinginterpreters-rust/Cargo.toml [INFO] started frobbing mcon/craftinginterpreters-rust [INFO] finished frobbing mcon/craftinginterpreters-rust [INFO] frobbed toml for mcon/craftinginterpreters-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcon/craftinginterpreters-rust/Cargo.toml [INFO] crate mcon/craftinginterpreters-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mcon/craftinginterpreters-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcon/craftinginterpreters-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1fa43ac4d5f64ec43a65f49b8116721903cf059c0871b7107539a511d889f2d9 [INFO] running `"docker" "start" "-a" "1fa43ac4d5f64ec43a65f49b8116721903cf059c0871b7107539a511d889f2d9"` [INFO] [stderr] Checking argparse v0.2.2 [INFO] [stderr] Checking lox-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `scanner::TokenParseResult::TokenFound` [INFO] [stderr] --> src/scanner.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use scanner::TokenParseResult::TokenFound; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `scanner::TokenParseResult::Error` [INFO] [stderr] --> src/scanner.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use scanner::TokenParseResult::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `scanner::TokenParseResult::NoToken` [INFO] [stderr] --> src/scanner.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use scanner::TokenParseResult::NoToken; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return &self.tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `scanner::TokenParseResult::TokenFound` [INFO] [stderr] --> src/scanner.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use scanner::TokenParseResult::TokenFound; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `scanner::TokenParseResult::Error` [INFO] [stderr] --> src/scanner.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use scanner::TokenParseResult::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `scanner::TokenParseResult::NoToken` [INFO] [stderr] --> src/scanner.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use scanner::TokenParseResult::NoToken; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return &self.tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/scanner.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | self.errors.push(format!("Unknown error parsing number on line {}", self.line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scanner.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let mut temp_copy = self.source.clone(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scanner.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | let mut string_iter = [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scanner.rs:166:17 [INFO] [stderr] | [INFO] [stderr] warning: unreachable statement [INFO] [stderr] 166 | let mut string_iter = [INFO] [stderr] --> src/scanner.rs:182:9 [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] 182 | self.errors.push(format!("Unknown error parsing number on line {}", self.line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scanner.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let mut string_iter = [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `TokenParseResult` [INFO] [stderr] --> src/scanner.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | enum TokenParseResult { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/scanner.rs:39:8 [INFO] [stderr] | [INFO] [stderr] 39 | #[warn(dead_code)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:35:26 [INFO] [stderr] | [INFO] [stderr] 35 | fn run_file(source_file: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scanner.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let mut temp_copy = self.source.clone(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scanner.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | let mut string_iter = [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scanner.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | let mut string_iter = [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scanner.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let mut string_iter = [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `TokenParseResult` [INFO] [stderr] --> src/scanner.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | enum TokenParseResult { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/scanner.rs:39:8 [INFO] [stderr] | [INFO] [stderr] 39 | #[warn(dead_code)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:35:26 [INFO] [stderr] | [INFO] [stderr] 35 | fn run_file(source_file: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.77s [INFO] running `"docker" "inspect" "1fa43ac4d5f64ec43a65f49b8116721903cf059c0871b7107539a511d889f2d9"` [INFO] running `"docker" "rm" "-f" "1fa43ac4d5f64ec43a65f49b8116721903cf059c0871b7107539a511d889f2d9"` [INFO] [stdout] 1fa43ac4d5f64ec43a65f49b8116721903cf059c0871b7107539a511d889f2d9