[INFO] updating cached repository mcminis1/electron-gas-3d-hartree-fock-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mcminis1/electron-gas-3d-hartree-fock-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mcminis1/electron-gas-3d-hartree-fock-rust" "work/ex/clippy-test-run/sources/stable/gh/mcminis1/electron-gas-3d-hartree-fock-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mcminis1/electron-gas-3d-hartree-fock-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mcminis1/electron-gas-3d-hartree-fock-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcminis1/electron-gas-3d-hartree-fock-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcminis1/electron-gas-3d-hartree-fock-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d867a1415f30576623aa00995cb961e2ad5daba4 [INFO] sha for GitHub repo mcminis1/electron-gas-3d-hartree-fock-rust: d867a1415f30576623aa00995cb961e2ad5daba4 [INFO] validating manifest of mcminis1/electron-gas-3d-hartree-fock-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mcminis1/electron-gas-3d-hartree-fock-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mcminis1/electron-gas-3d-hartree-fock-rust [INFO] finished frobbing mcminis1/electron-gas-3d-hartree-fock-rust [INFO] frobbed toml for mcminis1/electron-gas-3d-hartree-fock-rust written to work/ex/clippy-test-run/sources/stable/gh/mcminis1/electron-gas-3d-hartree-fock-rust/Cargo.toml [INFO] started frobbing mcminis1/electron-gas-3d-hartree-fock-rust [INFO] finished frobbing mcminis1/electron-gas-3d-hartree-fock-rust [INFO] frobbed toml for mcminis1/electron-gas-3d-hartree-fock-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcminis1/electron-gas-3d-hartree-fock-rust/Cargo.toml [INFO] crate mcminis1/electron-gas-3d-hartree-fock-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mcminis1/electron-gas-3d-hartree-fock-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcminis1/electron-gas-3d-hartree-fock-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35e6f45f53482f00220acaf59baed0245fce170beaf92ceeb259137821414637 [INFO] running `"docker" "start" "-a" "35e6f45f53482f00220acaf59baed0245fce170beaf92ceeb259137821414637"` [INFO] [stderr] Checking electron-gas-3d-hartree-fock-rust v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | n_electrons: n_electrons, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n_electrons` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | k_pf: k_pf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `k_pf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | ee_pf: ee_pf, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ee_pf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | occ: occ [INFO] [stderr] | ^^^^^^^^ help: replace it with: `occ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | n_electrons: n_electrons, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n_electrons` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | kf:kf, [INFO] [stderr] | ^^^^^ help: replace it with: `kf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | k_pf: k_pf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `k_pf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | ee_pf: ee_pf, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ee_pf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | occ: occ [INFO] [stderr] | ^^^^^^^^ help: replace it with: `occ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | n_electrons: n_electrons, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n_electrons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | occ: occ [INFO] [stderr] | ^^^^^^^^ help: replace it with: `occ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | kf:kf, [INFO] [stderr] | ^^^^^ help: replace it with: `kf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | n_electrons: n_electrons, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n_electrons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | occ: occ [INFO] [stderr] | ^^^^^^^^ help: replace it with: `occ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return energy; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `energy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return energy; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `energy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | if ((x*x + y*y + z*z) as f64) < k2_max { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x*x + y*y + z*z)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | let volume = 4.0/3.0*PI*(n_electrons as f64)*r_s.powi(3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(n_electrons)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:46:30 [INFO] [stderr] | [INFO] [stderr] 46 | let kf = (3.0*PI.powi(2)*n_electrons as f64/volume).powf(1.0/3.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(n_electrons)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | k_pf: k_pf/n_electrons as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(n_electrons)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | ee_pf: ee_pf/n_electrons as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(n_electrons)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:15 [INFO] [stderr] | [INFO] [stderr] 62 | ke += (k_point.0.pow(2) + k_point.1.pow(2) + k_point.2.pow(2)) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(k_point.0.pow(2) + k_point.1.pow(2) + k_point.2.pow(2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | ee += ((dx2+dy2+dz2) as f64).powi(-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dx2+dy2+dz2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | if ((x*x + y*y + z*z) as f64) < k2_max { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x*x + y*y + z*z)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | let volume = 4.0/3.0*PI*(n_electrons as f64)*r_s.powi(3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(n_electrons)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:46:30 [INFO] [stderr] | [INFO] [stderr] 46 | let kf = (3.0*PI.powi(2)*n_electrons as f64/volume).powf(1.0/3.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(n_electrons)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | k_pf: k_pf/n_electrons as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(n_electrons)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | ee_pf: ee_pf/n_electrons as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(n_electrons)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:15 [INFO] [stderr] | [INFO] [stderr] 62 | ke += (k_point.0.pow(2) + k_point.1.pow(2) + k_point.2.pow(2)) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(k_point.0.pow(2) + k_point.1.pow(2) + k_point.2.pow(2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | ee += ((dx2+dy2+dz2) as f64).powi(-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dx2+dy2+dz2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `"docker" "inspect" "35e6f45f53482f00220acaf59baed0245fce170beaf92ceeb259137821414637"` [INFO] running `"docker" "rm" "-f" "35e6f45f53482f00220acaf59baed0245fce170beaf92ceeb259137821414637"` [INFO] [stdout] 35e6f45f53482f00220acaf59baed0245fce170beaf92ceeb259137821414637