[INFO] updating cached repository mclark4386/formula-fib [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mclark4386/formula-fib [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mclark4386/formula-fib" "work/ex/clippy-test-run/sources/stable/gh/mclark4386/formula-fib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mclark4386/formula-fib'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mclark4386/formula-fib" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mclark4386/formula-fib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mclark4386/formula-fib'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b64ceff603f1df2dbd1fcb4c9714d6ba576dbe68 [INFO] sha for GitHub repo mclark4386/formula-fib: b64ceff603f1df2dbd1fcb4c9714d6ba576dbe68 [INFO] validating manifest of mclark4386/formula-fib on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mclark4386/formula-fib on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mclark4386/formula-fib [INFO] finished frobbing mclark4386/formula-fib [INFO] frobbed toml for mclark4386/formula-fib written to work/ex/clippy-test-run/sources/stable/gh/mclark4386/formula-fib/Cargo.toml [INFO] started frobbing mclark4386/formula-fib [INFO] finished frobbing mclark4386/formula-fib [INFO] frobbed toml for mclark4386/formula-fib written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mclark4386/formula-fib/Cargo.toml [INFO] crate mclark4386/formula-fib has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mclark4386/formula-fib against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mclark4386/formula-fib:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ab7b6afa57466b81399aac477f2111bd3f5e5c118841f8ad5c074cef4b632193 [INFO] running `"docker" "start" "-a" "ab7b6afa57466b81399aac477f2111bd3f5e5c118841f8ad5c074cef4b632193"` [INFO] [stderr] Checking formula-fib v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return (((0.5) * (1.0 + (5.0 as f64).sqrt())).powf(n as f64)/(5.0 as f64).sqrt()).max(std::i64::MIN as f64).min(std::i64::MAX as f64).round() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(((0.5) * (1.0 + (5.0 as f64).sqrt())).powf(n as f64)/(5.0 as f64).sqrt()).max(std::i64::MIN as f64).min(std::i64::MAX as f64).round() as i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return s == "quit" || s == "q" || s == "exit"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s == "quit" || s == "q" || s == "exit"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return (((0.5) * (1.0 + (5.0 as f64).sqrt())).powf(n as f64)/(5.0 as f64).sqrt()).max(std::i64::MIN as f64).min(std::i64::MAX as f64).round() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(((0.5) * (1.0 + (5.0 as f64).sqrt())).powf(n as f64)/(5.0 as f64).sqrt()).max(std::i64::MIN as f64).min(std::i64::MAX as f64).round() as i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return s == "quit" || s == "q" || s == "exit"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s == "quit" || s == "q" || s == "exit"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | fn should_quit(s: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | fn should_quit(s: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.30s [INFO] running `"docker" "inspect" "ab7b6afa57466b81399aac477f2111bd3f5e5c118841f8ad5c074cef4b632193"` [INFO] running `"docker" "rm" "-f" "ab7b6afa57466b81399aac477f2111bd3f5e5c118841f8ad5c074cef4b632193"` [INFO] [stdout] ab7b6afa57466b81399aac477f2111bd3f5e5c118841f8ad5c074cef4b632193