[INFO] updating cached repository mcgoddard/challenge_271_critical_hit
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mcgoddard/challenge_271_critical_hit
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mcgoddard/challenge_271_critical_hit" "work/ex/clippy-test-run/sources/stable/gh/mcgoddard/challenge_271_critical_hit"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mcgoddard/challenge_271_critical_hit'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mcgoddard/challenge_271_critical_hit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcgoddard/challenge_271_critical_hit"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcgoddard/challenge_271_critical_hit'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ba5a920944aaba2b277dab8292084ad680562dc4
[INFO] sha for GitHub repo mcgoddard/challenge_271_critical_hit: ba5a920944aaba2b277dab8292084ad680562dc4
[INFO] validating manifest of mcgoddard/challenge_271_critical_hit on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mcgoddard/challenge_271_critical_hit on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mcgoddard/challenge_271_critical_hit
[INFO] finished frobbing mcgoddard/challenge_271_critical_hit
[INFO] frobbed toml for mcgoddard/challenge_271_critical_hit written to work/ex/clippy-test-run/sources/stable/gh/mcgoddard/challenge_271_critical_hit/Cargo.toml
[INFO] started frobbing mcgoddard/challenge_271_critical_hit
[INFO] finished frobbing mcgoddard/challenge_271_critical_hit
[INFO] frobbed toml for mcgoddard/challenge_271_critical_hit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcgoddard/challenge_271_critical_hit/Cargo.toml
[INFO] crate mcgoddard/challenge_271_critical_hit has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mcgoddard/challenge_271_critical_hit against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcgoddard/challenge_271_critical_hit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b5831b03c2577972e252609edce2b595d28cf15581ae87b1758f56a1631f6e5c
[INFO] running `"docker" "start" "-a" "b5831b03c2577972e252609edce2b595d28cf15581ae87b1758f56a1631f6e5c"`
[INFO] [stderr]     Checking challenge_271_critical_hit v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:29:3
[INFO] [stderr]    |
[INFO] [stderr] 29 |         return ((df + (1 as f64)) - hf) / df;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((df + (1 as f64)) - hf) / df`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:33:6
[INFO] [stderr]    |
[INFO] [stderr] 33 |         return recursive_find(d, h - d) / df;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `recursive_find(d, h - d) / df`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:29:3
[INFO] [stderr]    |
[INFO] [stderr] 29 |         return ((df + (1 as f64)) - hf) / df;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((df + (1 as f64)) - hf) / df`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:33:6
[INFO] [stderr]    |
[INFO] [stderr] 33 |         return recursive_find(d, h - d) / df;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `recursive_find(d, h - d) / df`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:11:7
[INFO] [stderr]    |
[INFO] [stderr] 11 |             Err(_) => panic!("Sides was not a positive number!"),
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:16:7
[INFO] [stderr]    |
[INFO] [stderr] 16 |             Err(_) => panic!("Hitpoints was not a positive number!"),
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:27:12
[INFO] [stderr]    |
[INFO] [stderr] 27 |         let df = d as f64;
[INFO] [stderr]    |                  ^^^^^^^^ help: try: `f64::from(d)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:28:12
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let hf = h as f64;
[INFO] [stderr]    |                  ^^^^^^^^ help: try: `f64::from(h)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:29:17
[INFO] [stderr]    |
[INFO] [stderr] 29 |         return ((df + (1 as f64)) - hf) / df;
[INFO] [stderr]    |                       ^^^^^^^^^^ help: try: `f64::from(1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:32:12
[INFO] [stderr]    |
[INFO] [stderr] 32 |         let df = d as f64;
[INFO] [stderr]    |                  ^^^^^^^^ help: try: `f64::from(d)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:11:7
[INFO] [stderr]    |
[INFO] [stderr] 11 |             Err(_) => panic!("Sides was not a positive number!"),
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:16:7
[INFO] [stderr]    |
[INFO] [stderr] 16 |             Err(_) => panic!("Hitpoints was not a positive number!"),
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:27:12
[INFO] [stderr]    |
[INFO] [stderr] 27 |         let df = d as f64;
[INFO] [stderr]    |                  ^^^^^^^^ help: try: `f64::from(d)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:28:12
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let hf = h as f64;
[INFO] [stderr]    |                  ^^^^^^^^ help: try: `f64::from(h)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:29:17
[INFO] [stderr]    |
[INFO] [stderr] 29 |         return ((df + (1 as f64)) - hf) / df;
[INFO] [stderr]    |                       ^^^^^^^^^^ help: try: `f64::from(1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:32:12
[INFO] [stderr]    |
[INFO] [stderr] 32 |         let df = d as f64;
[INFO] [stderr]    |                  ^^^^^^^^ help: try: `f64::from(d)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.28s
[INFO] running `"docker" "inspect" "b5831b03c2577972e252609edce2b595d28cf15581ae87b1758f56a1631f6e5c"`
[INFO] running `"docker" "rm" "-f" "b5831b03c2577972e252609edce2b595d28cf15581ae87b1758f56a1631f6e5c"`
[INFO] [stdout] b5831b03c2577972e252609edce2b595d28cf15581ae87b1758f56a1631f6e5c