[INFO] updating cached repository mcast/markdown-chapterise [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mcast/markdown-chapterise [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mcast/markdown-chapterise" "work/ex/clippy-test-run/sources/stable/gh/mcast/markdown-chapterise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mcast/markdown-chapterise'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mcast/markdown-chapterise" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcast/markdown-chapterise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcast/markdown-chapterise'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 926d91dc2a2179caeb61f32d4e76de4ea5b1eebd [INFO] sha for GitHub repo mcast/markdown-chapterise: 926d91dc2a2179caeb61f32d4e76de4ea5b1eebd [INFO] validating manifest of mcast/markdown-chapterise on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mcast/markdown-chapterise on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mcast/markdown-chapterise [INFO] finished frobbing mcast/markdown-chapterise [INFO] frobbed toml for mcast/markdown-chapterise written to work/ex/clippy-test-run/sources/stable/gh/mcast/markdown-chapterise/Cargo.toml [INFO] started frobbing mcast/markdown-chapterise [INFO] finished frobbing mcast/markdown-chapterise [INFO] frobbed toml for mcast/markdown-chapterise written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcast/markdown-chapterise/Cargo.toml [INFO] crate mcast/markdown-chapterise has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mcast/markdown-chapterise against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcast/markdown-chapterise:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac6049cbf3abc63c987486d9e0dadc2beb3bfb899180d689dc74d0d296b8e7d1 [INFO] running `"docker" "start" "-a" "ac6049cbf3abc63c987486d9e0dadc2beb3bfb899180d689dc74d0d296b8e7d1"` [INFO] [stderr] Checking markdown-chapterise v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mdslurp.rs:49:49 [INFO] [stderr] | [INFO] [stderr] 49 | n => MarkdownEle::Head { txt: line, n: n }, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mdout.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | outdir: outdir, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `outdir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mdout.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | filenum: filenum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `filenum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mdout.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | outpath: outpath, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `outpath` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mdout.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | tmppath: tmppath, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tmppath` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mdslurp.rs:49:49 [INFO] [stderr] | [INFO] [stderr] 49 | n => MarkdownEle::Head { txt: line, n: n }, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mdout.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | outdir: outdir, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `outdir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mdout.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | filenum: filenum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `filenum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mdout.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | outpath: outpath, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `outpath` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mdout.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | tmppath: tmppath, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tmppath` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/mdstream.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::FilterMap` [INFO] [stderr] --> src/mdstream.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::iter::FilterMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Lines` [INFO] [stderr] --> src/mdstream.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::Lines; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/mdstream.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/mdstream.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/mdstream.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/mdstream.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | let out = MarkdownStream { input: Box::new(lines.peekable()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/mdstream.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::FilterMap` [INFO] [stderr] --> src/mdstream.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::iter::FilterMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Lines` [INFO] [stderr] --> src/mdstream.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::Lines; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/mdstream.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/mdstream.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/mdstream.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/mdstream.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | let out = MarkdownStream { input: Box::new(lines.peekable()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `obj` [INFO] [stderr] --> src/main.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | let obj = "bar"; [INFO] [stderr] | ^^^ help: consider using `_obj` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/mdstream.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let mut lines = self.input.deref_mut(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/mdstream.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(lines: Box>) -> MarkdownStream [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/mdslurp.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match next { [INFO] [stderr] 23 | | Some(t) => { [INFO] [stderr] 24 | | let mut num_minus = 0; [INFO] [stderr] 25 | | let mut num_equ = 0; [INFO] [stderr] ... | [INFO] [stderr] 45 | | None => (), [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | if let Some(t) = next { [INFO] [stderr] 23 | let mut num_minus = 0; [INFO] [stderr] 24 | let mut num_equ = 0; [INFO] [stderr] 25 | for ch in t.chars() { [INFO] [stderr] 26 | match ch { [INFO] [stderr] 27 | '-' => num_minus += 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/mdstream.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let mut lines = self.input.deref_mut(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/mdslurp.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match next { [INFO] [stderr] 23 | | Some(t) => { [INFO] [stderr] 24 | | let mut num_minus = 0; [INFO] [stderr] 25 | | let mut num_equ = 0; [INFO] [stderr] ... | [INFO] [stderr] 45 | | None => (), [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | if let Some(t) = next { [INFO] [stderr] 23 | let mut num_minus = 0; [INFO] [stderr] 24 | let mut num_equ = 0; [INFO] [stderr] 25 | for ch in t.chars() { [INFO] [stderr] 26 | match ch { [INFO] [stderr] 27 | '-' => num_minus += 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | let infile = args.next().expect(& format!("Syntax: {} [ ]", prog)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax: {} [ ]", prog))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | let infile = args.next().expect(& format!("Syntax: {} [ ]", prog)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax: {} [ ]", prog))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.39s [INFO] running `"docker" "inspect" "ac6049cbf3abc63c987486d9e0dadc2beb3bfb899180d689dc74d0d296b8e7d1"` [INFO] running `"docker" "rm" "-f" "ac6049cbf3abc63c987486d9e0dadc2beb3bfb899180d689dc74d0d296b8e7d1"` [INFO] [stdout] ac6049cbf3abc63c987486d9e0dadc2beb3bfb899180d689dc74d0d296b8e7d1