[INFO] updating cached repository mbuffa/hellorust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mbuffa/hellorust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mbuffa/hellorust" "work/ex/clippy-test-run/sources/stable/gh/mbuffa/hellorust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mbuffa/hellorust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mbuffa/hellorust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mbuffa/hellorust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mbuffa/hellorust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3b1d685e7018b870560ab5cd67685e4af9b6db80 [INFO] sha for GitHub repo mbuffa/hellorust: 3b1d685e7018b870560ab5cd67685e4af9b6db80 [INFO] validating manifest of mbuffa/hellorust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mbuffa/hellorust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mbuffa/hellorust [INFO] finished frobbing mbuffa/hellorust [INFO] frobbed toml for mbuffa/hellorust written to work/ex/clippy-test-run/sources/stable/gh/mbuffa/hellorust/Cargo.toml [INFO] started frobbing mbuffa/hellorust [INFO] finished frobbing mbuffa/hellorust [INFO] frobbed toml for mbuffa/hellorust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mbuffa/hellorust/Cargo.toml [INFO] crate mbuffa/hellorust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mbuffa/hellorust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mbuffa/hellorust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cbaf4a75abb4c3d28cac03169b6256e525927d316427f51cd2ae368a7c649b10 [INFO] running `"docker" "start" "-a" "cbaf4a75abb4c3d28cac03169b6256e525927d316427f51cd2ae368a7c649b10"` [INFO] [stderr] Checking hellorust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/app/states/initializing.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn on_enter(ctx: &mut AppContext) { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/app/states/initializing.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn on_leave(ctx: &mut AppContext) { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/app/states/playing.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn on_enter(ctx: &mut AppContext) { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/app/states/playing.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn on_leave(ctx: &mut AppContext) { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `app::context::AppContext` [INFO] [stderr] --> src/app/context.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> AppContext { [INFO] [stderr] 14 | | let mut ctx = AppContext { [INFO] [stderr] 15 | | current: AppState::Initializing, [INFO] [stderr] 16 | | update_fn: Some(initializing::update), [INFO] [stderr] ... | [INFO] [stderr] 21 | | ctx [INFO] [stderr] 22 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/app/states/initializing.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn on_enter(ctx: &mut AppContext) { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/app/states/initializing.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn on_leave(ctx: &mut AppContext) { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/app/states/playing.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn on_enter(ctx: &mut AppContext) { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/app/states/playing.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn on_leave(ctx: &mut AppContext) { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for app::context::AppContext { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `app::context::AppContext` [INFO] [stderr] --> src/app/context.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> AppContext { [INFO] [stderr] 14 | | let mut ctx = AppContext { [INFO] [stderr] 15 | | current: AppState::Initializing, [INFO] [stderr] 16 | | update_fn: Some(initializing::update), [INFO] [stderr] ... | [INFO] [stderr] 21 | | ctx [INFO] [stderr] 22 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for app::context::AppContext { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.60s [INFO] running `"docker" "inspect" "cbaf4a75abb4c3d28cac03169b6256e525927d316427f51cd2ae368a7c649b10"` [INFO] running `"docker" "rm" "-f" "cbaf4a75abb4c3d28cac03169b6256e525927d316427f51cd2ae368a7c649b10"` [INFO] [stdout] cbaf4a75abb4c3d28cac03169b6256e525927d316427f51cd2ae368a7c649b10