[INFO] updating cached repository mattyw/rust-udp-play [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mattyw/rust-udp-play [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mattyw/rust-udp-play" "work/ex/clippy-test-run/sources/stable/gh/mattyw/rust-udp-play"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mattyw/rust-udp-play'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mattyw/rust-udp-play" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattyw/rust-udp-play"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattyw/rust-udp-play'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0adcf9c2b65f1ad7c3d2ad2e317420338960483c [INFO] sha for GitHub repo mattyw/rust-udp-play: 0adcf9c2b65f1ad7c3d2ad2e317420338960483c [INFO] validating manifest of mattyw/rust-udp-play on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mattyw/rust-udp-play on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mattyw/rust-udp-play [INFO] finished frobbing mattyw/rust-udp-play [INFO] frobbed toml for mattyw/rust-udp-play written to work/ex/clippy-test-run/sources/stable/gh/mattyw/rust-udp-play/Cargo.toml [INFO] started frobbing mattyw/rust-udp-play [INFO] finished frobbing mattyw/rust-udp-play [INFO] frobbed toml for mattyw/rust-udp-play written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattyw/rust-udp-play/Cargo.toml [INFO] crate mattyw/rust-udp-play has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mattyw/rust-udp-play against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattyw/rust-udp-play:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4edaf784b767efcb6b8aabd90b26ae0905f5f45a89d9d4cb28193bf9c71e1024 [INFO] running `"docker" "start" "-a" "4edaf784b767efcb6b8aabd90b26ae0905f5f45a89d9d4cb28193bf9c71e1024"` [INFO] [stderr] Checking hello v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Receiver`, `Sender` [INFO] [stderr] --> src/main.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | use std::sync::mpsc::{Sender, Receiver}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::sync::mpsc; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | for i in 0..50 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `listen_on` [INFO] [stderr] --> src/main.rs:37:52 [INFO] [stderr] | [INFO] [stderr] 37 | fn listen(server_name: &str, sock: net::UdpSocket, listen_on: net::SocketAddr) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_listen_on` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let mut socket; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `Sender` [INFO] [stderr] --> src/main.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | use std::sync::mpsc::{Sender, Receiver}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::sync::mpsc; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_to` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | match socket.send_to(&mut &buf[0..x], addr) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | sock.send_to(&msg, addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | drop(socket); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type fn(std::net::SocketAddr) -> std::net::UdpSocket {socket} [INFO] [stderr] --> src/main.rs:54:10 [INFO] [stderr] | [INFO] [stderr] 54 | drop(socket); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hello`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | for i in 0..50 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `listen_on` [INFO] [stderr] --> src/main.rs:37:52 [INFO] [stderr] | [INFO] [stderr] 37 | fn listen(server_name: &str, sock: net::UdpSocket, listen_on: net::SocketAddr) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_listen_on` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let mut socket; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_to` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | match socket.send_to(&mut &buf[0..x], addr) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | sock.send_to(&msg, addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | drop(socket); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type fn(std::net::SocketAddr) -> std::net::UdpSocket {socket} [INFO] [stderr] --> src/main.rs:54:10 [INFO] [stderr] | [INFO] [stderr] 54 | drop(socket); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hello`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4edaf784b767efcb6b8aabd90b26ae0905f5f45a89d9d4cb28193bf9c71e1024"` [INFO] running `"docker" "rm" "-f" "4edaf784b767efcb6b8aabd90b26ae0905f5f45a89d9d4cb28193bf9c71e1024"` [INFO] [stdout] 4edaf784b767efcb6b8aabd90b26ae0905f5f45a89d9d4cb28193bf9c71e1024