[INFO] updating cached repository mattrayner/learning-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mattrayner/learning-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mattrayner/learning-rust" "work/ex/clippy-test-run/sources/stable/gh/mattrayner/learning-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mattrayner/learning-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mattrayner/learning-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattrayner/learning-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattrayner/learning-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 76a51d5948e6b4b3829eb649b52bf0496266591f [INFO] sha for GitHub repo mattrayner/learning-rust: 76a51d5948e6b4b3829eb649b52bf0496266591f [INFO] validating manifest of mattrayner/learning-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mattrayner/learning-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mattrayner/learning-rust [INFO] finished frobbing mattrayner/learning-rust [INFO] frobbed toml for mattrayner/learning-rust written to work/ex/clippy-test-run/sources/stable/gh/mattrayner/learning-rust/Cargo.toml [INFO] started frobbing mattrayner/learning-rust [INFO] finished frobbing mattrayner/learning-rust [INFO] frobbed toml for mattrayner/learning-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattrayner/learning-rust/Cargo.toml [INFO] crate mattrayner/learning-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mattrayner/learning-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattrayner/learning-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8add6efe547cb2175f14d572fc0c2f7a525df3b6c0c9be3188d8c2621d9a7029 [INFO] running `"docker" "start" "-a" "8add6efe547cb2175f14d572fc0c2f7a525df3b6c0c9be3188d8c2621d9a7029"` [INFO] [stderr] Checking libc v0.2.38 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking learning-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/data_structures/mod.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | let ((c,d), (e,f)) = combined; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/data_structures/mod.rs:252:11 [INFO] [stderr] | [INFO] [stderr] 252 | let ((c,d), (e,f)) = combined; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/data_structures/mod.rs:252:16 [INFO] [stderr] | [INFO] [stderr] 252 | let ((c,d), (e,f)) = combined; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/data_structures/mod.rs:252:18 [INFO] [stderr] | [INFO] [stderr] 252 | let ((c,d), (e,f)) = combined; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/functions.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | println!("{} + 2 = {}", 7, plus_two(7)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/traits.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | Human { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/traits.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | Cat { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | let d:char = 'x'; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:42:7 [INFO] [stderr] | [INFO] [stderr] 42 | let e = 2.5; // double-precision, 8 bytes, or 64 bits, f64 - can also be f32 for smaller memory usage [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | let f = false; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | let g = 4>0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:62:44 [INFO] [stderr] | [INFO] [stderr] 62 | println!("remainder of {} / {} = {}", a, 3, (a%3)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/data_structures/mod.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | let ((c,d), (e,f)) = combined; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/data_structures/mod.rs:252:11 [INFO] [stderr] | [INFO] [stderr] 252 | let ((c,d), (e,f)) = combined; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/data_structures/mod.rs:252:16 [INFO] [stderr] | [INFO] [stderr] 252 | let ((c,d), (e,f)) = combined; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/data_structures/mod.rs:252:18 [INFO] [stderr] | [INFO] [stderr] 252 | let ((c,d), (e,f)) = combined; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/functions.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | println!("{} + 2 = {}", 7, plus_two(7)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/traits.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | Human { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/traits.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | Cat { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | let d:char = 'x'; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:42:7 [INFO] [stderr] | [INFO] [stderr] 42 | let e = 2.5; // double-precision, 8 bytes, or 64 bits, f64 - can also be f32 for smaller memory usage [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | let f = false; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | let g = 4>0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:62:44 [INFO] [stderr] | [INFO] [stderr] 62 | println!("remainder of {} / {} = {}", a, 3, (a%3)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/data_structures/pattern_matching.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | RgbColour(u8, u8, u8), // tuple [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/data_structures/pattern_matching.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / CmykColour{ [INFO] [stderr] 37 | | cyan: u8, [INFO] [stderr] 38 | | magenta: u8, [INFO] [stderr] 39 | | yellow: u8, [INFO] [stderr] 40 | | black: u8 [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/data_structures/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | RgbColour(u8, u8, u8), // tuple [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/data_structures/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / CmykColour{ [INFO] [stderr] 32 | | cyan: u8, [INFO] [stderr] 33 | | magenta: u8, [INFO] [stderr] 34 | | yellow: u8, [INFO] [stderr] 35 | | black: u8 [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/data_structures/mod.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | Colour::CmykColour { cyan: _, magenta: _, yellow: _, black: 255 } => println!("black"), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/data_structures/mod.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | Colour::CmykColour { cyan: _, magenta: _, yellow: _, black: 255 } => println!("black"), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/data_structures/mod.rs:47:47 [INFO] [stderr] | [INFO] [stderr] 47 | Colour::CmykColour { cyan: _, magenta: _, yellow: _, black: 255 } => println!("black"), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CmykColour { black: 255, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | let mut c = 123456789; //32-bit signed i32 [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | c = -123456789; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/data_structures/pattern_matching.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | RgbColour(u8, u8, u8), // tuple [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/data_structures/pattern_matching.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / CmykColour{ [INFO] [stderr] 37 | | cyan: u8, [INFO] [stderr] 38 | | magenta: u8, [INFO] [stderr] 39 | | yellow: u8, [INFO] [stderr] 40 | | black: u8 [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/data_structures/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | RgbColour(u8, u8, u8), // tuple [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/data_structures/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / CmykColour{ [INFO] [stderr] 32 | | cyan: u8, [INFO] [stderr] 33 | | magenta: u8, [INFO] [stderr] 34 | | yellow: u8, [INFO] [stderr] 35 | | black: u8 [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/data_structures/mod.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | Colour::CmykColour { cyan: _, magenta: _, yellow: _, black: 255 } => println!("black"), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/data_structures/mod.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | Colour::CmykColour { cyan: _, magenta: _, yellow: _, black: 255 } => println!("black"), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/data_structures/mod.rs:47:47 [INFO] [stderr] | [INFO] [stderr] 47 | Colour::CmykColour { cyan: _, magenta: _, yellow: _, black: 255 } => println!("black"), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CmykColour { black: 255, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | let mut c = 123456789; //32-bit signed i32 [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | c = -123456789; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/control_flow.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | 1...999 => "unknown", // A range with three dots is INCLUSIVE of the right hand side [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/control_flow.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | 7 => "Russia", [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/control_flow.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | 1...999 => "unknown", // A range with three dots is INCLUSIVE of the right hand side [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/control_flow.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | 7 => "Russia", [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `b` [INFO] [stderr] --> src/data_structures/mod.rs:119:12 [INFO] [stderr] | [INFO] [stderr] 119 | for i in 0..b.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 119 | for (i, ) in b.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `mtx` [INFO] [stderr] --> src/data_structures/mod.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | for i in 0..mtx.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 131 | for (i, ) in mtx.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/data_structures/mod.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | / match a.pop() { // returns an Option [INFO] [stderr] 164 | | Some(x) => println!("Popped {:?} from a, a = {:?}", x, a), [INFO] [stderr] 165 | | _ => {} [INFO] [stderr] 166 | | } [INFO] [stderr] | |___^ help: try this: `if let Some(x) = a.pop() { println!("Popped {:?} from a, a = {:?}", x, a) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/data_structures/mod.rs:206:15 [INFO] [stderr] | [INFO] [stderr] 206 | let mut a = 'a' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/data_structures/mod.rs:207:14 [INFO] [stderr] | [INFO] [stderr] 207 | while a <= ('z' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/data_structures/mod.rs:255:7 [INFO] [stderr] | [INFO] [stderr] 255 | let foo = (true, 42.0, -1i8); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functions.rs:118:31 [INFO] [stderr] | [INFO] [stderr] 118 | .filter(|x| is_even(*x)) [INFO] [stderr] | _______________________________^ [INFO] [stderr] 119 | | .fold(0, |sum, x| sum + x); [INFO] [stderr] | |________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `b` [INFO] [stderr] --> src/data_structures/mod.rs:119:12 [INFO] [stderr] | [INFO] [stderr] 119 | for i in 0..b.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 119 | for (i, ) in b.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `mtx` [INFO] [stderr] --> src/data_structures/mod.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | for i in 0..mtx.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 131 | for (i, ) in mtx.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/data_structures/mod.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | / match a.pop() { // returns an Option [INFO] [stderr] 164 | | Some(x) => println!("Popped {:?} from a, a = {:?}", x, a), [INFO] [stderr] 165 | | _ => {} [INFO] [stderr] 166 | | } [INFO] [stderr] | |___^ help: try this: `if let Some(x) = a.pop() { println!("Popped {:?} from a, a = {:?}", x, a) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/data_structures/mod.rs:206:15 [INFO] [stderr] | [INFO] [stderr] 206 | let mut a = 'a' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/data_structures/mod.rs:207:14 [INFO] [stderr] | [INFO] [stderr] 207 | while a <= ('z' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | a = a+1; // -- and ++ are not supported in Rust [INFO] [stderr] | ^^^^^^^ help: replace it with: `a += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/data_structures/mod.rs:255:7 [INFO] [stderr] | [INFO] [stderr] 255 | let foo = (true, 42.0, -1i8); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functions.rs:118:31 [INFO] [stderr] | [INFO] [stderr] 118 | .filter(|x| is_even(*x)) [INFO] [stderr] | _______________________________^ [INFO] [stderr] 119 | | .fold(0, |sum, x| sum + x); [INFO] [stderr] | |________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | a = a+1; // -- and ++ are not supported in Rust [INFO] [stderr] | ^^^^^^^ help: replace it with: `a += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.53s [INFO] running `"docker" "inspect" "8add6efe547cb2175f14d572fc0c2f7a525df3b6c0c9be3188d8c2621d9a7029"` [INFO] running `"docker" "rm" "-f" "8add6efe547cb2175f14d572fc0c2f7a525df3b6c0c9be3188d8c2621d9a7029"` [INFO] [stdout] 8add6efe547cb2175f14d572fc0c2f7a525df3b6c0c9be3188d8c2621d9a7029