[INFO] updating cached repository matthewlujp/logview
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/matthewlujp/logview
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/matthewlujp/logview" "work/ex/clippy-test-run/sources/stable/gh/matthewlujp/logview"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matthewlujp/logview'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/matthewlujp/logview" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthewlujp/logview"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthewlujp/logview'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ed415917c6c3512fc9105dc215493be7a54d0859
[INFO] sha for GitHub repo matthewlujp/logview: ed415917c6c3512fc9105dc215493be7a54d0859
[INFO] validating manifest of matthewlujp/logview on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of matthewlujp/logview on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing matthewlujp/logview
[INFO] finished frobbing matthewlujp/logview
[INFO] frobbed toml for matthewlujp/logview written to work/ex/clippy-test-run/sources/stable/gh/matthewlujp/logview/Cargo.toml
[INFO] started frobbing matthewlujp/logview
[INFO] finished frobbing matthewlujp/logview
[INFO] frobbed toml for matthewlujp/logview written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthewlujp/logview/Cargo.toml
[INFO] crate matthewlujp/logview has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting matthewlujp/logview against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthewlujp/logview:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 41befc66871aff91f01ea6181bcce433f71f9cddbd650d3d08c3c1ddd32942ed
[INFO] running `"docker" "start" "-a" "41befc66871aff91f01ea6181bcce433f71f9cddbd650d3d08c3c1ddd32942ed"`
[INFO] [stderr]     Checking clap v2.27.1
[INFO] [stderr]     Checking logview v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     return cleansed_path;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cleansed_path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]  --> src/main.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use std::env::home_dir;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:28:11
[INFO] [stderr]    |
[INFO] [stderr] 28 |     match home_dir() {
[INFO] [stderr]    |           ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:40:11
[INFO] [stderr]    |
[INFO] [stderr] 40 |     match home_dir() {
[INFO] [stderr]    |           ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     return cleansed_path;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cleansed_path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]  --> src/main.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use std::env::home_dir;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:28:11
[INFO] [stderr]    |
[INFO] [stderr] 28 |     match home_dir() {
[INFO] [stderr]    |           ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:40:11
[INFO] [stderr]    |
[INFO] [stderr] 40 |     match home_dir() {
[INFO] [stderr]    |           ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     match matches.subcommand_matches("start") {
[INFO] [stderr] 17 | |         Some(_) => start_logging(),
[INFO] [stderr] 18 | |         None => {},
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Some(_) = matches.subcommand_matches("start") { start_logging() }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     match matches.subcommand_matches("history") {
[INFO] [stderr] 22 | |         Some(_) => show_history(),
[INFO] [stderr] 23 | |         None => {},
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Some(_) = matches.subcommand_matches("history") { show_history() }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 | /     match home_dir() {
[INFO] [stderr] 29 | |         Some(mut path) => {
[INFO] [stderr] 30 | |             path.push(LOG_FILE_NAME);
[INFO] [stderr] 31 | |             let log_path = path.to_str().unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |         None => {},
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 28 |     if let Some(mut path) = home_dir() {
[INFO] [stderr] 29 |     path.push(LOG_FILE_NAME);
[INFO] [stderr] 30 |     let log_path = path.to_str().unwrap();
[INFO] [stderr] 31 |     Command::new("script").arg(log_path).status().unwrap();
[INFO] [stderr] 32 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     match home_dir() {
[INFO] [stderr] 41 | |         Some(mut path) => {
[INFO] [stderr] 42 | |             path.push(LOG_FILE_NAME);
[INFO] [stderr] 43 | |             if !path.exists() {
[INFO] [stderr] ...  |
[INFO] [stderr] 50 | |         None => {},
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 40 |     if let Some(mut path) = home_dir() {
[INFO] [stderr] 41 |     path.push(LOG_FILE_NAME);
[INFO] [stderr] 42 |     if !path.exists() {
[INFO] [stderr] 43 |         return;
[INFO] [stderr] 44 |     }
[INFO] [stderr] 45 |     let log_path = path.to_str().unwrap();
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     match matches.subcommand_matches("start") {
[INFO] [stderr] 17 | |         Some(_) => start_logging(),
[INFO] [stderr] 18 | |         None => {},
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Some(_) = matches.subcommand_matches("start") { start_logging() }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     match matches.subcommand_matches("history") {
[INFO] [stderr] 22 | |         Some(_) => show_history(),
[INFO] [stderr] 23 | |         None => {},
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Some(_) = matches.subcommand_matches("history") { show_history() }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 | /     match home_dir() {
[INFO] [stderr] 29 | |         Some(mut path) => {
[INFO] [stderr] 30 | |             path.push(LOG_FILE_NAME);
[INFO] [stderr] 31 | |             let log_path = path.to_str().unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |         None => {},
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 28 |     if let Some(mut path) = home_dir() {
[INFO] [stderr] 29 |     path.push(LOG_FILE_NAME);
[INFO] [stderr] 30 |     let log_path = path.to_str().unwrap();
[INFO] [stderr] 31 |     Command::new("script").arg(log_path).status().unwrap();
[INFO] [stderr] 32 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     match home_dir() {
[INFO] [stderr] 41 | |         Some(mut path) => {
[INFO] [stderr] 42 | |             path.push(LOG_FILE_NAME);
[INFO] [stderr] 43 | |             if !path.exists() {
[INFO] [stderr] ...  |
[INFO] [stderr] 50 | |         None => {},
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 40 |     if let Some(mut path) = home_dir() {
[INFO] [stderr] 41 |     path.push(LOG_FILE_NAME);
[INFO] [stderr] 42 |     if !path.exists() {
[INFO] [stderr] 43 |         return;
[INFO] [stderr] 44 |     }
[INFO] [stderr] 45 |     let log_path = path.to_str().unwrap();
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.51s
[INFO] running `"docker" "inspect" "41befc66871aff91f01ea6181bcce433f71f9cddbd650d3d08c3c1ddd32942ed"`
[INFO] running `"docker" "rm" "-f" "41befc66871aff91f01ea6181bcce433f71f9cddbd650d3d08c3c1ddd32942ed"`
[INFO] [stdout] 41befc66871aff91f01ea6181bcce433f71f9cddbd650d3d08c3c1ddd32942ed