[INFO] updating cached repository matthewdippel/quickalias [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/matthewdippel/quickalias [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/matthewdippel/quickalias" "work/ex/clippy-test-run/sources/stable/gh/matthewdippel/quickalias"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matthewdippel/quickalias'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/matthewdippel/quickalias" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthewdippel/quickalias"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthewdippel/quickalias'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0f6e814f172e47892efe25191e858018239f7edc [INFO] sha for GitHub repo matthewdippel/quickalias: 0f6e814f172e47892efe25191e858018239f7edc [INFO] validating manifest of matthewdippel/quickalias on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of matthewdippel/quickalias on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing matthewdippel/quickalias [INFO] finished frobbing matthewdippel/quickalias [INFO] frobbed toml for matthewdippel/quickalias written to work/ex/clippy-test-run/sources/stable/gh/matthewdippel/quickalias/Cargo.toml [INFO] started frobbing matthewdippel/quickalias [INFO] finished frobbing matthewdippel/quickalias [INFO] frobbed toml for matthewdippel/quickalias written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthewdippel/quickalias/Cargo.toml [INFO] crate matthewdippel/quickalias has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting matthewdippel/quickalias against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matthewdippel/quickalias:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 377fe58e2476951163ad9fe02ead3290672aac5aeaee40c188f181d6b41683d8 [INFO] running `"docker" "start" "-a" "377fe58e2476951163ad9fe02ead3290672aac5aeaee40c188f181d6b41683d8"` [INFO] [stderr] Checking tempfile v3.0.2 [INFO] [stderr] Checking quick_alias v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aliases.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | config_location: config_location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_location` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/aliases.rs:10:11 [INFO] [stderr] | [INFO] [stderr] 10 | match std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/aliases.rs:18:11 [INFO] [stderr] | [INFO] [stderr] 18 | match std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/aliases.rs:69:43 [INFO] [stderr] | [INFO] [stderr] 69 | let mut split_eq = rest.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/aliases.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / format!( [INFO] [stderr] 128 | | "{}", [INFO] [stderr] 129 | | std::str::from_utf8(&output).expect("output contained badly formatted utf8") [INFO] [stderr] 130 | | ) [INFO] [stderr] | |_________^ help: consider using .to_string(): `std::str::from_utf8(&output).expect("output contained badly formatted utf8").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aliases.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | config_location: config_location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_location` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:125:18 [INFO] [stderr] | [INFO] [stderr] 125 | Ok(_) => println!(""), [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aliases.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | config_location: config_location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_location` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aliases.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | config_location: config_location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_location` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:125:18 [INFO] [stderr] | [INFO] [stderr] 125 | Ok(_) => println!(""), [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/aliases.rs:10:11 [INFO] [stderr] | [INFO] [stderr] 10 | match std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/aliases.rs:18:11 [INFO] [stderr] | [INFO] [stderr] 18 | match std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/aliases.rs:10:11 [INFO] [stderr] | [INFO] [stderr] 10 | match std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/aliases.rs:18:11 [INFO] [stderr] | [INFO] [stderr] 18 | match std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/aliases.rs:10:11 [INFO] [stderr] | [INFO] [stderr] 10 | match std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/aliases.rs:18:11 [INFO] [stderr] | [INFO] [stderr] 18 | match std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/aliases.rs:69:43 [INFO] [stderr] | [INFO] [stderr] 69 | let mut split_eq = rest.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/aliases.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / format!( [INFO] [stderr] 128 | | "{}", [INFO] [stderr] 129 | | std::str::from_utf8(&output).expect("output contained badly formatted utf8") [INFO] [stderr] 130 | | ) [INFO] [stderr] | |_________^ help: consider using .to_string(): `std::str::from_utf8(&output).expect("output contained badly formatted utf8").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/aliases.rs:69:43 [INFO] [stderr] | [INFO] [stderr] 69 | let mut split_eq = rest.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/aliases.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / format!( [INFO] [stderr] 128 | | "{}", [INFO] [stderr] 129 | | std::str::from_utf8(&output).expect("output contained badly formatted utf8") [INFO] [stderr] 130 | | ) [INFO] [stderr] | |_________^ help: consider using .to_string(): `std::str::from_utf8(&output).expect("output contained badly formatted utf8").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/aliases.rs:69:43 [INFO] [stderr] | [INFO] [stderr] 69 | let mut split_eq = rest.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/aliases.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / format!( [INFO] [stderr] 128 | | "{}", [INFO] [stderr] 129 | | std::str::from_utf8(&output).expect("output contained badly formatted utf8") [INFO] [stderr] 130 | | ) [INFO] [stderr] | |_________^ help: consider using .to_string(): `std::str::from_utf8(&output).expect("output contained badly formatted utf8").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.07s [INFO] running `"docker" "inspect" "377fe58e2476951163ad9fe02ead3290672aac5aeaee40c188f181d6b41683d8"` [INFO] running `"docker" "rm" "-f" "377fe58e2476951163ad9fe02ead3290672aac5aeaee40c188f181d6b41683d8"` [INFO] [stdout] 377fe58e2476951163ad9fe02ead3290672aac5aeaee40c188f181d6b41683d8