[INFO] updating cached repository mattKipper/algos-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mattKipper/algos-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mattKipper/algos-rs" "work/ex/clippy-test-run/sources/stable/gh/mattKipper/algos-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mattKipper/algos-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mattKipper/algos-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattKipper/algos-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattKipper/algos-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5b972bb4fc34a9c9c00f91a55f05301f596e76ef [INFO] sha for GitHub repo mattKipper/algos-rs: 5b972bb4fc34a9c9c00f91a55f05301f596e76ef [INFO] validating manifest of mattKipper/algos-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mattKipper/algos-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mattKipper/algos-rs [INFO] finished frobbing mattKipper/algos-rs [INFO] frobbed toml for mattKipper/algos-rs written to work/ex/clippy-test-run/sources/stable/gh/mattKipper/algos-rs/Cargo.toml [INFO] started frobbing mattKipper/algos-rs [INFO] finished frobbing mattKipper/algos-rs [INFO] frobbed toml for mattKipper/algos-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattKipper/algos-rs/Cargo.toml [INFO] crate mattKipper/algos-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mattKipper/algos-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mattKipper/algos-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 985b42366e1f220c1264ee8e30f038c29d5f95b31a6991b9d741338c8a8ceaaa [INFO] running `"docker" "start" "-a" "985b42366e1f220c1264ee8e30f038c29d5f95b31a6991b9d741338c8a8ceaaa"` [INFO] [stderr] Checking algos-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `i` is used to index `coll` [INFO] [stderr] --> src/search.rs:8:14 [INFO] [stderr] | [INFO] [stderr] 8 | for i in 0..coll.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 8 | for (i, ) in coll.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/search.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | if &coll[i] == &val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 9 | if coll[i] == val { [INFO] [stderr] | ^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `coll` [INFO] [stderr] --> src/search.rs:8:14 [INFO] [stderr] | [INFO] [stderr] 8 | for i in 0..coll.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 8 | for (i, ) in coll.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/search.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | if &coll[i] == &val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sort.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 9 | if coll[i] == val { [INFO] [stderr] | ^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sort.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc/adder.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn add(a: &Vec, b: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sort.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc/adder.rs:3:30 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn add(a: &Vec, b: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sort.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc/adder.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn add(a: &Vec, b: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/misc/adder.rs:3:30 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn add(a: &Vec, b: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "985b42366e1f220c1264ee8e30f038c29d5f95b31a6991b9d741338c8a8ceaaa"` [INFO] running `"docker" "rm" "-f" "985b42366e1f220c1264ee8e30f038c29d5f95b31a6991b9d741338c8a8ceaaa"` [INFO] [stdout] 985b42366e1f220c1264ee8e30f038c29d5f95b31a6991b9d741338c8a8ceaaa