[INFO] updating cached repository matklad/s [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/matklad/s [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/matklad/s" "work/ex/clippy-test-run/sources/stable/gh/matklad/s"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matklad/s'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/matklad/s" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/s"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/s'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7be36a4cf85c5dbb1046a41ef01c8d441c60f98f [INFO] sha for GitHub repo matklad/s: 7be36a4cf85c5dbb1046a41ef01c8d441c60f98f [INFO] validating manifest of matklad/s on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of matklad/s on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing matklad/s [INFO] finished frobbing matklad/s [INFO] frobbed toml for matklad/s written to work/ex/clippy-test-run/sources/stable/gh/matklad/s/Cargo.toml [INFO] started frobbing matklad/s [INFO] finished frobbing matklad/s [INFO] frobbed toml for matklad/s written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/s/Cargo.toml [INFO] crate matklad/s has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting matklad/s against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/s:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a51ad0799e13d93cfa6b83ff72b4f13cd1dfbb4acc150f70dc89e6911627f30 [INFO] running `"docker" "start" "-a" "6a51ad0799e13d93cfa6b83ff72b4f13cd1dfbb4acc150f70dc89e6911627f30"` [INFO] [stderr] Checking s v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variant is never constructed: `Number` [INFO] [stderr] --> src/eval.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Number(i64), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Atom` [INFO] [stderr] --> src/eval.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Atom(String), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `List` [INFO] [stderr] --> src/eval.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | List(Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Closure` [INFO] [stderr] --> src/eval.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Closure(Rc Result>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `closure` [INFO] [stderr] --> src/eval.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn closure Result + 'static>(f: F) -> Value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `number` [INFO] [stderr] --> src/eval.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn number(i: i64) -> Value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_bool` [INFO] [stderr] --> src/eval.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn from_bool(b: bool) -> Value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_sexpr` [INFO] [stderr] --> src/eval.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn from_sexpr(sexpr: &Sexpr) -> Value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `eval` [INFO] [stderr] --> src/eval.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn eval(&self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `builtin` [INFO] [stderr] --> src/eval.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | fn builtin() -> Env { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `mk_env` [INFO] [stderr] --> src/eval.rs:401:1 [INFO] [stderr] | [INFO] [stderr] 401 | fn mk_env Option + 'static>(f: F) -> Env { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `eval_number` [INFO] [stderr] --> src/eval.rs:406:1 [INFO] [stderr] | [INFO] [stderr] 406 | fn eval_number(env: &Env, expr: &Sexpr) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `eval` [INFO] [stderr] --> src/eval.rs:414:1 [INFO] [stderr] | [INFO] [stderr] 414 | fn eval(env: &Env, expr: &Sexpr) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/sexpr.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | if s.chars().next() != Some(')') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!s.starts_with(')')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sexpr.rs:93:108 [INFO] [stderr] | [INFO] [stderr] 93 | let idx = s.find(|c: char| c == '(' || c == ')' || c == '\'' || c == '#' || c.is_whitespace()).unwrap_or(s.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/eval.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | Closure(Rc Result>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/eval.rs:352:28 [INFO] [stderr] | [INFO] [stderr] 352 | Ok(Value::List(args.iter().cloned().collect())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/eval.rs:377:17 [INFO] [stderr] | [INFO] [stderr] 377 | ls[1..].iter().cloned().collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/sexpr.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | if s.chars().next() != Some(')') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!s.starts_with(')')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sexpr.rs:93:108 [INFO] [stderr] | [INFO] [stderr] 93 | let idx = s.find(|c: char| c == '(' || c == ')' || c == '\'' || c == '#' || c.is_whitespace()).unwrap_or(s.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/eval.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | Closure(Rc Result>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/eval.rs:352:28 [INFO] [stderr] | [INFO] [stderr] 352 | Ok(Value::List(args.iter().cloned().collect())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/eval.rs:377:17 [INFO] [stderr] | [INFO] [stderr] 377 | ls[1..].iter().cloned().collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.88s [INFO] running `"docker" "inspect" "6a51ad0799e13d93cfa6b83ff72b4f13cd1dfbb4acc150f70dc89e6911627f30"` [INFO] running `"docker" "rm" "-f" "6a51ad0799e13d93cfa6b83ff72b4f13cd1dfbb4acc150f70dc89e6911627f30"` [INFO] [stdout] 6a51ad0799e13d93cfa6b83ff72b4f13cd1dfbb4acc150f70dc89e6911627f30