[INFO] updating cached repository matklad/kotlin-rust-dp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/matklad/kotlin-rust-dp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/matklad/kotlin-rust-dp" "work/ex/clippy-test-run/sources/stable/gh/matklad/kotlin-rust-dp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matklad/kotlin-rust-dp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/matklad/kotlin-rust-dp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/kotlin-rust-dp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/kotlin-rust-dp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3227557028d709d011e20b6e558518c6e798f6f8 [INFO] sha for GitHub repo matklad/kotlin-rust-dp: 3227557028d709d011e20b6e558518c6e798f6f8 [INFO] validating manifest of matklad/kotlin-rust-dp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of matklad/kotlin-rust-dp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing matklad/kotlin-rust-dp [INFO] finished frobbing matklad/kotlin-rust-dp [INFO] frobbed toml for matklad/kotlin-rust-dp written to work/ex/clippy-test-run/sources/stable/gh/matklad/kotlin-rust-dp/Cargo.toml [INFO] started frobbing matklad/kotlin-rust-dp [INFO] finished frobbing matklad/kotlin-rust-dp [INFO] frobbed toml for matklad/kotlin-rust-dp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/kotlin-rust-dp/Cargo.toml [INFO] crate matklad/kotlin-rust-dp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting matklad/kotlin-rust-dp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matklad/kotlin-rust-dp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69dc4422cfb2b154c5bc78f147f86e27fdf58aadff6f6f9cb119bee65938d582 [INFO] running `"docker" "start" "-a" "69dc4422cfb2b154c5bc78f147f86e27fdf58aadff6f6f9cb119bee65938d582"` [INFO] [stderr] Checking clap v2.20.5 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking ts v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/original.rs:67:70 [INFO] [stderr] | [INFO] [stderr] 67 | fn new(class: String, data: Vec) -> TimeSerie { TimeSerie { class: class, ptr: data.as_ptr(), data: data } } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/original.rs:67:104 [INFO] [stderr] | [INFO] [stderr] 67 | fn new(class: String, data: Vec) -> TimeSerie { TimeSerie { class: class, ptr: data.as_ptr(), data: data } } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/original.rs:67:70 [INFO] [stderr] | [INFO] [stderr] 67 | fn new(class: String, data: Vec) -> TimeSerie { TimeSerie { class: class, ptr: data.as_ptr(), data: data } } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/original.rs:67:104 [INFO] [stderr] | [INFO] [stderr] 67 | fn new(class: String, data: Vec) -> TimeSerie { TimeSerie { class: class, ptr: data.as_ptr(), data: data } } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::PartialEq` [INFO] [stderr] --> src/bin/original.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::cmp::PartialEq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/original.rs:55:82 [INFO] [stderr] | [INFO] [stderr] 55 | (if d11 < d01 { if d11 < d10 { d11 } else { d10 } } else { if d01 < d10 { d01 } else { d10 } }) + self.square_dist(idx_line, idx_col, other) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if d01 < d10 { d01 } else { d10 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/original.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/bin/original.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | Err(_) => { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::PartialEq` [INFO] [stderr] --> src/bin/original.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::cmp::PartialEq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/original.rs:55:82 [INFO] [stderr] | [INFO] [stderr] 55 | (if d11 < d01 { if d11 < d10 { d11 } else { d10 } } else { if d01 < d10 { d01 } else { d10 } }) + self.square_dist(idx_line, idx_col, other) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if d01 < d10 { d01 } else { d10 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/original.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/bin/original.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | Err(_) => { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: field is never used: `class` [INFO] [stderr] --> src/bin/original.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | class: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/original.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | let working_area = vec![0 as f64; ts_size * ts_size].as_mut_ptr(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/original.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / match now.elapsed() { [INFO] [stderr] 118 | | Ok(elapsed) => { println!("{} s", elapsed.as_secs()); } [INFO] [stderr] 119 | | Err(_) => { () } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(elapsed) = now.elapsed() { println!("{} s", elapsed.as_secs()); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 29 | | if y < z { y } else { z } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ help: try: `if y < z { y } else { z }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `class` [INFO] [stderr] --> src/bin/original.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | class: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/original.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | let working_area = vec![0 as f64; ts_size * ts_size].as_mut_ptr(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/original.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / match now.elapsed() { [INFO] [stderr] 118 | | Ok(elapsed) => { println!("{} s", elapsed.as_secs()); } [INFO] [stderr] 119 | | Err(_) => { () } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(elapsed) = now.elapsed() { println!("{} s", elapsed.as_secs()); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 29 | | if y < z { y } else { z } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ help: try: `if y < z { y } else { z }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | elapsed.as_secs() * 1000 + elapsed.subsec_nanos() as u64 / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | elapsed.as_secs() * 1000 + elapsed.subsec_nanos() as u64 / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.12s [INFO] running `"docker" "inspect" "69dc4422cfb2b154c5bc78f147f86e27fdf58aadff6f6f9cb119bee65938d582"` [INFO] running `"docker" "rm" "-f" "69dc4422cfb2b154c5bc78f147f86e27fdf58aadff6f6f9cb119bee65938d582"` [INFO] [stdout] 69dc4422cfb2b154c5bc78f147f86e27fdf58aadff6f6f9cb119bee65938d582