[INFO] updating cached repository matematikaadit/rec-jit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/matematikaadit/rec-jit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/matematikaadit/rec-jit" "work/ex/clippy-test-run/sources/stable/gh/matematikaadit/rec-jit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/matematikaadit/rec-jit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/matematikaadit/rec-jit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matematikaadit/rec-jit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matematikaadit/rec-jit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c4d40ccdffdc709eb0a6d790f47b2157d649e0cc [INFO] sha for GitHub repo matematikaadit/rec-jit: c4d40ccdffdc709eb0a6d790f47b2157d649e0cc [INFO] validating manifest of matematikaadit/rec-jit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of matematikaadit/rec-jit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing matematikaadit/rec-jit [INFO] finished frobbing matematikaadit/rec-jit [INFO] frobbed toml for matematikaadit/rec-jit written to work/ex/clippy-test-run/sources/stable/gh/matematikaadit/rec-jit/Cargo.toml [INFO] started frobbing matematikaadit/rec-jit [INFO] finished frobbing matematikaadit/rec-jit [INFO] frobbed toml for matematikaadit/rec-jit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matematikaadit/rec-jit/Cargo.toml [INFO] crate matematikaadit/rec-jit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting matematikaadit/rec-jit against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/matematikaadit/rec-jit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be431da8fb52d5301c5f63fc8ea4319b820efff56b09c263f5635932fd31becd [INFO] running `"docker" "start" "-a" "be431da8fb52d5301c5f63fc8ea4319b820efff56b09c263f5635932fd31becd"` [INFO] [stderr] Checking rec-jit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/main.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | let begin = unsafe { mmap(0 as *mut c_void, BUF_SIZE, prot, flags, -1, 0) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn to_fn<'a>(&'a mut self) -> impl Fn(i64) -> i64 + 'a { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:191:14 [INFO] [stderr] | [INFO] [stderr] 191 | for i in 0..term+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=term` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:216:21 [INFO] [stderr] | [INFO] [stderr] 216 | let digit = (c - b'0') as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(c - b'0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/main.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | let begin = unsafe { mmap(0 as *mut c_void, BUF_SIZE, prot, flags, -1, 0) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn to_fn<'a>(&'a mut self) -> impl Fn(i64) -> i64 + 'a { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:191:14 [INFO] [stderr] | [INFO] [stderr] 191 | for i in 0..term+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=term` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:216:21 [INFO] [stderr] | [INFO] [stderr] 216 | let digit = (c - b'0') as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(c - b'0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "be431da8fb52d5301c5f63fc8ea4319b820efff56b09c263f5635932fd31becd"` [INFO] running `"docker" "rm" "-f" "be431da8fb52d5301c5f63fc8ea4319b820efff56b09c263f5635932fd31becd"` [INFO] [stdout] be431da8fb52d5301c5f63fc8ea4319b820efff56b09c263f5635932fd31becd