[INFO] updating cached repository mas-yo/ragtime-old [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mas-yo/ragtime-old [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mas-yo/ragtime-old" "work/ex/clippy-test-run/sources/stable/gh/mas-yo/ragtime-old"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mas-yo/ragtime-old'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mas-yo/ragtime-old" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mas-yo/ragtime-old"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mas-yo/ragtime-old'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f30656bb8dfb8c8f7015abd8aa5462a09a907b70 [INFO] sha for GitHub repo mas-yo/ragtime-old: f30656bb8dfb8c8f7015abd8aa5462a09a907b70 [INFO] validating manifest of mas-yo/ragtime-old on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mas-yo/ragtime-old on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mas-yo/ragtime-old [INFO] removed workspace from mas-yo/ragtime-old [INFO] finished frobbing mas-yo/ragtime-old [INFO] frobbed toml for mas-yo/ragtime-old written to work/ex/clippy-test-run/sources/stable/gh/mas-yo/ragtime-old/Cargo.toml [INFO] started frobbing mas-yo/ragtime-old [INFO] removed workspace from mas-yo/ragtime-old [INFO] finished frobbing mas-yo/ragtime-old [INFO] frobbed toml for mas-yo/ragtime-old written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mas-yo/ragtime-old/Cargo.toml [INFO] crate mas-yo/ragtime-old has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mas-yo/ragtime-old against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mas-yo/ragtime-old:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc6f62431dea2eabdf1c9890a2f25e1ef0007907dcb177699de14282c234bd04 [INFO] running `"docker" "start" "-a" "cc6f62431dea2eabdf1c9890a2f25e1ef0007907dcb177699de14282c234bd04"` [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking ragtime v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | listener: listener, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `listener` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/room.rs:53:47 [INFO] [stderr] | [INFO] [stderr] 53 | let mut new_room = RoomEntry{ room_id: room_id, room: R::new(room_id) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `room_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | listener: listener, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `listener` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/room.rs:53:47 [INFO] [stderr] | [INFO] [stderr] 53 | let mut new_room = RoomEntry{ room_id: room_id, room: R::new(room_id) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `room_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `VecDeque` [INFO] [stderr] --> src/network.rs:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | use std::collections::{HashMap, VecDeque}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `Sender`, `channel` [INFO] [stderr] --> src/network.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | use std::sync::mpsc::{Sender, Receiver, channel}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Rc`, `Weak` [INFO] [stderr] --> src/network.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use std::rc::{Weak, Rc}; [INFO] [stderr] | ^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/network.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/network.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::ToSocketAddrs` [INFO] [stderr] --> src/network.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::net::ToSocketAddrs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::SocketAddr` [INFO] [stderr] --> src/network.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::net::SocketAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/network.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | use std::io::{Write, Read, BufReader, BufRead}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BigEndian`, `ByteOrder` [INFO] [stderr] --> src/network.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | use self::byteorder::{BigEndian, ByteOrder}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BufReader`, `Read`, `Write` [INFO] [stderr] --> src/string_message.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{Write, Read, BufReader, BufRead}; [INFO] [stderr] | ^^^^^ ^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::PartialEq` [INFO] [stderr] --> src/room.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp::PartialEq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::borrow::Borrow` [INFO] [stderr] --> src/room.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::borrow::Borrow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Receiver` [INFO] [stderr] --> src/room.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | use std::sync::mpsc::{Sender,Receiver}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/network.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `id` [INFO] [stderr] --> src/network.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | id: ConnectionID, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | self.send_stream.write_all(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | stream.set_nonblocking(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `VecDeque` [INFO] [stderr] --> src/network.rs:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | use std::collections::{HashMap, VecDeque}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `Sender`, `channel` [INFO] [stderr] --> src/network.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | use std::sync::mpsc::{Sender, Receiver, channel}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Rc`, `Weak` [INFO] [stderr] --> src/network.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use std::rc::{Weak, Rc}; [INFO] [stderr] | ^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/network.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/network.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::ToSocketAddrs` [INFO] [stderr] --> src/network.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::net::ToSocketAddrs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::SocketAddr` [INFO] [stderr] --> src/network.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::net::SocketAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/network.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | use std::io::{Write, Read, BufReader, BufRead}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BigEndian`, `ByteOrder` [INFO] [stderr] --> src/network.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | use self::byteorder::{BigEndian, ByteOrder}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BufReader`, `Read`, `Write` [INFO] [stderr] --> src/string_message.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{Write, Read, BufReader, BufRead}; [INFO] [stderr] | ^^^^^ ^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::PartialEq` [INFO] [stderr] --> src/room.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp::PartialEq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::borrow::Borrow` [INFO] [stderr] --> src/room.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::borrow::Borrow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Receiver` [INFO] [stderr] --> src/room.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | use std::sync::mpsc::{Sender,Receiver}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `db::DBManager` [INFO] [stderr] --> src/db.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn new() -> DBManager { [INFO] [stderr] 6 | | DBManager{} [INFO] [stderr] 7 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/string_message.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | reader.read_line(&mut self.body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/room.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | / loop { [INFO] [stderr] 34 | | if let Ok(cmd) = rx.try_recv() { [INFO] [stderr] 35 | | let (room_id, cmd) = cmd; [INFO] [stderr] 36 | | let cmds = commands.entry(room_id).or_insert(Vec::new()); [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: try: `while let Ok(cmd) = rx.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/room.rs:36:56 [INFO] [stderr] | [INFO] [stderr] 36 | let cmds = commands.entry(room_id).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/room.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | cmds.map( |c| { r.room.update(c); } ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = cmds { r.room.update(c); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/network.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `id` [INFO] [stderr] --> src/network.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | id: ConnectionID, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | self.send_stream.write_all(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | stream.set_nonblocking(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `db::DBManager` [INFO] [stderr] --> src/db.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn new() -> DBManager { [INFO] [stderr] 6 | | DBManager{} [INFO] [stderr] 7 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/string_message.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | reader.read_line(&mut self.body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/room.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | / loop { [INFO] [stderr] 34 | | if let Ok(cmd) = rx.try_recv() { [INFO] [stderr] 35 | | let (room_id, cmd) = cmd; [INFO] [stderr] 36 | | let cmds = commands.entry(room_id).or_insert(Vec::new()); [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: try: `while let Ok(cmd) = rx.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/room.rs:36:56 [INFO] [stderr] | [INFO] [stderr] 36 | let cmds = commands.entry(room_id).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/room.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | cmds.map( |c| { r.room.update(c); } ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = cmds { r.room.update(c); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.51s [INFO] running `"docker" "inspect" "cc6f62431dea2eabdf1c9890a2f25e1ef0007907dcb177699de14282c234bd04"` [INFO] running `"docker" "rm" "-f" "cc6f62431dea2eabdf1c9890a2f25e1ef0007907dcb177699de14282c234bd04"` [INFO] [stdout] cc6f62431dea2eabdf1c9890a2f25e1ef0007907dcb177699de14282c234bd04