[INFO] updating cached repository martimdev/sudokusv
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/martimdev/sudokusv
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/martimdev/sudokusv" "work/ex/clippy-test-run/sources/stable/gh/martimdev/sudokusv"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/martimdev/sudokusv'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/martimdev/sudokusv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martimdev/sudokusv"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martimdev/sudokusv'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ac5248d2581e8aff59a3a26141afa0ed0a88b3f9
[INFO] sha for GitHub repo martimdev/sudokusv: ac5248d2581e8aff59a3a26141afa0ed0a88b3f9
[INFO] validating manifest of martimdev/sudokusv on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of martimdev/sudokusv on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing martimdev/sudokusv
[INFO] finished frobbing martimdev/sudokusv
[INFO] frobbed toml for martimdev/sudokusv written to work/ex/clippy-test-run/sources/stable/gh/martimdev/sudokusv/Cargo.toml
[INFO] started frobbing martimdev/sudokusv
[INFO] finished frobbing martimdev/sudokusv
[INFO] frobbed toml for martimdev/sudokusv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martimdev/sudokusv/Cargo.toml
[INFO] crate martimdev/sudokusv has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting martimdev/sudokusv against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/martimdev/sudokusv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9109b05ac40630daad26aa5f6ecd93da149e0442a358cd65fca5af6f92f88fde
[INFO] running `"docker" "start" "-a" "9109b05ac40630daad26aa5f6ecd93da149e0442a358cd65fca5af6f92f88fde"`
[INFO] [stderr]     Checking term-painter v0.2.4
[INFO] [stderr]     Checking sudokusv v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/lib.rs:449:31
[INFO] [stderr]     |
[INFO] [stderr] 449 |             _ => print!("{}", "|")
[INFO] [stderr]     |                               ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/lib.rs:449:31
[INFO] [stderr]     |
[INFO] [stderr] 449 |             _ => print!("{}", "|")
[INFO] [stderr]     |                               ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:212:13
[INFO] [stderr]     |
[INFO] [stderr] 212 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:397:9
[INFO] [stderr]     |
[INFO] [stderr] 397 |         return lines_by_columns;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lines_by_columns`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:212:13
[INFO] [stderr]     |
[INFO] [stderr] 212 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:397:9
[INFO] [stderr]     |
[INFO] [stderr] 397 |         return lines_by_columns;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lines_by_columns`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:31:52
[INFO] [stderr]    |
[INFO] [stderr] 31 |                     let value = get_missing_values(array.clone())[0];
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^ help: try dereferencing it: `*array`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:116:24
[INFO] [stderr]     |
[INFO] [stderr] 116 |                     if v.clone() == 0 {
[INFO] [stderr]     |                        ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `line`
[INFO] [stderr]    --> src/lib.rs:146:22
[INFO] [stderr]     |
[INFO] [stderr] 146 |             for i in 0..9 {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 146 |             for (i, <item>) in line.iter_mut().enumerate() {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:154:24
[INFO] [stderr]     |
[INFO] [stderr] 154 |                     if v.clone() == 0 {
[INFO] [stderr]     |                        ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `line`
[INFO] [stderr]    --> src/lib.rs:184:22
[INFO] [stderr]     |
[INFO] [stderr] 184 |             for i in 0..9 {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 184 |             for (i, <item>) in line.iter_mut().enumerate() {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:192:24
[INFO] [stderr]     |
[INFO] [stderr] 192 |                     if v.clone() == 0 {
[INFO] [stderr]     |                        ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:31:52
[INFO] [stderr]    |
[INFO] [stderr] 31 |                     let value = get_missing_values(array.clone())[0];
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^ help: try dereferencing it: `*array`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:116:24
[INFO] [stderr]     |
[INFO] [stderr] 116 |                     if v.clone() == 0 {
[INFO] [stderr]     |                        ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `line`
[INFO] [stderr]    --> src/lib.rs:146:22
[INFO] [stderr]     |
[INFO] [stderr] 146 |             for i in 0..9 {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 146 |             for (i, <item>) in line.iter_mut().enumerate() {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `line_index` is used to index `vertical_lines`
[INFO] [stderr]    --> src/lib.rs:278:27
[INFO] [stderr]     |
[INFO] [stderr] 278 |         for line_index in 0..9 {
[INFO] [stderr]     |                           ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 278 |         for (line_index, <item>) in vertical_lines.iter_mut().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:154:24
[INFO] [stderr]     |
[INFO] [stderr] 154 |                     if v.clone() == 0 {
[INFO] [stderr]     |                        ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `line`
[INFO] [stderr]    --> src/lib.rs:184:22
[INFO] [stderr]     |
[INFO] [stderr] 184 |             for i in 0..9 {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 184 |             for (i, <item>) in line.iter_mut().enumerate() {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `line_index` is used to index `horizontal_lines`
[INFO] [stderr]    --> src/lib.rs:402:27
[INFO] [stderr]     |
[INFO] [stderr] 402 |         for line_index in 0..9 {
[INFO] [stderr]     |                           ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 402 |         for (line_index, <item>) in horizontal_lines.iter_mut().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:192:24
[INFO] [stderr]     |
[INFO] [stderr] 192 |                     if v.clone() == 0 {
[INFO] [stderr]     |                        ^^^^^^^^^ help: try dereferencing it: `*v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `line_index` is used to index `vertical_lines`
[INFO] [stderr]    --> src/lib.rs:278:27
[INFO] [stderr]     |
[INFO] [stderr] 278 |         for line_index in 0..9 {
[INFO] [stderr]     |                           ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 278 |         for (line_index, <item>) in vertical_lines.iter_mut().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:430:12
[INFO] [stderr]     |
[INFO] [stderr] 430 |         if value.clone() != 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: try dereferencing it: `*value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:431:66
[INFO] [stderr]     |
[INFO] [stderr] 431 |             let index = missing_values.iter().position(|&v| v == value.clone()).unwrap();
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^^^ help: try dereferencing it: `*value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `line_index` is used to index `horizontal_lines`
[INFO] [stderr]    --> src/lib.rs:402:27
[INFO] [stderr]     |
[INFO] [stderr] 402 |         for line_index in 0..9 {
[INFO] [stderr]     |                           ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 402 |         for (line_index, <item>) in horizontal_lines.iter_mut().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:430:12
[INFO] [stderr]     |
[INFO] [stderr] 430 |         if value.clone() != 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: try dereferencing it: `*value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:431:66
[INFO] [stderr]     |
[INFO] [stderr] 431 |             let index = missing_values.iter().position(|&v| v == value.clone()).unwrap();
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^^^ help: try dereferencing it: `*value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.73s
[INFO] running `"docker" "inspect" "9109b05ac40630daad26aa5f6ecd93da149e0442a358cd65fca5af6f92f88fde"`
[INFO] running `"docker" "rm" "-f" "9109b05ac40630daad26aa5f6ecd93da149e0442a358cd65fca5af6f92f88fde"`
[INFO] [stdout] 9109b05ac40630daad26aa5f6ecd93da149e0442a358cd65fca5af6f92f88fde