[INFO] updating cached repository marsha88/Simple_DB [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/marsha88/Simple_DB [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/marsha88/Simple_DB" "work/ex/clippy-test-run/sources/stable/gh/marsha88/Simple_DB"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/marsha88/Simple_DB'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/marsha88/Simple_DB" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/marsha88/Simple_DB"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/marsha88/Simple_DB'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 951409c670ccbdb9a81211dc5d210b4b1b81521c [INFO] sha for GitHub repo marsha88/Simple_DB: 951409c670ccbdb9a81211dc5d210b4b1b81521c [INFO] validating manifest of marsha88/Simple_DB on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of marsha88/Simple_DB on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing marsha88/Simple_DB [INFO] finished frobbing marsha88/Simple_DB [INFO] frobbed toml for marsha88/Simple_DB written to work/ex/clippy-test-run/sources/stable/gh/marsha88/Simple_DB/Cargo.toml [INFO] started frobbing marsha88/Simple_DB [INFO] finished frobbing marsha88/Simple_DB [INFO] frobbed toml for marsha88/Simple_DB written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/marsha88/Simple_DB/Cargo.toml [INFO] crate marsha88/Simple_DB has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting marsha88/Simple_DB against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/marsha88/Simple_DB:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2150a565a228be5bb305edc3230c5d670dc3b8cb5114324303ff29586ec13c2a [INFO] running `"docker" "start" "-a" "2150a565a228be5bb305edc3230c5d670dc3b8cb5114324303ff29586ec13c2a"` [INFO] [stderr] Checking simple_db v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 231 | | if let Some(tran) = ts.pop() { [INFO] [stderr] 232 | | ct.val_quant = tran.val_quant; [INFO] [stderr] 233 | | ct.key_val = tran.key_val; [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 230 | else if let Some(tran) = ts.pop() { [INFO] [stderr] 231 | ct.val_quant = tran.val_quant; [INFO] [stderr] 232 | ct.key_val = tran.key_val; [INFO] [stderr] 233 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:82:3 [INFO] [stderr] | [INFO] [stderr] 82 | if self.val_quant.contains_key(&val) { [INFO] [stderr] | _________^ [INFO] [stderr] 83 | | if let Some(count) = self.val_quant.get_mut(&val) { [INFO] [stderr] 84 | | *count += 1; [INFO] [stderr] 85 | | } [INFO] [stderr] ... | [INFO] [stderr] 89 | | self.val_quant.insert(val, 1); [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: consider using: `self.val_quant.entry(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:132:30 [INFO] [stderr] | [INFO] [stderr] 132 | fn is_valid_command(command: &Vec<&str>) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:227:7 [INFO] [stderr] | [INFO] [stderr] 227 | if ts.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:238:7 [INFO] [stderr] | [INFO] [stderr] 238 | if ts.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:255:15 [INFO] [stderr] | [INFO] [stderr] 255 | let input = String::from(line.expect("Read Error")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line.expect("Read Error")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 231 | | if let Some(tran) = ts.pop() { [INFO] [stderr] 232 | | ct.val_quant = tran.val_quant; [INFO] [stderr] 233 | | ct.key_val = tran.key_val; [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 230 | else if let Some(tran) = ts.pop() { [INFO] [stderr] 231 | ct.val_quant = tran.val_quant; [INFO] [stderr] 232 | ct.key_val = tran.key_val; [INFO] [stderr] 233 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:82:3 [INFO] [stderr] | [INFO] [stderr] 82 | if self.val_quant.contains_key(&val) { [INFO] [stderr] | _________^ [INFO] [stderr] 83 | | if let Some(count) = self.val_quant.get_mut(&val) { [INFO] [stderr] 84 | | *count += 1; [INFO] [stderr] 85 | | } [INFO] [stderr] ... | [INFO] [stderr] 89 | | self.val_quant.insert(val, 1); [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: consider using: `self.val_quant.entry(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:132:30 [INFO] [stderr] | [INFO] [stderr] 132 | fn is_valid_command(command: &Vec<&str>) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:227:7 [INFO] [stderr] | [INFO] [stderr] 227 | if ts.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:238:7 [INFO] [stderr] | [INFO] [stderr] 238 | if ts.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:255:15 [INFO] [stderr] | [INFO] [stderr] 255 | let input = String::from(line.expect("Read Error")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line.expect("Read Error")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.61s [INFO] running `"docker" "inspect" "2150a565a228be5bb305edc3230c5d670dc3b8cb5114324303ff29586ec13c2a"` [INFO] running `"docker" "rm" "-f" "2150a565a228be5bb305edc3230c5d670dc3b8cb5114324303ff29586ec13c2a"` [INFO] [stdout] 2150a565a228be5bb305edc3230c5d670dc3b8cb5114324303ff29586ec13c2a