[INFO] updating cached repository maogm12/ccat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maogm12/ccat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maogm12/ccat" "work/ex/clippy-test-run/sources/stable/gh/maogm12/ccat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maogm12/ccat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maogm12/ccat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maogm12/ccat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maogm12/ccat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6d39f2a86f13fc7d75bbd7b588f0c4f505f87c9b [INFO] sha for GitHub repo maogm12/ccat: 6d39f2a86f13fc7d75bbd7b588f0c4f505f87c9b [INFO] validating manifest of maogm12/ccat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maogm12/ccat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maogm12/ccat [INFO] finished frobbing maogm12/ccat [INFO] frobbed toml for maogm12/ccat written to work/ex/clippy-test-run/sources/stable/gh/maogm12/ccat/Cargo.toml [INFO] started frobbing maogm12/ccat [INFO] finished frobbing maogm12/ccat [INFO] frobbed toml for maogm12/ccat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maogm12/ccat/Cargo.toml [INFO] crate maogm12/ccat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maogm12/ccat against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maogm12/ccat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7ea1e5501bd2d37e4b5b9594c21095fb234cc6034258d2d50401af224c10104f [INFO] running `"docker" "start" "-a" "7ea1e5501bd2d37e4b5b9594c21095fb234cc6034258d2d50401af224c10104f"` [INFO] [stderr] Checking ccat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | / if !options.squeeze_blank || !is_empty || !prev_empty { [INFO] [stderr] 123 | | if output_line(&line, line_number, options) { [INFO] [stderr] 124 | | line_number += 1; [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | if (!options.squeeze_blank || !is_empty || !prev_empty) && output_line(&line, line_number, options) { [INFO] [stderr] 123 | line_number += 1; [INFO] [stderr] 124 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | / if !options.squeeze_blank || !is_empty || !prev_empty { [INFO] [stderr] 123 | | if output_line(&line, line_number, options) { [INFO] [stderr] 124 | | line_number += 1; [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | if (!options.squeeze_blank || !is_empty || !prev_empty) && output_line(&line, line_number, options) { [INFO] [stderr] 123 | line_number += 1; [INFO] [stderr] 124 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:121:56 [INFO] [stderr] | [INFO] [stderr] 121 | let is_empty = line.trim_right_matches("\n").is_empty(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:121:56 [INFO] [stderr] | [INFO] [stderr] 121 | let is_empty = line.trim_right_matches("\n").is_empty(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.12s [INFO] running `"docker" "inspect" "7ea1e5501bd2d37e4b5b9594c21095fb234cc6034258d2d50401af224c10104f"` [INFO] running `"docker" "rm" "-f" "7ea1e5501bd2d37e4b5b9594c21095fb234cc6034258d2d50401af224c10104f"` [INFO] [stdout] 7ea1e5501bd2d37e4b5b9594c21095fb234cc6034258d2d50401af224c10104f