[INFO] updating cached repository mantarfish/minigrep-from-rust-programming
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mantarfish/minigrep-from-rust-programming
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mantarfish/minigrep-from-rust-programming" "work/ex/clippy-test-run/sources/stable/gh/mantarfish/minigrep-from-rust-programming"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mantarfish/minigrep-from-rust-programming'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mantarfish/minigrep-from-rust-programming" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mantarfish/minigrep-from-rust-programming"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mantarfish/minigrep-from-rust-programming'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5472c807a868eb04a9712bd687082e7f4429998a
[INFO] sha for GitHub repo mantarfish/minigrep-from-rust-programming: 5472c807a868eb04a9712bd687082e7f4429998a
[INFO] validating manifest of mantarfish/minigrep-from-rust-programming on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mantarfish/minigrep-from-rust-programming on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mantarfish/minigrep-from-rust-programming
[INFO] finished frobbing mantarfish/minigrep-from-rust-programming
[INFO] frobbed toml for mantarfish/minigrep-from-rust-programming written to work/ex/clippy-test-run/sources/stable/gh/mantarfish/minigrep-from-rust-programming/Cargo.toml
[INFO] started frobbing mantarfish/minigrep-from-rust-programming
[INFO] finished frobbing mantarfish/minigrep-from-rust-programming
[INFO] frobbed toml for mantarfish/minigrep-from-rust-programming written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mantarfish/minigrep-from-rust-programming/Cargo.toml
[INFO] crate mantarfish/minigrep-from-rust-programming has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mantarfish/minigrep-from-rust-programming against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mantarfish/minigrep-from-rust-programming:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] eeb723f0f0d3365c8c7b964c83ed359d0f1e2999107e3c480e76866f308d74bd
[INFO] running `"docker" "start" "-a" "eeb723f0f0d3365c8c7b964c83ed359d0f1e2999107e3c480e76866f308d74bd"`
[INFO] [stderr]     Checking minigrep v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return results;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return results;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 | /         if args.len() == 4 {
[INFO] [stderr] 64 | |             if args[3] == "c" {
[INFO] [stderr] 65 | |                 case_sensitive = true;
[INFO] [stderr] 66 | |             }
[INFO] [stderr] 67 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 63 |         if args.len() == 4 && args[3] == "c" {
[INFO] [stderr] 64 |     case_sensitive = true;
[INFO] [stderr] 65 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     let result: Vec<&str>;
[INFO] [stderr] 16 | |     if config.case_sensitive {
[INFO] [stderr] 17 | |         result = search(&query, &contents);
[INFO] [stderr] 18 | |     } else {
[INFO] [stderr] 19 | |         result = search_case_insensitive(&query, &contents);
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let result = if config.case_sensitive { search(&query, &contents) } else { search_case_insensitive(&query, &contents) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return results;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return results;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 | /         if args.len() == 4 {
[INFO] [stderr] 64 | |             if args[3] == "c" {
[INFO] [stderr] 65 | |                 case_sensitive = true;
[INFO] [stderr] 66 | |             }
[INFO] [stderr] 67 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 63 |         if args.len() == 4 && args[3] == "c" {
[INFO] [stderr] 64 |     case_sensitive = true;
[INFO] [stderr] 65 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     let result: Vec<&str>;
[INFO] [stderr] 16 | |     if config.case_sensitive {
[INFO] [stderr] 17 | |         result = search(&query, &contents);
[INFO] [stderr] 18 | |     } else {
[INFO] [stderr] 19 | |         result = search_case_insensitive(&query, &contents);
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let result = if config.case_sensitive { search(&query, &contents) } else { search_case_insensitive(&query, &contents) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.27s
[INFO] running `"docker" "inspect" "eeb723f0f0d3365c8c7b964c83ed359d0f1e2999107e3c480e76866f308d74bd"`
[INFO] running `"docker" "rm" "-f" "eeb723f0f0d3365c8c7b964c83ed359d0f1e2999107e3c480e76866f308d74bd"`
[INFO] [stdout] eeb723f0f0d3365c8c7b964c83ed359d0f1e2999107e3c480e76866f308d74bd