[INFO] updating cached repository maniflames/time-frame-json-generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maniflames/time-frame-json-generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maniflames/time-frame-json-generator" "work/ex/clippy-test-run/sources/stable/gh/maniflames/time-frame-json-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maniflames/time-frame-json-generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maniflames/time-frame-json-generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maniflames/time-frame-json-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maniflames/time-frame-json-generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5177d990276887f3c5803f437e2020504c242f6f [INFO] sha for GitHub repo maniflames/time-frame-json-generator: 5177d990276887f3c5803f437e2020504c242f6f [INFO] validating manifest of maniflames/time-frame-json-generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maniflames/time-frame-json-generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maniflames/time-frame-json-generator [INFO] finished frobbing maniflames/time-frame-json-generator [INFO] frobbed toml for maniflames/time-frame-json-generator written to work/ex/clippy-test-run/sources/stable/gh/maniflames/time-frame-json-generator/Cargo.toml [INFO] started frobbing maniflames/time-frame-json-generator [INFO] finished frobbing maniflames/time-frame-json-generator [INFO] frobbed toml for maniflames/time-frame-json-generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maniflames/time-frame-json-generator/Cargo.toml [INFO] crate maniflames/time-frame-json-generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maniflames/time-frame-json-generator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maniflames/time-frame-json-generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd1d2a98403a833c3db637b08260766ab0f068ad554b8c1b63c097b9d955e796 [INFO] running `"docker" "start" "-a" "fd1d2a98403a833c3db637b08260766ab0f068ad554b8c1b63c097b9d955e796"` [INFO] [stderr] Checking timeframe v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | use rustc_serialize::json::{self, Encoder}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return "Man".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Man".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return "Woman".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Woman".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / return Name { [INFO] [stderr] 45 | | first: "Kerst".to_string(), [INFO] [stderr] 46 | | insertion: "".to_string(), [INFO] [stderr] 47 | | last: "Man".to_string(), [INFO] [stderr] 48 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | Name { [INFO] [stderr] 45 | first: "Kerst".to_string(), [INFO] [stderr] 46 | insertion: "".to_string(), [INFO] [stderr] 47 | last: "Man".to_string(), [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return address_list[index].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `address_list[index].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:82:4 [INFO] [stderr] | [INFO] [stderr] 82 | return ids; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return new_id; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return generate_unique_id(&existing_ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `generate_unique_id(&existing_ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | let new_id: i64 = random.gen_range(100000000000, 999999999999); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `100_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:87:54 [INFO] [stderr] | [INFO] [stderr] 87 | let new_id: i64 = random.gen_range(100000000000, 999999999999); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `999_999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/package.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / return Package { [INFO] [stderr] 30 | | id: package_id, [INFO] [stderr] 31 | | delivery_delay: generate_delivery_delay(package_weight, is_fragile), [INFO] [stderr] 32 | | weight: package_weight, [INFO] [stderr] ... | [INFO] [stderr] 35 | | customer: customer::generate(), //TODO: find a way to link multiple packages to the same customer [INFO] [stderr] 36 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | Package { [INFO] [stderr] 30 | id: package_id, [INFO] [stderr] 31 | delivery_delay: generate_delivery_delay(package_weight, is_fragile), [INFO] [stderr] 32 | weight: package_weight, [INFO] [stderr] 33 | fragile: is_fragile, [INFO] [stderr] 34 | dimensions: generate_dimensions(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/package.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return packages; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `packages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/package.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / return Dimensions { [INFO] [stderr] 54 | | height: random.gen_range(0, 274), [INFO] [stderr] 55 | | width: random.gen_range(0, 274), [INFO] [stderr] 56 | | depth: random.gen_range(0, 274), [INFO] [stderr] 57 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | Dimensions { [INFO] [stderr] 54 | height: random.gen_range(0, 274), [INFO] [stderr] 55 | width: random.gen_range(0, 274), [INFO] [stderr] 56 | depth: random.gen_range(0, 274), [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/package.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return weight_delay_sec + (30 * fragile_delay); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `weight_delay_sec + (30 * fragile_delay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/customer.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / return Customer { [INFO] [stderr] 18 | | id: random.gen_range(0, 100), [INFO] [stderr] 19 | | name: utils::generate_name(), [INFO] [stderr] 20 | | birthday: random.gen_range(0, 100), //this should eventually have the range of a timestamp [INFO] [stderr] 21 | | gender: utils::generate_gender(), [INFO] [stderr] 22 | | address: utils::generate_address(), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | Customer { [INFO] [stderr] 18 | id: random.gen_range(0, 100), [INFO] [stderr] 19 | name: utils::generate_name(), [INFO] [stderr] 20 | birthday: random.gen_range(0, 100), //this should eventually have the range of a timestamp [INFO] [stderr] 21 | gender: utils::generate_gender(), [INFO] [stderr] 22 | address: utils::generate_address(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/driver.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / return Driver { [INFO] [stderr] 20 | | id: random.gen_range(0, 100), [INFO] [stderr] 21 | | name: utils::generate_name(), [INFO] [stderr] 22 | | birthday: random.gen_range(0, 100), [INFO] [stderr] ... | [INFO] [stderr] 25 | | departure_time: random.gen_range(1528070400, 1538070400), [INFO] [stderr] 26 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | Driver { [INFO] [stderr] 20 | id: random.gen_range(0, 100), [INFO] [stderr] 21 | name: utils::generate_name(), [INFO] [stderr] 22 | birthday: random.gen_range(0, 100), [INFO] [stderr] 23 | gender: utils::generate_gender(), [INFO] [stderr] 24 | years_of_experience: random.gen_range(0, 70), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/driver.rs:25:42 [INFO] [stderr] | [INFO] [stderr] 25 | departure_time: random.gen_range(1528070400, 1538070400), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_528_070_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/driver.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | departure_time: random.gen_range(1528070400, 1538070400), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_538_070_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:58:29 [INFO] [stderr] | [INFO] [stderr] 58 | departure_time: 1529977246, //TODO: Make this variable [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_529_977_246` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | use rustc_serialize::json::{self, Encoder}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return "Man".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Man".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return "Woman".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Woman".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / return Name { [INFO] [stderr] 45 | | first: "Kerst".to_string(), [INFO] [stderr] 46 | | insertion: "".to_string(), [INFO] [stderr] 47 | | last: "Man".to_string(), [INFO] [stderr] 48 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | Name { [INFO] [stderr] 45 | first: "Kerst".to_string(), [INFO] [stderr] 46 | insertion: "".to_string(), [INFO] [stderr] 47 | last: "Man".to_string(), [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return address_list[index].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `address_list[index].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:82:4 [INFO] [stderr] | [INFO] [stderr] 82 | return ids; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return new_id; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return generate_unique_id(&existing_ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `generate_unique_id(&existing_ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | let new_id: i64 = random.gen_range(100000000000, 999999999999); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `100_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:87:54 [INFO] [stderr] | [INFO] [stderr] 87 | let new_id: i64 = random.gen_range(100000000000, 999999999999); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `999_999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/package.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / return Package { [INFO] [stderr] 30 | | id: package_id, [INFO] [stderr] 31 | | delivery_delay: generate_delivery_delay(package_weight, is_fragile), [INFO] [stderr] 32 | | weight: package_weight, [INFO] [stderr] ... | [INFO] [stderr] 35 | | customer: customer::generate(), //TODO: find a way to link multiple packages to the same customer [INFO] [stderr] 36 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | Package { [INFO] [stderr] 30 | id: package_id, [INFO] [stderr] 31 | delivery_delay: generate_delivery_delay(package_weight, is_fragile), [INFO] [stderr] 32 | weight: package_weight, [INFO] [stderr] 33 | fragile: is_fragile, [INFO] [stderr] 34 | dimensions: generate_dimensions(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/package.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return packages; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `packages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/package.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / return Dimensions { [INFO] [stderr] 54 | | height: random.gen_range(0, 274), [INFO] [stderr] 55 | | width: random.gen_range(0, 274), [INFO] [stderr] 56 | | depth: random.gen_range(0, 274), [INFO] [stderr] 57 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | Dimensions { [INFO] [stderr] 54 | height: random.gen_range(0, 274), [INFO] [stderr] 55 | width: random.gen_range(0, 274), [INFO] [stderr] 56 | depth: random.gen_range(0, 274), [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/package.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return weight_delay_sec + (30 * fragile_delay); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `weight_delay_sec + (30 * fragile_delay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/customer.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / return Customer { [INFO] [stderr] 18 | | id: random.gen_range(0, 100), [INFO] [stderr] 19 | | name: utils::generate_name(), [INFO] [stderr] 20 | | birthday: random.gen_range(0, 100), //this should eventually have the range of a timestamp [INFO] [stderr] 21 | | gender: utils::generate_gender(), [INFO] [stderr] 22 | | address: utils::generate_address(), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | Customer { [INFO] [stderr] 18 | id: random.gen_range(0, 100), [INFO] [stderr] 19 | name: utils::generate_name(), [INFO] [stderr] 20 | birthday: random.gen_range(0, 100), //this should eventually have the range of a timestamp [INFO] [stderr] 21 | gender: utils::generate_gender(), [INFO] [stderr] 22 | address: utils::generate_address(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/driver.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / return Driver { [INFO] [stderr] 20 | | id: random.gen_range(0, 100), [INFO] [stderr] 21 | | name: utils::generate_name(), [INFO] [stderr] 22 | | birthday: random.gen_range(0, 100), [INFO] [stderr] ... | [INFO] [stderr] 25 | | departure_time: random.gen_range(1528070400, 1538070400), [INFO] [stderr] 26 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | Driver { [INFO] [stderr] 20 | id: random.gen_range(0, 100), [INFO] [stderr] 21 | name: utils::generate_name(), [INFO] [stderr] 22 | birthday: random.gen_range(0, 100), [INFO] [stderr] 23 | gender: utils::generate_gender(), [INFO] [stderr] 24 | years_of_experience: random.gen_range(0, 70), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/driver.rs:25:42 [INFO] [stderr] | [INFO] [stderr] 25 | departure_time: random.gen_range(1528070400, 1538070400), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_528_070_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/driver.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | departure_time: random.gen_range(1528070400, 1538070400), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_538_070_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:58:29 [INFO] [stderr] | [INFO] [stderr] 58 | departure_time: 1529977246, //TODO: Make this variable [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_529_977_246` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/utils.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | f.read_to_string(&mut json); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | fn generate_unique_id(existing_ids: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/package.rs:39:56 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn generate_vec(num_of_packages: i32, package_ids: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/package.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / let fragile_delay; [INFO] [stderr] 67 | | [INFO] [stderr] 68 | | //NOTE: this should obviously be a match [INFO] [stderr] 69 | | if fragile { [INFO] [stderr] ... | [INFO] [stderr] 72 | | fragile_delay = 0; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let fragile_delay = if fragile { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/utils.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | f.read_to_string(&mut json); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | fn generate_unique_id(existing_ids: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / let input_packages; [INFO] [stderr] 45 | | if _x + 1 == num_of_deliveries { [INFO] [stderr] 46 | | input_packages = package::generate_vec(num_packages_per_delivery + num_rest_packages, &package_ids); [INFO] [stderr] 47 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 50 | | input_packages = package::generate_vec(num_packages_per_delivery, &saved_package_ids); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let input_packages = if _x + 1 == num_of_deliveries { package::generate_vec(num_packages_per_delivery + num_rest_packages, &package_ids) } else { ..; package::generate_vec(num_packages_per_delivery, &saved_package_ids) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:49:69 [INFO] [stderr] | [INFO] [stderr] 49 | let saved_package_ids: Vec = package_ids.split_off(&package_ids_len - (num_packages_per_delivery as usize)); [INFO] [stderr] | ----------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `package_ids_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/package.rs:39:56 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn generate_vec(num_of_packages: i32, package_ids: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/package.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / let fragile_delay; [INFO] [stderr] 67 | | [INFO] [stderr] 68 | | //NOTE: this should obviously be a match [INFO] [stderr] 69 | | if fragile { [INFO] [stderr] ... | [INFO] [stderr] 72 | | fragile_delay = 0; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let fragile_delay = if fragile { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / let input_packages; [INFO] [stderr] 45 | | if _x + 1 == num_of_deliveries { [INFO] [stderr] 46 | | input_packages = package::generate_vec(num_packages_per_delivery + num_rest_packages, &package_ids); [INFO] [stderr] 47 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 50 | | input_packages = package::generate_vec(num_packages_per_delivery, &saved_package_ids); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let input_packages = if _x + 1 == num_of_deliveries { package::generate_vec(num_packages_per_delivery + num_rest_packages, &package_ids) } else { ..; package::generate_vec(num_packages_per_delivery, &saved_package_ids) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:49:69 [INFO] [stderr] | [INFO] [stderr] 49 | let saved_package_ids: Vec = package_ids.split_off(&package_ids_len - (num_packages_per_delivery as usize)); [INFO] [stderr] | ----------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `package_ids_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "fd1d2a98403a833c3db637b08260766ab0f068ad554b8c1b63c097b9d955e796"` [INFO] running `"docker" "rm" "-f" "fd1d2a98403a833c3db637b08260766ab0f068ad554b8c1b63c097b9d955e796"` [INFO] [stdout] fd1d2a98403a833c3db637b08260766ab0f068ad554b8c1b63c097b9d955e796