[INFO] updating cached repository mandubian/rust_fun [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mandubian/rust_fun [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mandubian/rust_fun" "work/ex/clippy-test-run/sources/stable/gh/mandubian/rust_fun"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mandubian/rust_fun'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mandubian/rust_fun" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandubian/rust_fun"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandubian/rust_fun'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d9b2e83cfad2ba01f84cf3e259486d4cccb40c83 [INFO] sha for GitHub repo mandubian/rust_fun: d9b2e83cfad2ba01f84cf3e259486d4cccb40c83 [INFO] validating manifest of mandubian/rust_fun on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mandubian/rust_fun on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mandubian/rust_fun [INFO] finished frobbing mandubian/rust_fun [INFO] frobbed toml for mandubian/rust_fun written to work/ex/clippy-test-run/sources/stable/gh/mandubian/rust_fun/Cargo.toml [INFO] started frobbing mandubian/rust_fun [INFO] finished frobbing mandubian/rust_fun [INFO] frobbed toml for mandubian/rust_fun written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandubian/rust_fun/Cargo.toml [INFO] crate mandubian/rust_fun has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mandubian/rust_fun against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandubian/rust_fun:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d579d68569f07276214ea4c6ae46090ca115ea834ee4b94455365b3fb92127f [INFO] running `"docker" "start" "-a" "7d579d68569f07276214ea4c6ae46090ca115ea834ee4b94455365b3fb92127f"` [INFO] [stderr] Checking rust_fun v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / match self { [INFO] [stderr] 124 | | &Some(ref a) => Some(f(a)), [INFO] [stderr] 125 | | &None => None [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | match *self { [INFO] [stderr] 124 | Some(ref a) => Some(f(a)), [INFO] [stderr] 125 | None => None [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:146:7 [INFO] [stderr] | [INFO] [stderr] 146 | / match self { [INFO] [stderr] 147 | | &CopK::Inl(ref l, _) => CopK::Inl(l.map(f), PhantomData), [INFO] [stderr] 148 | | &CopK::Inr(_, _) => panic!("can't reach that case"), [INFO] [stderr] 149 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 146 | match *self { [INFO] [stderr] 147 | CopK::Inl(ref l, _) => CopK::Inl(l.map(f), PhantomData), [INFO] [stderr] 148 | CopK::Inr(_, _) => panic!("can't reach that case"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:160:7 [INFO] [stderr] | [INFO] [stderr] 160 | / match self { [INFO] [stderr] 161 | | &CopK::Inl(ref l, _) => CopK::Inl(l.map(f), PhantomData), [INFO] [stderr] 162 | | &CopK::Inr(ref r, _) => CopK::Inr(r.map(f), PhantomData) [INFO] [stderr] 163 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | match *self { [INFO] [stderr] 161 | CopK::Inl(ref l, _) => CopK::Inl(l.map(f), PhantomData), [INFO] [stderr] 162 | CopK::Inr(ref r, _) => CopK::Inr(r.map(f), PhantomData) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / match self { [INFO] [stderr] 124 | | &Some(ref a) => Some(f(a)), [INFO] [stderr] 125 | | &None => None [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | match *self { [INFO] [stderr] 124 | Some(ref a) => Some(f(a)), [INFO] [stderr] 125 | None => None [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:146:7 [INFO] [stderr] | [INFO] [stderr] 146 | / match self { [INFO] [stderr] 147 | | &CopK::Inl(ref l, _) => CopK::Inl(l.map(f), PhantomData), [INFO] [stderr] 148 | | &CopK::Inr(_, _) => panic!("can't reach that case"), [INFO] [stderr] 149 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 146 | match *self { [INFO] [stderr] 147 | CopK::Inl(ref l, _) => CopK::Inl(l.map(f), PhantomData), [INFO] [stderr] 148 | CopK::Inr(_, _) => panic!("can't reach that case"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:160:7 [INFO] [stderr] | [INFO] [stderr] 160 | / match self { [INFO] [stderr] 161 | | &CopK::Inl(ref l, _) => CopK::Inl(l.map(f), PhantomData), [INFO] [stderr] 162 | | &CopK::Inr(ref r, _) => CopK::Inr(r.map(f), PhantomData) [INFO] [stderr] 163 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | match *self { [INFO] [stderr] 161 | CopK::Inl(ref l, _) => CopK::Inl(l.map(f), PhantomData), [INFO] [stderr] 162 | CopK::Inr(ref r, _) => CopK::Inr(r.map(f), PhantomData) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.60s [INFO] running `"docker" "inspect" "7d579d68569f07276214ea4c6ae46090ca115ea834ee4b94455365b3fb92127f"` [INFO] running `"docker" "rm" "-f" "7d579d68569f07276214ea4c6ae46090ca115ea834ee4b94455365b3fb92127f"` [INFO] [stdout] 7d579d68569f07276214ea4c6ae46090ca115ea834ee4b94455365b3fb92127f