[INFO] updating cached repository mandober/rust-maybe-type [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mandober/rust-maybe-type [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mandober/rust-maybe-type" "work/ex/clippy-test-run/sources/stable/gh/mandober/rust-maybe-type"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mandober/rust-maybe-type'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mandober/rust-maybe-type" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandober/rust-maybe-type"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandober/rust-maybe-type'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4a30396b6d4105cda4807018011c782afe17ebbd [INFO] sha for GitHub repo mandober/rust-maybe-type: 4a30396b6d4105cda4807018011c782afe17ebbd [INFO] validating manifest of mandober/rust-maybe-type on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mandober/rust-maybe-type on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mandober/rust-maybe-type [INFO] finished frobbing mandober/rust-maybe-type [INFO] frobbed toml for mandober/rust-maybe-type written to work/ex/clippy-test-run/sources/stable/gh/mandober/rust-maybe-type/Cargo.toml [INFO] started frobbing mandober/rust-maybe-type [INFO] finished frobbing mandober/rust-maybe-type [INFO] frobbed toml for mandober/rust-maybe-type written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandober/rust-maybe-type/Cargo.toml [INFO] crate mandober/rust-maybe-type has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mandober/rust-maybe-type against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mandober/rust-maybe-type:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47f678776a841cd3b204d4fc7b0ce232d46e8c7ebce8411be7f951c6e9607729 [INFO] running `"docker" "start" "-a" "47f678776a841cd3b204d4fc7b0ce232d46e8c7ebce8411be7f951c6e9607729"` [INFO] [stderr] Checking maybe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/maybe/mod.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | / match *self { [INFO] [stderr] 228 | | Nothing => *self = Just(v), [INFO] [stderr] 229 | | _ => (), [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____^ help: try this: `if let Nothing = *self { *self = Just(v) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let unit =` [INFO] [stderr] --> src/main.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | let unit: () = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | showme(unit); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 31 | showme(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/maybe/test.rs:7:7 [INFO] [stderr] | [INFO] [stderr] 7 | let ref mut juju: Maybe<&str> = Just("Alpha"); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------ help: try: `let juju: &mut Maybe<&str> = &mut Just("Alpha");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/maybe/test.rs:8:7 [INFO] [stderr] | [INFO] [stderr] 8 | let ref mut ini = &juju; [INFO] [stderr] | ----^^^^^^^^^^^--------- help: try: `let ini = &mut (&juju);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/maybe/test.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | let ref mut nick: u8 = 122; [INFO] [stderr] | ----^^^^^^^^^^^^----------- help: try: `let nick: &mut u8 = &mut 122;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/maybe/test.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | let ref mut nick2: &u8 = &42; [INFO] [stderr] | ----^^^^^^^^^^^^^------------ help: try: `let nick2: &mut &u8 = &mut (&42);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/maybe/test.rs:23:7 [INFO] [stderr] | [INFO] [stderr] 23 | let ref mut ant: &'static str = "42"; [INFO] [stderr] | ----^^^^^^^^^^^---------------------- help: try: `let ant: &mut &'static str = &mut "42";` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/maybe/test.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | let ref mut iny: &&mut &str = &ant; [INFO] [stderr] | ----^^^^^^^^^^^-------------------- help: try: `let iny: &mut &&mut &str = &mut (&ant);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/maybe/mod.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | / match *self { [INFO] [stderr] 228 | | Nothing => *self = Just(v), [INFO] [stderr] 229 | | _ => (), [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____^ help: try this: `if let Nothing = *self { *self = Just(v) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let unit =` [INFO] [stderr] --> src/main.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | let unit: () = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | showme(unit); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 31 | showme(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.56s [INFO] running `"docker" "inspect" "47f678776a841cd3b204d4fc7b0ce232d46e8c7ebce8411be7f951c6e9607729"` [INFO] running `"docker" "rm" "-f" "47f678776a841cd3b204d4fc7b0ce232d46e8c7ebce8411be7f951c6e9607729"` [INFO] [stdout] 47f678776a841cd3b204d4fc7b0ce232d46e8c7ebce8411be7f951c6e9607729