[INFO] updating cached repository mamidon/rlox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mamidon/rlox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mamidon/rlox" "work/ex/clippy-test-run/sources/stable/gh/mamidon/rlox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mamidon/rlox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mamidon/rlox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mamidon/rlox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mamidon/rlox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fbeeb29db044b62e252b1b4719ecc026c1a16963 [INFO] sha for GitHub repo mamidon/rlox: fbeeb29db044b62e252b1b4719ecc026c1a16963 [INFO] validating manifest of mamidon/rlox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mamidon/rlox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mamidon/rlox [INFO] finished frobbing mamidon/rlox [INFO] frobbed toml for mamidon/rlox written to work/ex/clippy-test-run/sources/stable/gh/mamidon/rlox/Cargo.toml [INFO] started frobbing mamidon/rlox [INFO] finished frobbing mamidon/rlox [INFO] frobbed toml for mamidon/rlox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mamidon/rlox/Cargo.toml [INFO] crate mamidon/rlox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mamidon/rlox against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mamidon/rlox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da33195f18f9642880658503f4150450c908c5a9a5af21cc44f3d574ab890327 [INFO] running `"docker" "start" "-a" "da33195f18f9642880658503f4150450c908c5a9a5af21cc44f3d574ab890327"` [INFO] [stderr] Checking rlox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/seq.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/seq.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/tests.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/mod.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return self.create_token(token_type); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.create_token(token_type)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/mod.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return self.create_token(TokenType::Number); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.create_token(TokenType::Number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/mod.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/mod.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | return character; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `character` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/mod.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | return character; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `character` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chunks.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return bytecode; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bytecode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chunks.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return instruction; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `instruction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chunks.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return (2, Some((left, right))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(2, Some((left, right)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chunks.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return Some((self.constants.len() - 1) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((self.constants.len() - 1) as u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/seq.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/runtime.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return ExecutionResult::RuntimeError("Execution completed without a return statement"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ExecutionResult::RuntimeError("Execution completed without a return statement")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/seq.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/tests.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/mod.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return self.create_token(token_type); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.create_token(token_type)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/mod.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return self.create_token(TokenType::Number); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.create_token(TokenType::Number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/mod.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/mod.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | return character; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `character` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanning/mod.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | return character; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `character` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chunks.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return bytecode; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bytecode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chunks.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return instruction; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `instruction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chunks.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return (2, Some((left, right))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(2, Some((left, right)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chunks.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return Some((self.constants.len() - 1) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((self.constants.len() - 1) as u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/runtime.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return ExecutionResult::RuntimeError("Execution completed without a return statement"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ExecutionResult::RuntimeError("Execution completed without a return statement")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/debug.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | offset = offset + bytes_consumed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += bytes_consumed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/scanning/mod.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | if let None = next_character { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 64 | | return self.create_token(TokenType::EndOfFile); [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________- help: try this: `if next_character.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/scanning/mod.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / loop { [INFO] [stderr] 135 | | match self.source.peek_next().filter(|c| c.is_numeric()) { [INFO] [stderr] 136 | | Some(_) => self.consume_and_append(), [INFO] [stderr] 137 | | None => break [INFO] [stderr] 138 | | }; [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(_) = self.source.peek_next().filter(|c| c.is_numeric()) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/scanning/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | / loop { [INFO] [stderr] 145 | | match self.source.peek_next().filter(|c| c.is_numeric()) { [INFO] [stderr] 146 | | Some(_) => self.consume_and_append(), [INFO] [stderr] 147 | | None => break [INFO] [stderr] 148 | | }; [INFO] [stderr] 149 | | }; [INFO] [stderr] | |_____________^ help: try: `while let Some(_) = self.source.peek_next().filter(|c| c.is_numeric()) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/scanning/mod.rs:209:16 [INFO] [stderr] | [INFO] [stderr] 209 | if let Some(_) = character { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 210 | | self.current_character += 1; [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________- help: try this: `if character.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/runtime.rs:209:30 [INFO] [stderr] | [INFO] [stderr] 209 | LoxValue::Number(foo) => write!(f, "{}", foo), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/debug.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | offset = offset + bytes_consumed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += bytes_consumed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/scanning/mod.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | if let None = next_character { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 64 | | return self.create_token(TokenType::EndOfFile); [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________- help: try this: `if next_character.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/scanning/mod.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / loop { [INFO] [stderr] 135 | | match self.source.peek_next().filter(|c| c.is_numeric()) { [INFO] [stderr] 136 | | Some(_) => self.consume_and_append(), [INFO] [stderr] 137 | | None => break [INFO] [stderr] 138 | | }; [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(_) = self.source.peek_next().filter(|c| c.is_numeric()) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/scanning/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | / loop { [INFO] [stderr] 145 | | match self.source.peek_next().filter(|c| c.is_numeric()) { [INFO] [stderr] 146 | | Some(_) => self.consume_and_append(), [INFO] [stderr] 147 | | None => break [INFO] [stderr] 148 | | }; [INFO] [stderr] 149 | | }; [INFO] [stderr] | |_____________^ help: try: `while let Some(_) = self.source.peek_next().filter(|c| c.is_numeric()) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/scanning/mod.rs:209:16 [INFO] [stderr] | [INFO] [stderr] 209 | if let Some(_) = character { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 210 | | self.current_character += 1; [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________- help: try this: `if character.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/runtime.rs:209:30 [INFO] [stderr] | [INFO] [stderr] 209 | LoxValue::Number(foo) => write!(f, "{}", foo), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.07s [INFO] running `"docker" "inspect" "da33195f18f9642880658503f4150450c908c5a9a5af21cc44f3d574ab890327"` [INFO] running `"docker" "rm" "-f" "da33195f18f9642880658503f4150450c908c5a9a5af21cc44f3d574ab890327"` [INFO] [stdout] da33195f18f9642880658503f4150450c908c5a9a5af21cc44f3d574ab890327