[INFO] updating cached repository makos/cnew [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/makos/cnew [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/makos/cnew" "work/ex/clippy-test-run/sources/stable/gh/makos/cnew"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/makos/cnew'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/makos/cnew" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makos/cnew"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makos/cnew'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bc30894b5b9d386783679b091f72f8a8a84dbb65 [INFO] sha for GitHub repo makos/cnew: bc30894b5b9d386783679b091f72f8a8a84dbb65 [INFO] validating manifest of makos/cnew on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of makos/cnew on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing makos/cnew [INFO] finished frobbing makos/cnew [INFO] frobbed toml for makos/cnew written to work/ex/clippy-test-run/sources/stable/gh/makos/cnew/Cargo.toml [INFO] started frobbing makos/cnew [INFO] finished frobbing makos/cnew [INFO] frobbed toml for makos/cnew written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makos/cnew/Cargo.toml [INFO] crate makos/cnew has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting makos/cnew against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makos/cnew:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8d3b8cf42027f343e3a1ca366de47257eaaaf604db666355de3caba231cb3f15 [INFO] running `"docker" "start" "-a" "8d3b8cf42027f343e3a1ca366de47257eaaaf604db666355de3caba231cb3f15"` [INFO] [stderr] Checking cnew v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the `name @ _` pattern can be written as just `name` [INFO] [stderr] --> src/main.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | name @ _ => dir_name = name, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | fn build_dirs(paths: &Vec<&Path>) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Path]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | fn populate_dirs(paths: &Vec<&Path>) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Path]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | fn git_init(paths: &Vec<&Path>) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Path]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | fn show_help(bin_name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the `name @ _` pattern can be written as just `name` [INFO] [stderr] --> src/main.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | name @ _ => dir_name = name, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | fn build_dirs(paths: &Vec<&Path>) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Path]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | fn populate_dirs(paths: &Vec<&Path>) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Path]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | fn git_init(paths: &Vec<&Path>) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Path]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | fn show_help(bin_name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `"docker" "inspect" "8d3b8cf42027f343e3a1ca366de47257eaaaf604db666355de3caba231cb3f15"` [INFO] running `"docker" "rm" "-f" "8d3b8cf42027f343e3a1ca366de47257eaaaf604db666355de3caba231cb3f15"` [INFO] [stdout] 8d3b8cf42027f343e3a1ca366de47257eaaaf604db666355de3caba231cb3f15