[INFO] updating cached repository makoki13/rust_snipper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/makoki13/rust_snipper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/makoki13/rust_snipper" "work/ex/clippy-test-run/sources/stable/gh/makoki13/rust_snipper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/makoki13/rust_snipper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/makoki13/rust_snipper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makoki13/rust_snipper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makoki13/rust_snipper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f4afe79020d115336a092c636b7793535a910827 [INFO] sha for GitHub repo makoki13/rust_snipper: f4afe79020d115336a092c636b7793535a910827 [INFO] validating manifest of makoki13/rust_snipper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of makoki13/rust_snipper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing makoki13/rust_snipper [INFO] finished frobbing makoki13/rust_snipper [INFO] frobbed toml for makoki13/rust_snipper written to work/ex/clippy-test-run/sources/stable/gh/makoki13/rust_snipper/Cargo.toml [INFO] started frobbing makoki13/rust_snipper [INFO] finished frobbing makoki13/rust_snipper [INFO] frobbed toml for makoki13/rust_snipper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makoki13/rust_snipper/Cargo.toml [INFO] crate makoki13/rust_snipper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting makoki13/rust_snipper against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/makoki13/rust_snipper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f4261d483ebdde1cf154d6c9856540d51f3c95ebf43aaa18a9aabc371f36e24a [INFO] running `"docker" "start" "-a" "f4261d483ebdde1cf154d6c9856540d51f3c95ebf43aaa18a9aabc371f36e24a"` [INFO] [stderr] Checking separator v0.3.1 [INFO] [stderr] Checking sniper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/elementos/items.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / pub mod items { [INFO] [stderr] 4 | | [INFO] [stderr] 5 | | use elementos::proyectil::proyectil::Proyectil; [INFO] [stderr] 6 | | [INFO] [stderr] ... | [INFO] [stderr] 65 | | [INFO] [stderr] 66 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/elementos/items.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | cadena [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/elementos/items.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | let cadena = self.id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/elementos/proyectil.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod proyectil { [INFO] [stderr] 2 | | use rand; [INFO] [stderr] 3 | | [INFO] [stderr] 4 | | use elementos::items::items::Posicion; [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/elementos/proyectil.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | cadena [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/elementos/proyectil.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | let cadena = self.id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/elementos/items.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / pub mod items { [INFO] [stderr] 4 | | [INFO] [stderr] 5 | | use elementos::proyectil::proyectil::Proyectil; [INFO] [stderr] 6 | | [INFO] [stderr] ... | [INFO] [stderr] 65 | | [INFO] [stderr] 66 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/elementos/items.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | cadena [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/elementos/items.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | let cadena = self.id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/elementos/proyectil.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod proyectil { [INFO] [stderr] 2 | | use rand; [INFO] [stderr] 3 | | [INFO] [stderr] 4 | | use elementos::items::items::Posicion; [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/elementos/proyectil.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | cadena [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/elementos/proyectil.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | let cadena = self.id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `elementos::items::items::Item` [INFO] [stderr] --> src/elementos/items.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Item { [INFO] [stderr] 23 | | let random_number:u32 = rand::random(); [INFO] [stderr] 24 | | //let random_number: u8 = 20; [INFO] [stderr] 25 | | let nuevo_id:String = random_number.to_string(); [INFO] [stderr] ... | [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for elementos::items::items::Item { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] 25 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `elementos::proyectil::proyectil::Proyectil` [INFO] [stderr] --> src/elementos/proyectil.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Proyectil { [INFO] [stderr] 14 | | let random_number:u32 = rand::random(); [INFO] [stderr] 15 | | //let random_number: u8 = 20; [INFO] [stderr] 16 | | let nuevo_id:String = random_number.to_string(); [INFO] [stderr] ... | [INFO] [stderr] 22 | | [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for elementos::proyectil::proyectil::Proyectil { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] 17 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `elementos::items::items::Item` [INFO] [stderr] --> src/elementos/items.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Item { [INFO] [stderr] 23 | | let random_number:u32 = rand::random(); [INFO] [stderr] 24 | | //let random_number: u8 = 20; [INFO] [stderr] 25 | | let nuevo_id:String = random_number.to_string(); [INFO] [stderr] ... | [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for elementos::items::items::Item { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] 25 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `elementos::proyectil::proyectil::Proyectil` [INFO] [stderr] --> src/elementos/proyectil.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Proyectil { [INFO] [stderr] 14 | | let random_number:u32 = rand::random(); [INFO] [stderr] 15 | | //let random_number: u8 = 20; [INFO] [stderr] 16 | | let nuevo_id:String = random_number.to_string(); [INFO] [stderr] ... | [INFO] [stderr] 22 | | [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for elementos::proyectil::proyectil::Proyectil { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] 17 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | io::stdin().read_line(&mut input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | io::stdin().read_line(&mut input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "f4261d483ebdde1cf154d6c9856540d51f3c95ebf43aaa18a9aabc371f36e24a"` [INFO] running `"docker" "rm" "-f" "f4261d483ebdde1cf154d6c9856540d51f3c95ebf43aaa18a9aabc371f36e24a"` [INFO] [stdout] f4261d483ebdde1cf154d6c9856540d51f3c95ebf43aaa18a9aabc371f36e24a