[INFO] updating cached repository majorz/companame [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/majorz/companame [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/majorz/companame" "work/ex/clippy-test-run/sources/stable/gh/majorz/companame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/majorz/companame'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/majorz/companame" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/majorz/companame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/majorz/companame'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 57dbb25d3f0e270b767b0fdb592c4b7b8c3149dd [INFO] sha for GitHub repo majorz/companame: 57dbb25d3f0e270b767b0fdb592c4b7b8c3149dd [INFO] validating manifest of majorz/companame on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of majorz/companame on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing majorz/companame [INFO] finished frobbing majorz/companame [INFO] frobbed toml for majorz/companame written to work/ex/clippy-test-run/sources/stable/gh/majorz/companame/Cargo.toml [INFO] started frobbing majorz/companame [INFO] finished frobbing majorz/companame [INFO] frobbed toml for majorz/companame written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/majorz/companame/Cargo.toml [INFO] crate majorz/companame has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting majorz/companame against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/majorz/companame:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b86afcba5a977588f36febd5dec36ffc83a3059e522490e9dd1bd86d9c8da022 [INFO] running `"docker" "start" "-a" "b86afcba5a977588f36febd5dec36ffc83a3059e522490e9dd1bd86d9c8da022"` [INFO] [stderr] Checking companame v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | repeat: repeat, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `repeat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | repeat: repeat, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `repeat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeSet [INFO] [stderr] --> src/main.rs:170:53 [INFO] [stderr] | [INFO] [stderr] 170 | let mut vec: Vec<_> = map.get(&ch).unwrap().into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:170:31 [INFO] [stderr] | [INFO] [stderr] 170 | let mut vec: Vec<_> = map.get(&ch).unwrap().into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&ch]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeSet [INFO] [stderr] --> src/main.rs:170:53 [INFO] [stderr] | [INFO] [stderr] 170 | let mut vec: Vec<_> = map.get(&ch).unwrap().into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:170:31 [INFO] [stderr] | [INFO] [stderr] 170 | let mut vec: Vec<_> = map.get(&ch).unwrap().into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&ch]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.61s [INFO] running `"docker" "inspect" "b86afcba5a977588f36febd5dec36ffc83a3059e522490e9dd1bd86d9c8da022"` [INFO] running `"docker" "rm" "-f" "b86afcba5a977588f36febd5dec36ffc83a3059e522490e9dd1bd86d9c8da022"` [INFO] [stdout] b86afcba5a977588f36febd5dec36ffc83a3059e522490e9dd1bd86d9c8da022