[INFO] updating cached repository mahmudfasihulazam/remote-shell
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mahmudfasihulazam/remote-shell
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mahmudfasihulazam/remote-shell" "work/ex/clippy-test-run/sources/stable/gh/mahmudfasihulazam/remote-shell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mahmudfasihulazam/remote-shell'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mahmudfasihulazam/remote-shell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mahmudfasihulazam/remote-shell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mahmudfasihulazam/remote-shell'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 108e607d431c4b63080a12e5673fc38f36f83424
[INFO] sha for GitHub repo mahmudfasihulazam/remote-shell: 108e607d431c4b63080a12e5673fc38f36f83424
[INFO] validating manifest of mahmudfasihulazam/remote-shell on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mahmudfasihulazam/remote-shell on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mahmudfasihulazam/remote-shell
[INFO] finished frobbing mahmudfasihulazam/remote-shell
[INFO] frobbed toml for mahmudfasihulazam/remote-shell written to work/ex/clippy-test-run/sources/stable/gh/mahmudfasihulazam/remote-shell/Cargo.toml
[INFO] started frobbing mahmudfasihulazam/remote-shell
[INFO] finished frobbing mahmudfasihulazam/remote-shell
[INFO] frobbed toml for mahmudfasihulazam/remote-shell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mahmudfasihulazam/remote-shell/Cargo.toml
[INFO] crate mahmudfasihulazam/remote-shell has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mahmudfasihulazam/remote-shell against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mahmudfasihulazam/remote-shell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8e895d04cce5bac0824d525b0be02fbd14891f4ec3313e855faabb950b6b36db
[INFO] running `"docker" "start" "-a" "8e895d04cce5bac0824d525b0be02fbd14891f4ec3313e855faabb950b6b36db"`
[INFO] [stderr]     Checking remote-shell v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/built_ins/mod.rs:7:5
[INFO] [stderr]    |
[INFO] [stderr] 7  | /     return match path.as_ref() {
[INFO] [stderr] 8  | |         "cd" => cd(argv),
[INFO] [stderr] 9  | |         "pwd" => pwd(buf),
[INFO] [stderr] 10 | |         "exit" => exit(buf),
[INFO] [stderr] 11 | |         _ => -1,
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 7  |     match path.as_ref() {
[INFO] [stderr] 8  |         "cd" => cd(argv),
[INFO] [stderr] 9  |         "pwd" => pwd(buf),
[INFO] [stderr] 10 |         "exit" => exit(buf),
[INFO] [stderr] 11 |         _ => -1,
[INFO] [stderr] 12 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/built_ins/mod.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |         return 0;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/built_ins/mod.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         return -1;
[INFO] [stderr]    |         ^^^^^^^^^^ help: remove `return` as shown: `-1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/built_ins/mod.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/built_ins/mod.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return -3;
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `-3`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/exec/mod.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     return (name, argv);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(name, argv)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/exec/mod.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     return None;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/exec/mod.rs:87:5
[INFO] [stderr]    |
[INFO] [stderr] 87 |     return ret;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `ret`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/exec/mod.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         return run_command(command, buf);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `run_command(command, buf)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/exec/mod.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 |         return exit_status;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `exit_status`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     return cwd;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `cwd`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/built_ins/mod.rs:7:5
[INFO] [stderr]    |
[INFO] [stderr] 7  | /     return match path.as_ref() {
[INFO] [stderr] 8  | |         "cd" => cd(argv),
[INFO] [stderr] 9  | |         "pwd" => pwd(buf),
[INFO] [stderr] 10 | |         "exit" => exit(buf),
[INFO] [stderr] 11 | |         _ => -1,
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 7  |     match path.as_ref() {
[INFO] [stderr] 8  |         "cd" => cd(argv),
[INFO] [stderr] 9  |         "pwd" => pwd(buf),
[INFO] [stderr] 10 |         "exit" => exit(buf),
[INFO] [stderr] 11 |         _ => -1,
[INFO] [stderr] 12 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/built_ins/mod.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |         return 0;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/built_ins/mod.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         return -1;
[INFO] [stderr]    |         ^^^^^^^^^^ help: remove `return` as shown: `-1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/built_ins/mod.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/built_ins/mod.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return -3;
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `-3`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/exec/mod.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     return (name, argv);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(name, argv)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/exec/mod.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     return None;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/exec/mod.rs:87:5
[INFO] [stderr]    |
[INFO] [stderr] 87 |     return ret;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `ret`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/exec/mod.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         return run_command(command, buf);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `run_command(command, buf)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/exec/mod.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 |         return exit_status;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `exit_status`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     return cwd;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `cwd`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/built_ins/mod.rs:5:28
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn run_built_in(path : &String, argv : &Vec<String>,
[INFO] [stderr]   |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/built_ins/mod.rs:5:44
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn run_built_in(path : &String, argv : &Vec<String>,
[INFO] [stderr]   |                                            ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/built_ins/mod.rs:15:14
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn cd(argv : &Vec<String>) -> i32 {
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]   --> src/built_ins/mod.rs:16:8
[INFO] [stderr]    |
[INFO] [stderr] 16 |     if 0 >= argv.len() {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]    = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using 0 == argv.len() instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/built_ins/mod.rs:35:12
[INFO] [stderr]    |
[INFO] [stderr] 35 |     *buf = format!("exiting remote-shell");
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"exiting remote-shell".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/exec/mod.rs:38:17
[INFO] [stderr]    |
[INFO] [stderr] 38 | fn which(name : &String) -> Option<String> {
[INFO] [stderr]    |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/exec/mod.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         match fs::metadata(&p) {
[INFO] [stderr] 42 | |             Ok(m) => {
[INFO] [stderr] 43 | |                 if m.is_file() // regular file
[INFO] [stderr] 44 | |                     && m.permissions().mode() & 0o111 != 0 { // executable
[INFO] [stderr] ...  |
[INFO] [stderr] 52 | |             },
[INFO] [stderr] 53 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 41 |         if let Ok(m) = fs::metadata(&p) {
[INFO] [stderr] 42 |     if m.is_file() // regular file
[INFO] [stderr] 43 |         && m.permissions().mode() & 0o111 != 0 { // executable
[INFO] [stderr] 44 |         return Some(p);
[INFO] [stderr] 45 |     } else {
[INFO] [stderr] 46 |         ; // continue
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `remote-shell`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/built_ins/mod.rs:5:28
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn run_built_in(path : &String, argv : &Vec<String>,
[INFO] [stderr]   |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/built_ins/mod.rs:5:44
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn run_built_in(path : &String, argv : &Vec<String>,
[INFO] [stderr]   |                                            ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/built_ins/mod.rs:15:14
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn cd(argv : &Vec<String>) -> i32 {
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]   --> src/built_ins/mod.rs:16:8
[INFO] [stderr]    |
[INFO] [stderr] 16 |     if 0 >= argv.len() {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]    = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using 0 == argv.len() instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/built_ins/mod.rs:35:12
[INFO] [stderr]    |
[INFO] [stderr] 35 |     *buf = format!("exiting remote-shell");
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"exiting remote-shell".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/exec/mod.rs:38:17
[INFO] [stderr]    |
[INFO] [stderr] 38 | fn which(name : &String) -> Option<String> {
[INFO] [stderr]    |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/exec/mod.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         match fs::metadata(&p) {
[INFO] [stderr] 42 | |             Ok(m) => {
[INFO] [stderr] 43 | |                 if m.is_file() // regular file
[INFO] [stderr] 44 | |                     && m.permissions().mode() & 0o111 != 0 { // executable
[INFO] [stderr] ...  |
[INFO] [stderr] 52 | |             },
[INFO] [stderr] 53 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 41 |         if let Ok(m) = fs::metadata(&p) {
[INFO] [stderr] 42 |     if m.is_file() // regular file
[INFO] [stderr] 43 |         && m.permissions().mode() & 0o111 != 0 { // executable
[INFO] [stderr] 44 |         return Some(p);
[INFO] [stderr] 45 |     } else {
[INFO] [stderr] 46 |         ; // continue
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `remote-shell`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "8e895d04cce5bac0824d525b0be02fbd14891f4ec3313e855faabb950b6b36db"`
[INFO] running `"docker" "rm" "-f" "8e895d04cce5bac0824d525b0be02fbd14891f4ec3313e855faabb950b6b36db"`
[INFO] [stdout] 8e895d04cce5bac0824d525b0be02fbd14891f4ec3313e855faabb950b6b36db