[INFO] updating cached repository magniff/wtr
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/magniff/wtr
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/magniff/wtr" "work/ex/clippy-test-run/sources/stable/gh/magniff/wtr"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/magniff/wtr'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/magniff/wtr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/magniff/wtr"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/magniff/wtr'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] faa56db14c6b0a232e57be8e97a40154f42c1874
[INFO] sha for GitHub repo magniff/wtr: faa56db14c6b0a232e57be8e97a40154f42c1874
[INFO] validating manifest of magniff/wtr on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of magniff/wtr on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing magniff/wtr
[INFO] finished frobbing magniff/wtr
[INFO] frobbed toml for magniff/wtr written to work/ex/clippy-test-run/sources/stable/gh/magniff/wtr/Cargo.toml
[INFO] started frobbing magniff/wtr
[INFO] finished frobbing magniff/wtr
[INFO] frobbed toml for magniff/wtr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/magniff/wtr/Cargo.toml
[INFO] crate magniff/wtr has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting magniff/wtr against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/magniff/wtr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 81072b4da4b44eb3bcb650dc75def7100a6d9f8d766894acf1a5c2d0a54e962a
[INFO] running `"docker" "start" "-a" "81072b4da4b44eb3bcb650dc75def7100a6d9f8d766894acf1a5c2d0a54e962a"`
[INFO] [stderr]     Checking wtr v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     return program;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `program`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     return program;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `program`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/types.rs:6:30
[INFO] [stderr]   |
[INFO] [stderr] 6 | fn opcode_argument(bytecode: &Vec<u8>, state: &MachineState) -> usize {
[INFO] [stderr]   |                              ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:11:50
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn do_lshift(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                                  ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:18:50
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn do_rshift(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                                  ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:25:54
[INFO] [stderr]    |
[INFO] [stderr] 25 | fn do_setup_loop(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:37:52
[INFO] [stderr]    |
[INFO] [stderr] 37 | fn do_end_loop(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                                    ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:49:47
[INFO] [stderr]    |
[INFO] [stderr] 49 | fn do_inc(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                               ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:57:47
[INFO] [stderr]    |
[INFO] [stderr] 57 | fn do_dec(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                               ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:71:47
[INFO] [stderr]    |
[INFO] [stderr] 71 | fn do_add(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                               ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/types.rs:117:39
[INFO] [stderr]     |
[INFO] [stderr] 117 |     pub fn stepi(&mut self, bytecode: &Vec<u8>) -> bool {
[INFO] [stderr]     |                                       ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/common.rs:5:31
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn read_program(filename: &String) -> Vec<u8> {
[INFO] [stderr]   |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/types.rs:6:30
[INFO] [stderr]   |
[INFO] [stderr] 6 | fn opcode_argument(bytecode: &Vec<u8>, state: &MachineState) -> usize {
[INFO] [stderr]   |                              ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:11:50
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn do_lshift(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                                  ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:18:50
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn do_rshift(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                                  ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:25:54
[INFO] [stderr]    |
[INFO] [stderr] 25 | fn do_setup_loop(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:37:52
[INFO] [stderr]    |
[INFO] [stderr] 37 | fn do_end_loop(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                                    ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:49:47
[INFO] [stderr]    |
[INFO] [stderr] 49 | fn do_inc(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                               ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:57:47
[INFO] [stderr]    |
[INFO] [stderr] 57 | fn do_dec(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                               ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/types.rs:71:47
[INFO] [stderr]    |
[INFO] [stderr] 71 | fn do_add(state: &mut MachineState, bytecode: &Vec<u8>) {
[INFO] [stderr]    |                                               ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/types.rs:117:39
[INFO] [stderr]     |
[INFO] [stderr] 117 |     pub fn stepi(&mut self, bytecode: &Vec<u8>) -> bool {
[INFO] [stderr]     |                                       ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/common.rs:5:31
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn read_program(filename: &String) -> Vec<u8> {
[INFO] [stderr]   |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.79s
[INFO] running `"docker" "inspect" "81072b4da4b44eb3bcb650dc75def7100a6d9f8d766894acf1a5c2d0a54e962a"`
[INFO] running `"docker" "rm" "-f" "81072b4da4b44eb3bcb650dc75def7100a6d9f8d766894acf1a5c2d0a54e962a"`
[INFO] [stdout] 81072b4da4b44eb3bcb650dc75def7100a6d9f8d766894acf1a5c2d0a54e962a